Message ID | 20221107134604.596986-1-blarsen@redhat.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F2C1385829D for <patchwork@sourceware.org>; Mon, 7 Nov 2022 13:53:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F2C1385829D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667829238; bh=eGaKHLMtP9VLlHy0tY9UFb42sW52g21gWRkqCzv+EZ4=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=je2VYeWj5o5hOrC8MPRlXohulCTYmv+4VookKU7u0TDFWec32iwrEv+jwHB9VAuhS l/lNZtn4bqcLmzDpzuK1qLdju+PgTYnJf39AnVllGDcpeMSEq1n4AplSnhR/419Wus nflUneNKiMpqKk22SXPzJqkxzMziINBFtSUJ61Tk= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1E5B438582BB for <gdb-patches@sourceware.org>; Mon, 7 Nov 2022 13:52:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E5B438582BB Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-499-XMIdQIeROqO9xLc3tf8Bxg-1; Mon, 07 Nov 2022 08:52:50 -0500 X-MC-Unique: XMIdQIeROqO9xLc3tf8Bxg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C215101A58E for <gdb-patches@sourceware.org>; Mon, 7 Nov 2022 13:52:50 +0000 (UTC) Received: from fedora.redhat.com (ovpn-193-251.brq.redhat.com [10.40.193.251]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 855822028DC1; Mon, 7 Nov 2022 13:52:49 +0000 (UTC) To: gdb-patches@sourceware.org Cc: Bruno Larsen <blarsen@redhat.com> Subject: [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang Date: Mon, 7 Nov 2022 14:45:56 +0100 Message-Id: <20221107134604.596986-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Bruno Larsen <blarsen@redhat.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Cleanup gdb.cp tests when running with clang
|
|
Message
Guinevere Larsen
Nov. 7, 2022, 1:45 p.m. UTC
Following my previous series, where I tried to reduce the amount of failures when running gdb.base tests using clang, I moved to reducing errors in gdb.cp. Actual GDB issues are being addressed in separate patches, and this series is confined to just changing tests to either work or XFAIL/disable them, to make it simpler to keep track of issues. Changelog for v2: * Pushed 2 patches that were approved by Andrew * Added language test for all test_compiler calls * Added some logic to new compilation flags * Addressed all patch-specific comments from Andrew Bruno Larsen (9): gdb/testsuite: ignore Non-C-typedefs for gdb.cp/class2.exp gdb/testsuite: enable running gdb.cp/classes.exp with clang gdb/testsuite: account for clang's nested destructor calls on gdb.cp/mb-ctor.exp gdb/testsuite: add XFAIL to gdb.cp/derivation.exp when using Clang gdb/testsuite: allow for Clang style destructors on gdb.cp/m-static.exp gdb/testsuite: skip gdb.cp/anon-struct.exp when using Clang gdb/testsuite: disable some tests of gdb.cp/typeid.exp when using Clang gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp gdb/testsuite: disable gdb.cp/call-method-register.exp when not using gcc gdb/testsuite/gdb.cp/anon-struct.exp | 10 ++++++ gdb/testsuite/gdb.cp/call-method-register.exp | 5 +++ gdb/testsuite/gdb.cp/class2.exp | 9 ++++- gdb/testsuite/gdb.cp/classes.exp | 36 ++++++++++++++++++- gdb/testsuite/gdb.cp/derivation.exp | 4 +++ gdb/testsuite/gdb.cp/m-static.exp | 11 +++--- gdb/testsuite/gdb.cp/mb-ctor.exp | 18 ++++++++++ gdb/testsuite/gdb.cp/temargs.exp | 6 ++-- gdb/testsuite/gdb.cp/typeid.exp | 10 +++++- 9 files changed, 99 insertions(+), 10 deletions(-)
Comments
>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
Bruno> Following my previous series, where I tried to reduce the amount of
Bruno> failures when running gdb.base tests using clang, I moved to reducing
Bruno> errors in gdb.cp.
Bruno> Actual GDB issues are being addressed in separate patches, and this
Bruno> series is confined to just changing tests to either work or
Bruno> XFAIL/disable them, to make it simpler to keep track of issues.
Thank you. I read through this and had one minor comment.
The rest looks good to me.
Some of the xfail'd tests seem like "bad" tests in a way -- they are
testing the compiler as much as gdb. Ideally I guess we would have used
the DWARF assembler for these, but it probably didn't exist back then
(and is more of a pain anyhow).
Also, call-method-register.exp in particular seems fragile at best.
thanks,
Tom
On 10/11/2022 19:24, Tom Tromey wrote: >>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes: > Bruno> Following my previous series, where I tried to reduce the amount of > Bruno> failures when running gdb.base tests using clang, I moved to reducing > Bruno> errors in gdb.cp. > > Bruno> Actual GDB issues are being addressed in separate patches, and this > Bruno> series is confined to just changing tests to either work or > Bruno> XFAIL/disable them, to make it simpler to keep track of issues. > > Thank you. I read through this and had one minor comment. > The rest looks good to me. Thank you! I'll apply your suggestion and push the whole series > > Some of the xfail'd tests seem like "bad" tests in a way -- they are > testing the compiler as much as gdb. Ideally I guess we would have used > the DWARF assembler for these, but it probably didn't exist back then > (and is more of a pain anyhow). I agree, but since my plan was fixing stuff with clang and dwarf assembler requires gcc, it didn't feel like the best use of my time. > > Also, call-method-register.exp in particular seems fragile at best. Yeah, me and Andrew thought the same thing, and andrew even submitted a port of it as a reply to my previous series. I encouraged him to submit as a standalone patch, but I don't think he did. Here's his original submission: https://sourceware.org/pipermail/gdb-patches/2022-October/193208.html