mbox series

[0/9] Fix "finish" with variably-sized types

Message ID 20221007180120.1866772-1-tromey@adacore.com
Headers
Series Fix "finish" with variably-sized types |

Message

Tom Tromey Oct. 7, 2022, 6:01 p.m. UTC 
  The "finish" command does not correctly work with variably-sized
types.  This affects some Ada programs; I'm not sure whether it can
affect programs written in other languages.

This series fixes the problem, for the architectures I could test.
Patch #2 explains this.

Regression tested on x86-64 Fedora 34.  I also ran this through the
AdaCore internal test suite, on all the architectures that are touched
by this series.

Tom

Comments

Tom Tromey Jan. 3, 2023, 4:44 p.m. UTC | #1 
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> The "finish" command does not correctly work with variably-sized
Tom> types.  This affects some Ada programs; I'm not sure whether it can
Tom> affect programs written in other languages.

Tom> This series fixes the problem, for the architectures I could test.
Tom> Patch #2 explains this.

Tom> Regression tested on x86-64 Fedora 34.  I also ran this through the
Tom> AdaCore internal test suite, on all the architectures that are touched
Tom> by this series.

I've rebased this series.  It required one minor change to adapt to some
other work in this area.

I've re-regression tested it on x86-64 Fedora 36.  We've also been using
this internally at AdaCore since October or so, regularly testing on all
the platforms that are touched by the series.

I'm checking it in now.

thanks,
Tom