diff mbox series

libphobos: Disable libphobos.phobos/std/concurrency.d on macOS 13+ [PR111628]

Message ID yddwmdyhtm7.fsf@CeBiTec.Uni-Bielefeld.DE
State Committed
Commit b7008552b493edaca6af041a18ff436c37f259bc
Headers
Series libphobos: Disable libphobos.phobos/std/concurrency.d on macOS 13+ [PR111628] |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_simplebootstrap_build--master-arm-bootstrap success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_simplebootstrap_build--master-aarch64-bootstrap success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Rainer Orth Feb. 10, 2025, 12:28 p.m. UTC 
  The libphobos.phobos_shared/std/concurrency.d test just hangs on macOS
13 and beyond and isn't even termintated after the testsuite timeout is
exceeded.  Thus, more and more concurrency.exe processes keep
accumulating, consuming CPU time for nothing.

To avoid this, this patch skips the test on macOS 13+.  The static test
SEGVs immediately instead, but I'm skipping it too for symmetry.

Tested no macOS 15 (where it becomes UNSUPPORTED) and 12 (where it still
PASSes).

I have no idea what happens on Darwin/arm64, so currently the skipping
is restricted to Darwin/x86_64.

Ok for trunk?

	Rainer

Comments

Iain Buclaw Feb. 10, 2025, 2:31 p.m. UTC | #1 
Thanks Rainer.

This is fine until the cause is identified.

Iain.

On 10 February 2025 13:28:00 CET, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>The libphobos.phobos_shared/std/concurrency.d test just hangs on macOS
>13 and beyond and isn't even termintated after the testsuite timeout is
>exceeded.  Thus, more and more concurrency.exe processes keep
>accumulating, consuming CPU time for nothing.
>
>To avoid this, this patch skips the test on macOS 13+.  The static test
>SEGVs immediately instead, but I'm skipping it too for symmetry.
>
>Tested no macOS 15 (where it becomes UNSUPPORTED) and 12 (where it still
>PASSes).
>
>I have no idea what happens on Darwin/arm64, so currently the skipping
>is restricted to Darwin/x86_64.
>
>Ok for trunk?
>
>	Rainer
>
>-- 
>-----------------------------------------------------------------------------
>Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
>2025-02-10  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>	PR d/111628
>	* testsuite/libphobos.phobos/phobos.exp (libphobos_skip_tests):
>	Add libphobos.phobos/std/concurrency.d on macOS 13+.
>	* testsuite/libphobos.phobos_shared/phobos_shared.exp
>	(libphobos_skip_tests): Likewise for
>	libphobos.phobos_shared/std/concurrency.d
>
diff mbox series

Patch

# HG changeset patch
# Parent  5a9fb5a372714eb68c3657870884a3b8b47cc268
libphobos: Disable libphobos.phobos/std/concurrency.d on macOS 13+ [PR111628]

diff --git a/libphobos/testsuite/libphobos.phobos/phobos.exp b/libphobos/testsuite/libphobos.phobos/phobos.exp
--- a/libphobos/testsuite/libphobos.phobos/phobos.exp
+++ b/libphobos/testsuite/libphobos.phobos/phobos.exp
@@ -37,6 +37,8 @@  set libphobos_skip_tests {
     # Skip curl tests if library is not available
     { libphobos.phobos/etc/c/curl.d { ! libcurl_available } }
     { libphobos.phobos/std/net/curl.d { ! libcurl_available } }
+    # Skip concurrency.d test: SEGVs or hangs on macOS 13+ (PR d/111628).
+    { libphobos.phobos/std/concurrency.d { x86_64-apple-darwin2[2-9]* } }
 }
 
 # Initialize dg.
diff --git a/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp b/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp
--- a/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp
+++ b/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp
@@ -37,6 +37,8 @@  set libphobos_skip_tests {
     # Skip curl tests if library is not available
     { libphobos.phobos_shared/etc/c/curl.d { ! libcurl_available } }
     { libphobos.phobos_shared/std/net/curl.d { ! libcurl_available } }
+    # Skip concurrency.d test: SEGVs or hangs on macOS 13+ (PR d/111628).
+    { libphobos.phobos_shared/std/concurrency.d { x86_64-apple-darwin2[2-9]* } }
 }
 
 # Initialize dg.