From patchwork Mon Oct 25 13:53:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 46614 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E2543858035 for ; Mon, 25 Oct 2021 13:54:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 962C23858C27 for ; Mon, 25 Oct 2021 13:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 962C23858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 5705CB1CA1; Mon, 25 Oct 2021 15:53:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3hvdaScegYep; Mon, 25 Oct 2021 15:53:50 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855d38.dip0.t-ipconnect.de [80.133.93.56]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id AF811B1D2F; Mon, 25 Oct 2021 15:53:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1635170030; bh=yHJnrC7OCs7HvpHV3fGR+7rLottdX0SH5gJvZM40K0w=; h=From:To:Cc:Subject:Date:From; b=Lk9Hb3Bq1j5djiTOXqEH3qJF/AAUIcTwsrUxWYzS4yQQHQvmi/jCegnk5CCy6ynC2 Tb4tv7sFkC528eg+wBAn41qlD4JRrSqEPJWsWFJTdFxKSxnWTc6Z5gY7Z99APIVrum EtBsKvHkfq2S3B9e3nZf2IkDD0iwVwPdvDVCYHNVoxu0CMh9ux/5Im+FZc4WlF9X2H tQcQ831RKO3usP5P6pN6EHU1tD2uxS5LDbUIoVNR3q+sIlUUUsAdAjDnyTAOkgLsgC dqYWYtdt7wR52XchaGobUG9kmy5EMG1LrFrpFE1VAaBiR+rRrRoP+9CxATQ6LdsmXI S2DWatzYEPhhA== From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: [PATCH] testsuite: i386: Fix gcc.target/i386/avx512fp16-trunchf.c on Solaris [PR102835] Date: Mon, 25 Oct 2021 15:53:50 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 X-Spam-Status: No, score=-3795.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The gcc.target/i386/avx512fp16-trunchf.c test FAILs on 32-bit Solaris/x86: FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2si[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 3 FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2usi[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 2 This happens because Solaris defaults to -fno-omit-frame-pointer, so it uses %ebp instead of the expected %esp. As Hongyu Wang suggested in the PR, this can be fixed by accepting both forms, which this patch does. Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu. Ok for master? Rainer # HG changeset patch # Parent 42f3c920a9840cff9344293def88b179095d62bd testsuite: i386: Fix gcc.target/i386/avx512fp16-trunchf.c on Solaris [PR102835] diff --git a/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c b/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c --- a/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c +++ b/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c @@ -1,7 +1,7 @@ /* { dg-do compile } */ /* { dg-options "-O2 -mavx512fp16" } */ -/* { dg-final { scan-assembler-times "vcvttsh2si\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%esp\\))+, %eax(?:\n|\[ \\t\]+#)" 3 } } */ -/* { dg-final { scan-assembler-times "vcvttsh2usi\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%esp\\))+, %eax(?:\n|\[ \\t\]+#)" 2 } } */ +/* { dg-final { scan-assembler-times "vcvttsh2si\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%e\[bs\]p\\))+, %eax(?:\n|\[ \\t\]+#)" 3 } } */ +/* { dg-final { scan-assembler-times "vcvttsh2usi\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%e\[bs\]p\\))+, %eax(?:\n|\[ \\t\]+#)" 2 } } */ /* { dg-final { scan-assembler-times "vcvttsh2si\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+, %rax(?:\n|\[ \\t\]+#)" 1 { target { ! ia32 } } } } */ /* { dg-final { scan-assembler-times "vcvttsh2usi\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+, %rax(?:\n|\[ \\t\]+#)" 1 { target { ! ia32 } } } } */ /* { dg-final { scan-assembler "xorl\[ \\t\]+%edx, %edx" { target ia32 } } } */