diff mbox series

libphobos: Skip libphobos.shared/finalize.d etc. on Solaris [PR88150]

Message ID ydd1pgsqmpn.fsf@CeBiTec.Uni-Bielefeld.DE
State Committed
Commit b1a3ff0e9f34fba8c7f5998838a4da713ea20a9a
Headers
Series libphobos: Skip libphobos.shared/finalize.d etc. on Solaris [PR88150] |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Rainer Orth April 6, 2026, 12:48 p.m. UTC 
  Three libphobos tests currently FAIL on Solaris:

FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
FAIL: libphobos.shared/load.d -shared-libphobos -ldl execution test
FAIL: libphobos.shared/load_13414.d -shared-libphobos -ldl execution test

As discussed in PR d/88150, those tests cannot work with refCounted =
false in gcc.sections.elf.handleForName.

Because the test names include additional options, the file name needs
to be extracted first before matching against libphobos_skip_tests.

Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11.

Ok for trunk?

	Rainer


I'm currently trying to get those tests actually fixed, but am not
getting there yet and don't know if this will be in time for GCC 16.

Besides, I think having the options in the test names only adds noise
since they aren't necessary to distuinguish several runs of the tests
with different options.  I'll look into this separately.

Comments

Iain Buclaw April 8, 2026, 5:27 a.m. UTC | #1 
Excerpts from Rainer Orth's message of April 6, 2026 2:48 pm:
> Three libphobos tests currently FAIL on Solaris:
> 
> FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> FAIL: libphobos.shared/load.d -shared-libphobos -ldl execution test
> FAIL: libphobos.shared/load_13414.d -shared-libphobos -ldl execution test
> 
> As discussed in PR d/88150, those tests cannot work with refCounted =
> false in gcc.sections.elf.handleForName.
> 
> Because the test names include additional options, the file name needs
> to be extracted first before matching against libphobos_skip_tests.
> 
> Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11.
> 
> Ok for trunk?
> 

OK.

Thanks,
Iain.
diff mbox series

Patch

# HG changeset patch
# Parent  59c93ee05e6ea04ddc602dce1ad4384a093f2ee8
libphobos: Skip libphobos.shared/finalize.d etc. on Solaris [PR88150]

diff --git a/libphobos/testsuite/lib/libphobos.exp b/libphobos/testsuite/lib/libphobos.exp
--- a/libphobos/testsuite/lib/libphobos.exp
+++ b/libphobos/testsuite/lib/libphobos.exp
@@ -312,6 +312,8 @@  proc filter_libphobos_unittests { list }
 proc libphobos_skipped_test_p { test } {
     global libphobos_skip_tests
 
+    # Extract test name.
+    set test [lindex $test 0]
     set row [lsearch -inline -index 0 $libphobos_skip_tests $test]
     if { $row eq "" } {
 	return ""
diff --git a/libphobos/testsuite/libphobos.shared/shared.exp b/libphobos/testsuite/libphobos.shared/shared.exp
--- a/libphobos/testsuite/libphobos.shared/shared.exp
+++ b/libphobos/testsuite/libphobos.shared/shared.exp
@@ -64,6 +64,13 @@  shared_library "$srcdir/$subdir/lib_1341
 shared_library "$srcdir/$subdir/plugin.d" "plugin1.so" ""
 shared_library "$srcdir/$subdir/plugin.d" "plugin2.so" ""
 
+set libphobos_skip_tests {
+    # Skip some tests: dlopen handles are not unique on Solaris (PR d/88150).
+    { libphobos.shared/finalize.d { *-*-solaris2* } }
+    { libphobos.shared/load.d { *-*-solaris2* } }
+    { libphobos.shared/load_13414.d { *-*-solaris2* } }
+}
+
 # Initialize dg.
 dg-init