From patchwork Mon Jan 30 21:55:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 63930 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B4E5385842C for ; Mon, 30 Jan 2023 21:56:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9B4E5385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675115761; bh=SBmLR8VVhZNXWF4dJIpN1P1GvQA5hlo7n3ZOMtGsBg8=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZjZkBI9Ty2/++wKjkb1B4IlN14GeWJAQVMRO5WOjqJ1heFbaAkVhuPxrg/0sATvEJ ZcJQmUlydHSMuNqcey0FaCGhSw7D3NYW6SeWUKustWDA9sEo1HgzqU6Uy6zV+r7ji6 1sZzz509cb5/Xcthpy0cJA4h9j+S+jJ8Zwqq9rO8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 50CCA3858C5F; Mon, 30 Jan 2023 21:55:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50CCA3858C5F X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.90.196] ([93.207.90.196]) by web-mail.gmx.net (3c-app-gmx-bap49.server.lan [172.19.172.119]) (via HTTP); Mon, 30 Jan 2023 22:55:31 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] Fortran: prevent redundant integer division truncation warnings [PR108592] Date: Mon, 30 Jan 2023 22:55:31 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:SiQSRHLJgThqdqEP74FS6aPDUvElc/e9FwAfY2mqHYm68PH7vE9RiVNMNnltre6YJflej yh9t7dfZi5lyLGsiEDjmtZUh4+iAc3+SBNxaK/upv3i5MwCwgg5UPFPeAaZxn0Op5PWPbZYv9QQi 9uRxeC+7OJFI1jDy5A8Sv6mAQ766CqO+xNUhSh2kWo330fcWUTZV3vANgibjRBXKihihj8y1vrbr lc12I1TO2kezNKoW7AY3xPpEBzuYlh6ODs3sFS796pXTVJKU/Yvh3S/3WqaanOR6EQiP1ZMH/26l pQ= UI-OutboundReport: notjunk:1;M01:P0:1tNpB7/tHKU=;/Yr2RLW4r8hxIJ11dhCdCskoeQ2 LFgB097Sas9/snx/smYM0wV+pqjp3/FtrVEO0z9KyUNRIy2FUKhn+l38xGAb9bR1Z1dukwzX2 9Vr6xn+4d/7IxwSIN8RSuMYCzKSZ/R2Hsj3v6R7Cni5Dx7tsu6gbEEZPYBnXiRykSV/EAMwKv chRwp1twrd4G2+8wUsVX3ye8iWyJ7iFyKpRLSGeGzz5LnigUvxdecUyozr8B+S2j+9Au5k8iX qnsPEcexzhTf6SDtn89+S5IdvuA7675klbix6jY7+BLc+eILEFhASoJ65wOALfmSD23zqvuDK SXr9pMhJiebMRz7SzjxpzoBic6OTlwbGKrD1TE7jG+vDy6Wmd1u6Gu/2x49bZ6yjED6+uiguh Txh7LolT8W082xMt3pTPYxn6zkwn6rdE1+ZzuOhhH96UTaT5J9OgebU+Dfxc4C0DOYMXZVkB1 GPWtrrWJpDtxfqCrYuveMPvhhjjzEyfYu7DN9dRjhfGTcXVmcHvNdxVo2UmzQq57lBf8yKZ/b +Ft30yfCNEVv+6w3JeneBUw2KsddqhxpXwl79pS0Hh56zM/vRSjZBGFbrRzw+ioyC8QN1SiKM KwI26Su9D4T9uI4H03BfoJkBXoTklG/XBSTmeSle83TlaNIqkBr9sX56J9WFoGSbmaL0mLU3V lR3O+0ldZtlcscU0/zOLh4SaJ/Hg3C0UZ78XUGseW2Mk7mTxti3IIAgQn8t2zAcvDg0QOoevt ovqS+7+59IgLZQ8KIBGfo3wiu4nF9QnzE6g2yrt6MLxmGeJtgHVqqZ5Eq+OuV2C257NQihSXg t3xJTReBf2rbNST7uLu1PlFQ== X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Dear Fortranners, the subject says it all: in some cases we emit redundant integer division truncation warnings (2 or 4), where just one would have been sufficient. This is solved by using gfc_warning instead of gfc_warning_now. The testcase uses a suggestion by Andrew to verify that we get the desired warning exactly once. Regtested on x86_64-pc-linux-gnu. OK for mainline? Thanks, Harald From 8340523c8df8edd008174d44e87c0fa54b58b2c7 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Mon, 30 Jan 2023 22:46:43 +0100 Subject: [PATCH] Fortran: prevent redundant integer division truncation warnings [PR108592] gcc/fortran/ChangeLog: PR fortran/108592 * arith.cc (gfc_arith_divide): Emit integer division truncation warnings using gfc_warning instead of gfc_warning_now to prevent redundant messages. gcc/testsuite/ChangeLog: PR fortran/108592 * gfortran.dg/pr108592.f90: New test. --- gcc/fortran/arith.cc | 2 +- gcc/testsuite/gfortran.dg/pr108592.f90 | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gfortran.dg/pr108592.f90 diff --git a/gcc/fortran/arith.cc b/gcc/fortran/arith.cc index 6de6d21c73d..d0d1c0b03d2 100644 --- a/gcc/fortran/arith.cc +++ b/gcc/fortran/arith.cc @@ -778,7 +778,7 @@ gfc_arith_divide (gfc_expr *op1, gfc_expr *op2, gfc_expr **resultp) { char *p; p = mpz_get_str (NULL, 10, result->value.integer); - gfc_warning_now (OPT_Winteger_division, "Integer division " + gfc_warning (OPT_Winteger_division, "Integer division " "truncated to constant %qs at %L", p, &op1->where); free (p); diff --git a/gcc/testsuite/gfortran.dg/pr108592.f90 b/gcc/testsuite/gfortran.dg/pr108592.f90 new file mode 100644 index 00000000000..224b1d8d1fc --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr108592.f90 @@ -0,0 +1,8 @@ +! { dg-do compile } +! { dg-options "-Winteger-division" } +! PR fortran/108592 - warn only once for truncation of integer division + +program foo + if (8 < (20/9)) stop 1 ! { dg-bogus "Integer division.*Integer division" } +! { dg-message "Integer division truncated" "" { target *-*-* } .-1 } +end program -- 2.35.3