From patchwork Wed Nov 16 20:50:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 60714 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C591396D835 for ; Wed, 16 Nov 2022 20:50:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C591396D835 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668631844; bh=yjLb6q8WymXOqqibABqWIOUQvKTFBPM6293/dsinhZQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=iVr25QGC2VnGRcwZYYJx9iaf53SsG78SW8WOUcRY5pCVdUJVuyKthalKHklVrYW7t inZsJqHfVbACFfi8Sezeq3xjRZThdYC/LRvIGJG2Czy406Sac0UYJ4EGDjBWrsmO2S xyrsYu6hivK01saDV9lNb5N1rQBvhjnu8GCgYV64= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 6193C396D826; Wed, 16 Nov 2022 20:50:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6193C396D826 X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.86.187] ([93.207.86.187]) by web-mail.gmx.net (3c-app-gmx-bap19.server.lan [172.19.172.89]) (via HTTP); Wed, 16 Nov 2022 21:50:13 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] Fortran: error recovery after reference to bad CLASS variable [PR107681] Date: Wed, 16 Nov 2022 21:50:13 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:DgnUVe08aLO5T/sWIelnmJMBjLB9o703ibckEBotqEIeLLSRo+mXxLlX3vuezQj8Wh6I7 NmUPoNY0gnldxouayPtJ2VUR9fYJN30A0quItvUfWBtO8lIC0X1EUQ9sZeUdtw6tCEjRjgn3JyuC 0qGl6FsMdMt8XcskW4JE9FiSkjhdGb4RTAa9lIAMklJz88yE7zgHe8c1SP3slsSrRw7I9nIajoPN xSlkSjiFNH0MZTGeH823pAsP4z6+ZMQoavf3fKNYGIyc2Y+tfO8O/ErCKlZSZ9vxILhS3aa7yL1o Cc= UI-OutboundReport: notjunk:1;M01:P0:dfzvwV0brCY=;DMl3GXL7xI0EYTQcWiiqY/Zorer enP+juEvTwgfPorlAKb0orpwvU5kNmAqgToT6i3Hh5o4FT0TZgDd/LQbPNr+I+g0jh5r+ad2G Z4d02jMF4xPt1Hf8loQA/vWrx3hwcZHPFR/pNKDviU4euhz2CTAuJ7VHA8Lbww4UsdmBQ0Eja 0svHL7TrV5eAvibvaPzBsACvoUKYJRhzxsD60RMXHKPd4jv+OsEMT1IJjzOwU1bMCQMrX3a8k oHQ99OL16Bm3YSkQWptMhwOWwFIT9D0ggRbR730CqDY+wtsmsqDNr9IUdJ7LYf+ZHm+PNitU9 4sf+SkLit3r5G6pjQqRJE9XpDRaQ9V6J9xuBBsGt98HjSXpDHfRGCUU1DpV1bdPcrMM2elB9f KsJThyTiqCmbjhgVW5Jq+P7k2f2HFzq6UtJSrEn+YnehawIik6XpE6yMtw3esH0D4X3/fLOQn X2dgnTI4twJ0nGaVT5KlyRJDD469kYjxza89UI1I4aQmhDTLTnu82ZcBhQ4St2pzZ/CXQ6SBc VQHIoR3rlNDIQr/XfNPsTaZQ942wW9wvWLCscdUWRY2HPgnwu8FnoGuAIsGF6XavKNrB7IqkQ u1lNs+a7Agq1JNflOyetjX+eyb1J5JLj4JbaTzTsdQvmHwcLAegAmugzYrLKfSRmm6tS/0nnc pda4Xi1bKwbwIxQ+xcY1tCdSg43bfDceje8YDj6lfSpLHGnz578nuqYkFR653QGPcacqVVMVz NDjMzc8AXRkoAkVT7cftpJn8hMfJJuRY9BGMa5LZdKSd3Ck5fkjeovTkzljXi3y/e6nZng/NQ lrMn+mRZxOaa/oQjoy/ROhEg== X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Dear all, the attached obvious patch fixes a NULL pointer dereference when referencing a CLASS variable with a bad decl. Pushed as r13-4107-g96e4244ef3ccf4867ca4e37fbc6800e64ef30af6 after regtesting on x86_64-pc-linux-gnu. Thanks, Harald From 96e4244ef3ccf4867ca4e37fbc6800e64ef30af6 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Wed, 16 Nov 2022 21:41:19 +0100 Subject: [PATCH] Fortran: error recovery after reference to bad CLASS variable [PR107681] gcc/fortran/ChangeLog: PR fortran/107681 * resolve.cc (resolve_fl_var_and_proc): Prevent NULL pointer dereference with reference to bad CLASS variable. gcc/testsuite/ChangeLog: PR fortran/107681 * gfortran.dg/pr107681.f90: New test. --- gcc/fortran/resolve.cc | 1 + gcc/testsuite/gfortran.dg/pr107681.f90 | 13 +++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pr107681.f90 diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 5ff1cd070ac..24e5aa03556 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -12967,6 +12967,7 @@ resolve_fl_var_and_proc (gfc_symbol *sym, int mp_flag) && sym->ts.u.derived && !sym->attr.select_type_temporary && !UNLIMITED_POLY (sym) + && CLASS_DATA (sym)->ts.u.derived && !gfc_type_is_extensible (CLASS_DATA (sym)->ts.u.derived)) { gfc_error ("Type %qs of CLASS variable %qs at %L is not extensible", diff --git a/gcc/testsuite/gfortran.dg/pr107681.f90 b/gcc/testsuite/gfortran.dg/pr107681.f90 new file mode 100644 index 00000000000..0999ad92649 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr107681.f90 @@ -0,0 +1,13 @@ +! { dg-do compile } +! { dg-options "-fcoarray=lib" } +! PR fortran/107681 - ICE in gfc_type_is_extensible +! Contributed by G.Steinmetz + +program p + type t + integer, allocatable :: a + end type + class(t) :: x[*] ! { dg-error "must be dummy, allocatable or pointer" } + associate (y => x) ! { dg-error "Invalid array reference" } + end associate +end -- 2.35.3