From patchwork Thu Nov 17 20:48:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 60805 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0B2E3852235 for ; Thu, 17 Nov 2022 20:48:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0B2E3852235 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668718113; bh=LJ6NQsSlDBmSD1rX8peoVJiWLIuMmJGt79EbemRDViM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Tqw7a/rd7t5nl/A05OJCXBiHTYFYh6iN7sP29SWj9Hc4eGdN4V/dOHSzh5vhBjUGx CMODgIswcjjioJ/lc74MC940ERSfXEdtz+yRGksbtnjrAeFKgTj7ExyPhaWa+3sInF 4h4avOaGZokW/S4sCcY99m3eCsgie4FIUEEOlIyA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id E7BF73852200; Thu, 17 Nov 2022 20:48:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7BF73852200 X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.84.59] ([93.207.84.59]) by web-mail.gmx.net (3c-app-gmx-bap50.server.lan [172.19.172.120]) (via HTTP); Thu, 17 Nov 2022 21:48:01 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] Fortran: reject NULL actual argument without explicit interface [PR107576] Date: Thu, 17 Nov 2022 21:48:01 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:/8Cdj2MFC0EohNF+my6gVV/Tjzqqa7P28j8BOYpirLXl6WJ6PeBsQXNSxet36jPhJQiEP O1ajl1dsLVkeIHHX0M8r6PMXwcaq2mUsQJ3YdiPSVhbN42dg4h8diAvM741KnS23MBV2eYhb7wGb 2JA1G/JJthGTryAnyyCQTPtGTUQY5tzabGCMDOz4irtX5dR/RTMbIk7MU1TcfI2d4vqM4IfdtprM 8jPAEoZgLZrpNbOOyRVtSUadeRIbryxWSixVWTuGQ9zSLl9mQ4gnqj7E/O+2Lg87xyx0ZstbBMwX sA= UI-OutboundReport: notjunk:1;M01:P0:OeNBilEjyc8=;eHcQ+SVbaNZbdirh+nlxuB6XYmU QMbfuqqbxltY8q+L9uf/mfCuoYyjK9A5aB/ORfi/M2eKKTu1FoAADzj+JT1tLdyopNZ/KW4HV s4Vfpypeg7NMpCBQf0P6OucYqDBykcc5Ys36ChK41XmefLR/fuDyqaCcJdqpXC+pWWxZLHFDr Wk71k5RBxQhy6uwBRZdEVUnFJg4K6fIsO/FKdlZkBGFp2gaZZD2Zv5QyKCa2F6UUqQQMFrpRI 0jcJr9XSoV+dcdakIqI1HBD9YSqJINgETuUjolvbeu6STchek5p64vS6TnsoOXYeMLWCTwGN7 3/Bpks6uV8OWA6KhKu3voWvRrnKpg7qlDbIIa7FTXlvyn+iK/P+bX0WwhKpZK89znR6b3EBWS XJGsQpu82pjSyj6YzEeKzaPHQJrD3eC6ZOPTLRdDHmTgyc2lGiHM7VsnSUq2aHi8BqmRKjk9t 8wzDEJxKq3Ujyhpf2Us33R/wFayRzIIETgLjIPXw83ws6iOKBN02jSPo5QsKnBiwc9FbRIgL4 yh96Mk46QhwGlR7d945XqBezWdl4sGi0NqkWIYmrY88A/NXDVtNy5Ix+hBt/XSj6qVleROeaG dfxUvJLBdDbxQCNXym8UuUtuNJINAS6qt2QeVHBGP2CGzuYy/X2DjBI7jQVubX3Bq9wd1c9vO Vzvj8XMjdyJOzaR8pDrFqvCDs7iyuwMFPQ2uFcfOPJ36QAu4PDVn++zNNvtEadV3uB7XsnksW NTiMcN9CvKJZflwKomxNHi4mNhRPt+jJKb8PD97kkL6FlxbuseroI9rjugGEHXCpOhtITxQrA vl/9jZdG5DUrNl9X77bAo9ysJr6oXwu5rdqVr0XyWvG8s= X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Dear all, one cannot pass a NULL actual argument to a procedure without an explicit interface. This is detected and reported by NAG and Intel. (Cray accepts this silently, and some other brands ICE.) The testcase by Gerhard even tricked gfortran into inconsistent behavior which could lead to an ICE with -fallow-argument-mismatch, or silently accepting invalid code. The solution is to reject such code, see attached patch. Regtested on x86_64-pc-linux-gnu. OK for mainline? As this is marked as a regression which started at v7, OK for backports to open branches? Thanks, Harald From c6b19d662f51b1e2d2691e81cfeb68ad953a4c09 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Thu, 17 Nov 2022 21:36:49 +0100 Subject: [PATCH] Fortran: reject NULL actual argument without explicit interface [PR107576] gcc/fortran/ChangeLog: PR fortran/107576 * interface.cc (gfc_procedure_use): Reject NULL as actual argument when there is no explicit procedure interface. gcc/testsuite/ChangeLog: PR fortran/107576 * gfortran.dg/null_actual_3.f90: New test. --- gcc/fortran/interface.cc | 8 ++++++++ gcc/testsuite/gfortran.dg/null_actual_3.f90 | 18 ++++++++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/null_actual_3.f90 diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc index 616ae2b1197..73799c175b7 100644 --- a/gcc/fortran/interface.cc +++ b/gcc/fortran/interface.cc @@ -4162,6 +4162,14 @@ gfc_procedure_use (gfc_symbol *sym, gfc_actual_arglist **ap, locus *where) return false; } + if (a->expr && a->expr->expr_type == EXPR_NULL) + { + gfc_error ("Passing intrinsic NULL as actual argument at %L " + "requires an explicit interface", &a->expr->where); + a->expr->error = 1; + return false; + } + /* TS 29113, C407b. */ if (a->expr && a->expr->expr_type == EXPR_VARIABLE && symbol_rank (a->expr->symtree->n.sym) == -1) diff --git a/gcc/testsuite/gfortran.dg/null_actual_3.f90 b/gcc/testsuite/gfortran.dg/null_actual_3.f90 new file mode 100644 index 00000000000..ea49f9630c9 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/null_actual_3.f90 @@ -0,0 +1,18 @@ +! { dg-do compile } +! { dg-options "-fallow-argument-mismatch -w" } +! PR fortran/107576 +! Contributed by G.Steinmetz + +program p + implicit none + interface + subroutine r(y) + integer, pointer :: y(:) + end subroutine r + end interface + integer, pointer :: z(:) => null() + call r(z) + call s(z) + call r(null(z)) + call s(null(z)) ! { dg-error "requires an explicit interface" } +end -- 2.35.3