From patchwork Sat May 28 20:25:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 54483 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C7B1385737E for ; Sat, 28 May 2022 20:26:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C7B1385737E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1653769561; bh=jJSNJBSXRVXuw+ysdkNVm1mrEYU6OSktqahM6DF7lCg=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=TtJQ87XAZcKefhlku1lgoSnt7tjoJCBSr7M2qRyhXQyvd14//G16cJX4xrNTbm/mm FF2TaTmRtMQiEFOMjEYUFoSR4Tl3TL6acaCuSZAfPbOWvW0zWLAH9YFn1hX64zEBux vEnGqh3nm1qLF5gLJsR2w9Y/53OqAQJHBIiSYB98= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id A8C29385737E; Sat, 28 May 2022 20:25:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8C29385737E X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [79.251.4.125] ([79.251.4.125]) by web-mail.gmx.net (3c-app-gmx-bs44.server.lan [172.19.170.96]) (via HTTP); Sat, 28 May 2022 22:25:11 +0200 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH] PR fortran/91300 - runtime error message with allocate and errmsg= Date: Sat, 28 May 2022 22:25:11 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:M8YkAEFx2UReeAWCilkPBZsfRnZ8kfu7YP8Hcjamox+DwfkTHPPc30+88mMzH6H9Nb7kY y6rFwemnEWkOzZ5d/8uyE2kEzHX9//0xWiOR0COZ5JecDjNyvOzTOtKSrlpod2lrQhwy1781ZGaG /DJdxt7+DEbWeVWOSgJunVAnVxd0yx8h7tFEyF3ofPO+dpL2Bt3kouoZZ7aEG+ceXi/+K1D4fXlb KYTHE+sRiOHAvF+vFvMwphFOlzoI8vVkmOLnpyRAaexZTCascabmzrdDGkQZbELYqmjrWl3FyQhD vs= X-UI-Out-Filterresults: notjunk:1;V03:K0:7jZIEGSA4gg=:1sjANcY36SDQKuQXSorqVZ mwdWMxkOdqdiPtVVQI+VmZkFpfFmGYr0G3VB2h/UD1dCuq/8UU17PjtqeSOxzoqzbUmuLZH6h 6tLmiPnhU0NyjLLVIhXXR5u6WkdQpMqlWkC5YvXM4YQ8CvSKniDdOsjs6JwX6dme8jDiPXLVU V8453vV5OhL8BdEmTNaYlrP9vLuO9+WBHNsSMLk6n13Pwuho60Ctk7tcOP4fup4CK60Y1URnl uEG/LSMy0VjiOvk3Hl1GftJJ7ncSdf0p7FCR/iiK6TGUllnBDP8ZLgn6/ZTdzF2fL2w8+Xsxw YwO4PVipYNh4prf3yWiJ8fU8UCyf3RLxrSCgW4CzWxSp3jN51uZlTWMKXER1sXq3VFG3MKtys KK58k3FG6va/SumggdHfzQsx+pYdYB7hr5G5zi81AOH5CCr4/h2NbZrv5YWZIzqgi+FxM+82J UwWlTTxBW9PsgLC8qvqI9DfkDkn9L+92RFvuUVKW65kULRiIwePukZGfq1lGgUG3EDMPvpPjZ ik2uZwMPLS8JKE1YQph/h+yxcnVBU39RVxKV4pUWYNR1GvooMZK6gxyFTsJ3zfYdU/ZtR3z6M a5EGc6GFKk1ShHHreYmjqA8KRtOtAQvecbcUH/m+0z1O4/ynd9/yYVTm9p5BEkowtpCqRtnsA HW5W0XHNQDnqOyuDyQxOFPcObXW+MLWbOlLevEbnhz5N+jGjxwRUaiIOU5w3cKAvLhQQ1J9kO Pk3G3nP7Nn+YVwbkKoJH1P/3cFAf6fZLOia11cUxaTgi0SmbWXqzm8TpfVerTCrrzec7RRrY2 1sQyxaH X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Dear Fortranners, the PR rightfully complained that we did not differentiate errors on ALLOCATE(...,stat=,errmsg=) for failures from allocation of already allocated objects or insufficient virtual memory. The attached patch introduces a new STAT value LIBERROR_NO_MEMORY that is returned for insufficient virtual memory, and a corresponding (simple and invariant) ERRMSG: "Insufficient virtual memory". (In the PR Janne mentions checking for errno, but since the standard malloc(3) only mentions ENOMEM as possible error value, and the user may replace malloc by a special library, I believe that won't be easy to handle in a general way.) Most compilers I tried (Intel/NAG/Crayftn) behave similarly, except for Nvidia/Flang, which try to return the size of the allocation in the error message. I am not sure that this is worth the effort. First, ERRMSG is very compiler-dependent anyway and thus not really portable. If a user wants to know what the size of the failed allocation is and really wants to recover, he/she should find that out himself. Second, I think that the more important change is the introduction of a STAT value that allows the distinction between the different causes of failure. The testcase should be able to handle 32 and 64 bit systems. At least that's what I think. Regtested on x86_64-pc-linux-gnu. OK for mainline? Suggestions? Thanks, Harald From 19ccd22ee9359bd14b32a95bd9efcaead3593b2f Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Sat, 28 May 2022 22:02:20 +0200 Subject: [PATCH] Fortran: improve runtime error message with ALLOCATE and ERRMSG= ALLOCATE: generate different STAT,ERRMSG results for failures from allocation of already allocated objects or insufficient virtual memory. gcc/fortran/ChangeLog: PR fortran/91300 * libgfortran.h: Define new error code LIBERROR_NO_MEMORY. * trans-stmt.cc (gfc_trans_allocate): Generate code for setting ERRMSG depending on result of STAT result of ALLOCATE. * trans.cc (gfc_allocate_using_malloc): Use STAT value of LIBERROR_NO_MEMORY in case of failed malloc. gcc/testsuite/ChangeLog: PR fortran/91300 * gfortran.dg/allocate_alloc_opt_15.f90: New test. --- gcc/fortran/libgfortran.h | 1 + gcc/fortran/trans-stmt.cc | 33 +++++++++++++-- gcc/fortran/trans.cc | 4 +- .../gfortran.dg/allocate_alloc_opt_15.f90 | 40 +++++++++++++++++++ 4 files changed, 73 insertions(+), 5 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/allocate_alloc_opt_15.f90 diff --git a/gcc/fortran/libgfortran.h b/gcc/fortran/libgfortran.h index 064795eb469..4328447be04 100644 --- a/gcc/fortran/libgfortran.h +++ b/gcc/fortran/libgfortran.h @@ -133,6 +133,7 @@ typedef enum LIBERROR_CORRUPT_FILE, LIBERROR_INQUIRE_INTERNAL_UNIT, /* Must be different from STAT_STOPPED_IMAGE. */ LIBERROR_BAD_WAIT_ID, + LIBERROR_NO_MEMORY, LIBERROR_LAST /* Not a real error, the last error # + 1. */ } libgfortran_error_codes; diff --git a/gcc/fortran/trans-stmt.cc b/gcc/fortran/trans-stmt.cc index 79096816c6e..fd6d294147e 100644 --- a/gcc/fortran/trans-stmt.cc +++ b/gcc/fortran/trans-stmt.cc @@ -7130,7 +7130,8 @@ gfc_trans_allocate (gfc_code * code) if (code->expr1 && code->expr2) { const char *msg = "Attempt to allocate an allocated object"; - tree slen, dlen, errmsg_str; + const char *oommsg = "Insufficient virtual memory"; + tree slen, dlen, errmsg_str, oom_str, oom_loc; stmtblock_t errmsg_block; gfc_init_block (&errmsg_block); @@ -7151,8 +7152,34 @@ gfc_trans_allocate (gfc_code * code) gfc_default_character_kind); dlen = gfc_finish_block (&errmsg_block); - tmp = fold_build2_loc (input_location, NE_EXPR, logical_type_node, - stat, build_int_cst (TREE_TYPE (stat), 0)); + tmp = fold_build2_loc (input_location, EQ_EXPR, logical_type_node, + stat, build_int_cst (TREE_TYPE (stat), + LIBERROR_ALLOCATION)); + + tmp = build3_v (COND_EXPR, tmp, + dlen, build_empty_stmt (input_location)); + + gfc_add_expr_to_block (&block, tmp); + + oom_str = gfc_create_var (pchar_type_node, "OOMMSG"); + oom_loc = gfc_build_localized_cstring_const (oommsg); + gfc_add_modify (&errmsg_block, oom_str, + gfc_build_addr_expr (pchar_type_node, oom_loc)); + + slen = build_int_cst (gfc_charlen_type_node, strlen (oommsg)); + dlen = gfc_get_expr_charlen (code->expr2); + slen = fold_build2_loc (input_location, MIN_EXPR, + TREE_TYPE (slen), dlen, slen); + + gfc_trans_string_copy (&errmsg_block, dlen, errmsg, + code->expr2->ts.kind, + slen, oom_str, + gfc_default_character_kind); + dlen = gfc_finish_block (&errmsg_block); + + tmp = fold_build2_loc (input_location, EQ_EXPR, logical_type_node, + stat, build_int_cst (TREE_TYPE (stat), + LIBERROR_NO_MEMORY)); tmp = build3_v (COND_EXPR, tmp, dlen, build_empty_stmt (input_location)); diff --git a/gcc/fortran/trans.cc b/gcc/fortran/trans.cc index f0a5dfb50fc..912a206f2ed 100644 --- a/gcc/fortran/trans.cc +++ b/gcc/fortran/trans.cc @@ -772,7 +772,7 @@ gfc_call_malloc (stmtblock_t * block, tree type, tree size) if (newmem == NULL) { if (stat) - *stat = LIBERROR_ALLOCATION; + *stat = LIBERROR_NO_MEMORY; else runtime_error ("Allocation would exceed memory limit"); } @@ -807,7 +807,7 @@ gfc_allocate_using_malloc (stmtblock_t * block, tree pointer, if (status != NULL_TREE) { tmp = fold_build2_loc (input_location, MODIFY_EXPR, status_type, status, - build_int_cst (status_type, LIBERROR_ALLOCATION)); + build_int_cst (status_type, LIBERROR_NO_MEMORY)); gfc_add_expr_to_block (&on_error, tmp); } else diff --git a/gcc/testsuite/gfortran.dg/allocate_alloc_opt_15.f90 b/gcc/testsuite/gfortran.dg/allocate_alloc_opt_15.f90 new file mode 100644 index 00000000000..04f7bf11970 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/allocate_alloc_opt_15.f90 @@ -0,0 +1,40 @@ +! { dg-do run } +! PR fortran/91300 - runtime error message with allocate and errmsg= +! Contributed by zed.three + +program bigarray_prog + use, intrinsic :: iso_c_binding, only: C_INTPTR_T + implicit none + real, dimension(:), allocatable :: array, bigarray + integer :: stat1, stat2 + character(len=100) :: errmsg1, errmsg2 + integer(8), parameter :: n1 = huge (1) / 3 ! request more than 2GB + integer(8), parameter :: n2 = huge (1_C_INTPTR_T) / 4 ! "safe" for 64bit + integer(8), parameter :: bignumber = max (n1, n2) + + stat1 = -1 + errmsg1 = "" + allocate (array(1), stat=stat1, errmsg=errmsg1) + if (stat1 /= 0) stop 1 + if (errmsg1 /= "") stop 1 + + ! Obtain stat,errmsg for attempt to allocate an allocated object + allocate (array(1), stat=stat1, errmsg=errmsg1) + if (stat1 == 0) stop 2 + if (errmsg1 == "") stop 2 + + stat2 = -1 + errmsg2 = "" + ! Try to allocate very large object + allocate (bigarray(bignumber), stat=stat2, errmsg=errmsg2) + if (stat2 /= 0) then + print *, "stat =", stat1 + print *, "errmsg: ", trim (errmsg1) + print *, "stat =", stat2 + print *, "errmsg: ", trim (errmsg2) + ! Ensure different results for stat, errmsg variables + if (stat2 == stat1 ) stop 3 + if (errmsg2 == "" .or. errmsg2 == errmsg1) stop 4 + end if + +end program bigarray_prog -- 2.35.3