From patchwork Thu Nov 25 12:35:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 48129 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE0B33858437 for ; Thu, 25 Nov 2021 12:36:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE0B33858437 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1637843810; bh=ha3IJH6rFVaeNxaWZjxr8Zd0Jvpv3Nic8ydLdbt6WeE=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=eooltF9mm53AaVdNGZ63VyuRyxDnGXx2WBgMOwhGf9Gyc5KCCgoaV7U1qROUS++2c 44GlhMwxNdGHHyk3QIm9VAeRkLMzicMOSuM2Zy9qSvS6LogWPg9jgQ0XQvYThrqdzD px/raDuwZnczec9Fgd2Vo/CFiw8i6YaFHUM4B+bE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 1BFDA3858410 for ; Thu, 25 Nov 2021 12:35:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BFDA3858410 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 532A01FD3E for ; Thu, 25 Nov 2021 12:35:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F8D813B81 for ; Thu, 25 Nov 2021 12:35:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0mGDDiGDn2EfEAAAMHmgww (envelope-from ) for ; Thu, 25 Nov 2021 12:35:45 +0000 Date: Thu, 25 Nov 2021 13:35:44 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Continue RTL verifying in rtl_verify_fallthru Message-ID: MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" One case used fatal_insn which does not return which isn't intended as can be seen by the following erro = 1. The following change refactors this to inline the relevant parts of fatal_insn instead and continue validating the RTL IL. Bootstrapped and tested on x86_64-unknown-linux-gnu, will push. 2021-11-25 Richard Biener * cfgrtl.c (rtl_verify_fallthru): Do not stop verifying with fatal_insn. (skip_insns_after_block): Remove unreachable break and continue. --- gcc/cfgrtl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c index e3a724bddb4..c7ba9006b4e 100644 --- a/gcc/cfgrtl.c +++ b/gcc/cfgrtl.c @@ -3001,7 +3001,8 @@ rtl_verify_fallthru (void) { error ("verify_flow_info: Incorrect fallthru %i->%i", e->src->index, e->dest->index); - fatal_insn ("wrong insn in the fallthru edge", insn); + error ("wrong insn in the fallthru edge"); + debug_rtx (insn); err = 1; } } @@ -3540,10 +3541,8 @@ skip_insns_after_block (basic_block bb) { case NOTE_INSN_BLOCK_END: gcc_unreachable (); - continue; default: continue; - break; } break;