From patchwork Tue Nov 30 08:16:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 48270 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 674C83858421 for ; Tue, 30 Nov 2021 08:16:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 674C83858421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1638260215; bh=JjalhEsO26frOjsYKrqN3MsWWa5UVy2Q7f10R5NSnf0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=o65jWISbx4PWejr85ii0PADRyvTFXxyzIdU4VeG330Pqwtkmzc627k3V1M/sl6o2S YjyDVykVkWxTc2I++W7bcsMW5Wgv0rpHQ37ch+9G/8JS+EUWpZ6rb6NLsUlvFEqWt3 uGVVCgHsHi6zZeNa/yzjINwENRlEtlGq/NnTh5zE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 0663B3858C2C for ; Tue, 30 Nov 2021 08:16:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0663B3858C2C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D6ED81FD2F for ; Tue, 30 Nov 2021 08:16:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C17AC13C56 for ; Tue, 30 Nov 2021 08:16:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0+X1LdjdpWE7cwAAMHmgww (envelope-from ) for ; Tue, 30 Nov 2021 08:16:24 +0000 Date: Tue, 30 Nov 2021 09:16:24 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/103485 - fix conversion kind for vectors Message-ID: MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This makes sure to use a VIEW_CONVERT_EXPR for converting vector signedness in the -((int)x >> (prec - 1)) to (unsigned)x >> (prec - 1) simplification. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-11-30 Richard Biener PR middle-end/103485 * match.pd (-((int)x >> (prec - 1)) to (unsigned)x >> (prec - 1)): Use VIEW_CONVERT_EXPR for vectors. * gcc.dg/pr103485.c: New testcase. --- gcc/match.pd | 4 +++- gcc/testsuite/gcc.dg/pr103485.c | 10 ++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr103485.c diff --git a/gcc/match.pd b/gcc/match.pd index e14f97ee1cd..d467a1c4e45 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -1611,7 +1611,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (with { tree stype = TREE_TYPE (@0); tree ntype = TYPE_UNSIGNED (stype) ? signed_type_for (stype) : unsigned_type_for (stype); } - (convert (rshift:ntype (convert:ntype @0) @1))))) + (if (VECTOR_TYPE_P (type)) + (view_convert (rshift (view_convert:ntype @0) @1)) + (convert (rshift (convert:ntype @0) @1)))))) /* Try to fold (type) X op CST -> (type) (X op ((type-x) CST)) when profitable. diff --git a/gcc/testsuite/gcc.dg/pr103485.c b/gcc/testsuite/gcc.dg/pr103485.c new file mode 100644 index 00000000000..1afa9286924 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr103485.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ + +int foo_v256u128_0; +unsigned __attribute__((__vector_size__ (sizeof(unsigned) * 8))) foo_v256u8_0; + +void +foo (void) +{ + foo_v256u8_0 -= (foo_v256u8_0 >> sizeof (foo_v256u8_0) - 1) + foo_v256u128_0; +}