From patchwork Fri Jul 8 12:10:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamar Christina X-Patchwork-Id: 55887 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C96F13850232 for ; Fri, 8 Jul 2022 12:11:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C96F13850232 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657282272; bh=VsO8NBJCkB3x/hAtOI5Ul+fE2k3ShmMmR8W5xi8QIW4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=W9FyR5TgSruXvOMd4J3Sgvo1/Zqn6+DN7mcyc3UCGoKBNdNifIJoN1Z/lfE7lJZ9s kzKzDosZ1g4/hYmypbW+zlcxIUCtKCAwmcd9kSa0DeInVmZArhVfqR1wzHvieYSycB q1pDjJhz1ZKl4Rng5ICPGM8vtlqd2DzQWGUzpxQs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2078.outbound.protection.outlook.com [40.107.22.78]) by sourceware.org (Postfix) with ESMTPS id B1B0C385843E for ; Fri, 8 Jul 2022 12:10:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1B0C385843E ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QTsozyWySJSQj4dki3+iVq5IdiYpe1+74AVhlOAKkg1FphdQRyzwELBoE/mCe4+gCjirmrN88PNtvkLNC5VYRlWFWR2LXb78Fv9ANBS1FAOv92YaACLacUoyhHvdYrVhjmdotAPnobi6fRCyps+yGakxadggbiVe/ovjWG7vnaWS0aCJZZrwIIXsQhZKbnxKOhSpIKPRj4fkD+Y1R6N88bGHS8Ae1pia9NCexFrxyAxUT6ArVjUSeErqQZb787wjTa7yWZzXcLht6evpyStaDoJ8POKSjXEIprjK5UYtev4PZQhrxViqVwVtxPXAtOLcu459zuTkHzNpcKAKsg9O9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VsO8NBJCkB3x/hAtOI5Ul+fE2k3ShmMmR8W5xi8QIW4=; b=hPKqTWhlk6V5pAmcD1o8BAOshD4GfXL3GygGpK6IGDl36lfhCR+rgEGkitan1ic3ta+ibHDoIpNV373u92NAdSY/Eyze80dqJvTkZH+/x4O9NtmVFGym+5ILI0KfqpNgjJjfjfPtx0seoCe0PChIavoKBD3qJzIlZsukNYh8dauXXlR/6T8+h+ee5WXuAtXdh5UXRa0yqiOlhZ4LVhaNmRyc1Ugn3y+P/R3RdRpr+Fy6q9etHvN8ubJlLw3jrrVQzQ1aaxIIlTsN47R5goYU8y2PkbJ9aTn1GxX8Tp/wjPvUldfDNbpU+mWL1DXGWgpAJ+oLFLHXFzYgDJ+OKKs+Jg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::9) by VI1PR08MB3022.eurprd08.prod.outlook.com (2603:10a6:803:41::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Fri, 8 Jul 2022 12:10:35 +0000 Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1e:cafe::19) by FR0P281CA0085.outlook.office365.com (2603:10a6:d10:1e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.6 via Frontend Transport; Fri, 8 Jul 2022 12:10:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 12:10:34 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Fri, 08 Jul 2022 12:10:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41f475b1eb0fc659 X-CR-MTA-TID: 64aa7808 Received: from 0a485471519a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2C57060C-C682-4516-B8EF-42E61D174F3B.1; Fri, 08 Jul 2022 12:10:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0a485471519a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 12:10:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZBSgYTocrZwz58bexI1lvXrX1LrsEL1lFZkK/hTCtRRDMvk2JecSZavkPxV8SulElh0LJ6SYRpgJmJZrUZyQb2kgfSU9Kgvlgt064bW32+3RHOKn1njD4KlOqX9JDdi95jiDDJoCCIjj1XyOZ4907BecG6KkAV0nEkI2+yu+1zn4b9x/HI/Y7ZrRp1Uwl5e/VoPqQ4kMcqO+AVt82o+QDqzDxhLBtja1FeJaAraLTf4g4N5MSZWasHxjHzayGEhpZu15gNuyGf9f5GPyES+OvmsldnDDdTmGn8XzvZDRROz3PX2itSWbLKnpmtFMQfuve/ae2POgSGTN2+++edOUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VsO8NBJCkB3x/hAtOI5Ul+fE2k3ShmMmR8W5xi8QIW4=; b=JA2Naunb8ibh/ex0LOoKpv+29j5mmfrCMlFkCLlrnebG2G7IYYl7fZI0Lnr8PelMbV3HCUvC7+bfOkoHn+oOQ7FDWk4CeyeHQhODp2nVAf9TRpUIk8S8fsMbEM0KtmoY9GmUAbkRtVQQ+ek6kf47nOsm2XAKP3clnumKZnAuvBFKJ7B946BATR0aMmFVux8iERbFCKW5wj4sLra5x+yMpUN7+D4QRim/+ZYXCS/hncQ0QjwCSA4mLmXaoq+6jbqqVz8bPNWecPLD9X9i0ObLsTbBoWOQSChI5Y5q2bPV8Gub1sBU9pZBscRV/lMSzYXn04/OcE86HOzQVkrSRIqS1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by AM8PR08MB5764.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 12:10:24 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::54e5:594b:e5fd:a9b4]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::54e5:594b:e5fd:a9b4%9]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 12:10:24 +0000 Date: Fri, 8 Jul 2022 13:10:19 +0100 To: gcc-patches@gcc.gnu.org Subject: [PATCH][s390]: Fix the usage of store_bit_field in the backend. Message-ID: Content-Disposition: inline X-ClientProxiedBy: LO2P265CA0463.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::19) To VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 78b46c62-3eb2-43f1-88b1-08da60dadc77 X-MS-TrafficTypeDiagnostic: AM8PR08MB5764:EE_|VE1EUR03FT051:EE_|VI1PR08MB3022:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C+gU1YJuHzC8J/ShTqjaqkR+okW459fS8xuYAfdHchCdw8GxyQOgO6voK2+TZPST7QAoNy+16WpUsTN7jbtErBjb7d7O7n+TUCmLKiA2kn+Q/gYvuMz+Lo2yTiMxDDKQD6CprQWScssbATLnAney1IGj373oWcw/k7vaCkhONw+JANzdiVp6vY4nE6eKY6E5yakNJg2a/ttbj1f2mLL/ak8Vqr8Cq6yJWF0wMlRn1pubt0LPtnrlKha1wwfx89xw+eY1hPXV+BJ/Wj9O+DmzUSToKsYaeLaQpXKECZwycpH4uGD+dvUKXfQuD6Oh+ova+rzFo6NYBOhvA4R20lHXuRhwIrUwLu4M849WivpWMkL1U1wG/lwZn1GiYmBovDQkjavVJXZ9/YtQI3BPV8choqD0UDc9mvhqUo6Jn2V9IH9m9ugyrFKvSWORcmY2ldT3AYpx2eZg0BTXtfbwKKqGux8mQ8J6syG+0KRxOb/NKRlXycxyiMT+NGfbxiZnE3QA8NIRN4NGZA1OFYPMLnTOArTUGTiLfyJ65kYR7pFxcNJ3vmRSoNCI/I0t5/dfjq9VPcONvZby0fW2EPb4hPiifbn89jFXRlKvW8y0mtLXl55yH2LvNReGQYzZtDyHDef90B/2J56SN9kpDjVbbbYA+ngNbKZTY9iswoBwIVB1oM0p7l3GyVCkAWKbdbv+jtTXHkYlkA5GiCVmqKUlUGOhfUZiKFF30kqo4VajeTddnFumEo4+2gXyNLQ26ovK+x5JbHjITnQljCYs6IXOO/bxtxY0ywH3wuLh6KpfZpwFAq4ubj1+fRYaiw+I/AmlEAKxC9Xmz5XUS6Xun7o7egJsYA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5325.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(316002)(66556008)(66476007)(33964004)(6506007)(4326008)(38100700002)(66946007)(5660300002)(8936002)(4743002)(86362001)(235185007)(6512007)(8676002)(26005)(478600001)(2616005)(83380400001)(6916009)(41300700001)(6666004)(6486002)(44144004)(2906002)(36756003)(186003)(44832011)(4216001)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5764 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d36a8b7b-d11b-428a-ae89-08da60dad61d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ObA9EMDzS2SGOgCa8O2b0vpWLzNici5zeknk2SS5EpkVwFBV/zmImvjyyp9QfT1mfAN7t2GIfaGOT+PwyTrjtYDFnr5pFRJZzP+PxJakjEJ/ALqfD4CxHlPqLuXFIV2PdloKI2hMhv+f4XdJFQ2deUzSGp7AEKedrK7LRDvyii9zIooUNsOswBb1aCyrE3bx6FJNBK83iXPZEM90DXngl1wuJFZ3paajJ13QObmlSNa9wzSkKfuaUydUuYVHerxst7qzPi84jyj5IcOSn7OvpSzl41NGRIfW001l7yONXTjEWs9SPjOlUen9u727lXGJ1JUBn6cDhBKp268BmV4Ej0IhG3Dt7ORnW99ru+GWxRYnu1GMhz6i4ydrOW4p8LCLpU6j0xOK75Kguy5abv11QKB1PFtNkk/zHwapouO8JE3teSzGBY+4oFNvmZnw+uJTOy78lhmNh5wVSj0pr7nYfxeoOVrHSSQqRn0KvuufoTnDYrootDhziWAybxIMcgxgTqKkU2jprtnwJ+fr2Uq0n5NypA7wRBpL4fR7UmPJvmoxrb61PZowNUM3NezDQ3Jr8bbT5jjrJ55KHQqS0d06F3LGx4zhXdaKcw8w6/plX8ygT1nnKqsKKFabH8rFMbHyGcMlkD6IQvPPBoXvw88BHwJGkfLBzgACKYg+RJ9PlufoY0dqdRdaUbvgQZjFHYEoC3uzXW2qxvn/dVnYmsFDi6t17oIvTAxErHnVzi6HeZpYBL3J8Uma58Vo0zx3NayLnq3ipVP1A8JMRBmPnS9sKRapMM7gjATj/xvdJQcGttu+YCKjf9e6i1gog5x1iyj8rX3lPxmueGFDMGYZp5EWUwYEj8idkJ+gOv4t9otqQ6xxYkJstf3Bd8nwHszDgd7Y X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966006)(36840700001)(40470700004)(40480700001)(36756003)(86362001)(36860700001)(83380400001)(186003)(40460700003)(47076005)(2616005)(82310400005)(2906002)(336012)(316002)(6916009)(6512007)(6666004)(44144004)(235185007)(26005)(44832011)(4743002)(5660300002)(81166007)(8676002)(4326008)(478600001)(70586007)(6486002)(6506007)(70206006)(41300700001)(33964004)(356005)(82740400003)(8936002)(4216001)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 12:10:34.3196 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78b46c62-3eb2-43f1-88b1-08da60dadc77 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3022 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tamar Christina via Gcc-patches From: Tamar Christina Reply-To: Tamar Christina Cc: nd@arm.com, uweigand@de.ibm.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi All, I seem to have broken the s390 bootstrap because I added a new parameter to the store_bit_field function to indicate whether the value the field of is being set is currently undefined. If it's undefined we use a subreg instead. In this case the value of false restores the old behavior. Ok for master? Thanks, Tamar gcc/ChangeLog: * config/s390/s390.cc (s390_expand_atomic): Pass false to store_bit_field to indicate that the value is not undefined. --- inline copy of patch -- diff --git a/gcc/config/s390/s390.cc b/gcc/config/s390/s390.cc index 444b1ec20d768d829ab19a41f114a91119335e00..5aaf76a94908c4d8f09aca5ac64ef3a418615b9e 100644 --- diff --git a/gcc/config/s390/s390.cc b/gcc/config/s390/s390.cc index 444b1ec20d768d829ab19a41f114a91119335e00..5aaf76a94908c4d8f09aca5ac64ef3a418615b9e 100644 --- a/gcc/config/s390/s390.cc +++ b/gcc/config/s390/s390.cc @@ -7468,7 +7468,7 @@ s390_expand_atomic (machine_mode mode, enum rtx_code code, case SET: if (ac.aligned && MEM_P (val)) store_bit_field (new_rtx, GET_MODE_BITSIZE (mode), 0, - 0, 0, SImode, val, false); + 0, 0, SImode, val, false, false); else { new_rtx = expand_simple_binop (SImode, AND, new_rtx, ac.modemaski, --- a/gcc/config/s390/s390.cc +++ b/gcc/config/s390/s390.cc @@ -7468,7 +7468,7 @@ s390_expand_atomic (machine_mode mode, enum rtx_code code, case SET: if (ac.aligned && MEM_P (val)) store_bit_field (new_rtx, GET_MODE_BITSIZE (mode), 0, - 0, 0, SImode, val, false); + 0, 0, SImode, val, false, false); else { new_rtx = expand_simple_binop (SImode, AND, new_rtx, ac.modemaski,