From patchwork Fri Dec 2 09:34:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 61352 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2C6638582B7 for ; Fri, 2 Dec 2022 09:35:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2C6638582B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1669973708; bh=Dv8YhH3VKFJiE/uGI6JGfXw85Hn4U2ECmMX771aCvjo=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=FTdvue19nnCIPilZPotBdgeayQYoodKJtgX6y2xH5ZjqFaYIobBzGSAHibQopAXAz yUR1PGhya1rQ5cU67/f2S4ScUqp2jjIv34heaaRsiG13QLzdMd5AshQIepoARB7yI5 L6JJjQfz1NGdXEv/VaCIUHGu+bhAUIpyeizWhnk8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTPS id 115D1385840F for ; Fri, 2 Dec 2022 09:34:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 115D1385840F Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C47DE116B25; Fri, 2 Dec 2022 04:34:37 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EDBWG5F1Z6Fx; Fri, 2 Dec 2022 04:34:37 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 7BCC8116B12; Fri, 2 Dec 2022 04:34:37 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 2B29YUhG1291501 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 2 Dec 2022 06:34:30 -0300 To: gcc-patches@gcc.gnu.org Cc: Nick Clifton , Richard Earnshaw , Ramana Radhakrishnan , Kyrylo Tkachov , Rainer Orth , Mike Stump Subject: [PATCH] [arm] xfail fp-uint64-convert-double tests Organization: Free thinker, does not speak for AdaCore Date: Fri, 02 Dec 2022 06:34:30 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alexandre Oliva via Gcc-patches From: Alexandre Oliva Reply-To: Alexandre Oliva Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" The FP emulation on ARM doesn't take rounding modes into account. The tests require hard_float, but that only tests for calls when adding doubles. There are arm targets that support hardware adds, but that emulate conversions. Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf and arm-eabi. Ok to install? PS: I've pondered changing hard_float instead, but decided that could impact other tests that rely on its current behavior. Then I considered adding a variant of hard_float that tested for conversions, but thought that it was overkill. for gcc/testsuite/ChangeLog * gcc.dg/torture/fp-uint64-convert-double-1.c: Expect fail on arm-*-eabi*. * gcc.dg/torture/fp-uint64-convert-double-2.c: Likewise. --- .../gcc.dg/torture/fp-uint64-convert-double-1.c | 2 +- .../gcc.dg/torture/fp-uint64-convert-double-2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c index 0c7bf003e93ed..61cfa96374631 100644 --- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c +++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-1.c @@ -1,5 +1,5 @@ /* PR84407 */ -/* { dg-do run } */ +/* { dg-do run { xfail { arm-*-eabi* } } } */ /* { dg-require-effective-target fenv } */ /* { dg-require-effective-target hard_float } */ /* { dg-additional-options "-frounding-math -fexcess-precision=standard" } */ diff --git a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c index ac24b351a46d6..b32b28a329580 100644 --- a/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c +++ b/gcc/testsuite/gcc.dg/torture/fp-uint64-convert-double-2.c @@ -1,5 +1,5 @@ /* PR84407 */ -/* { dg-do run } */ +/* { dg-do run { xfail { arm-*-eabi* } } } */ /* { dg-require-effective-target fenv } */ /* { dg-require-effective-target hard_float } */ /* { dg-additional-options "-frounding-math" } */