From patchwork Wed Nov 10 12:50:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 47407 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C005A3857813 for ; Wed, 10 Nov 2021 12:53:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C005A3857813 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1636548818; bh=75f2pK/vKbR3+cl3AFKcai/cIaJ4Ak6/zkjFQk6BiRI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=BX3Uw6DXAXfFTiiEijvZ059HdlYF8SzTtB6ldTiAYUXYt90h5eVT912SbG3GsPgL4 I2dYtWlQL1R5GbOSu6HfbL6JA9zqf8QV5ikqZ8WpH91V8dAPDv7XevHKOYZn/BnWTC 40j6WFKAXvaW60u++hk7kvXfNJnIHh5n41V67CEk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 99C663857C77 for ; Wed, 10 Nov 2021 12:50:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99C663857C77 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 510EF101E for ; Wed, 10 Nov 2021 04:50:11 -0800 (PST) Received: from localhost (unknown [10.32.98.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC54A3F5A1 for ; Wed, 10 Nov 2021 04:50:10 -0800 (PST) To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [PATCH 4/4] Mark IFN_ADD/MUL_OVERFLOW as commutative Date: Wed, 10 Nov 2021 12:50:09 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Sandiford via Gcc-patches From: Richard Sandiford Reply-To: Richard Sandiford Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Mark IFN_ADD/MUL_OVERFLOW as commutative. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Richard gcc/ * internal-fn.c (first_commutative_operand): Handle IFN_ADD_OVERFLOW and IFN_MUL_OVERFLOW. gcc/testsuite/ * gcc.dg/add-mul-overflow-1.c: New test. --- gcc/internal-fn.c | 2 ++ gcc/testsuite/gcc.dg/add-mul-overflow-1.c | 28 +++++++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/add-mul-overflow-1.c diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c index b64555ada36..10f08182f7e 100644 --- a/gcc/internal-fn.c +++ b/gcc/internal-fn.c @@ -3867,6 +3867,8 @@ first_commutative_argument (internal_fn fn) case IFN_FMS: case IFN_FNMA: case IFN_FNMS: + case IFN_ADD_OVERFLOW: + case IFN_MUL_OVERFLOW: return 0; case IFN_COND_ADD: diff --git a/gcc/testsuite/gcc.dg/add-mul-overflow-1.c b/gcc/testsuite/gcc.dg/add-mul-overflow-1.c new file mode 100644 index 00000000000..b23cdddbb63 --- /dev/null +++ b/gcc/testsuite/gcc.dg/add-mul-overflow-1.c @@ -0,0 +1,28 @@ +/* { dg-options "-O -fdump-tree-optimized" } */ + +int res[4]; + +void +f1 (int x, int y) +{ + res[2] = __builtin_add_overflow (x, y, res + 0); + res[3] = __builtin_add_overflow (y, x, res + 1); +} + +void +f2 (int x, int y) +{ + res[2] = __builtin_sub_overflow (x, y, res + 0); + res[3] = __builtin_sub_overflow (y, x, res + 1); +} + +void +f3 (int x, int y) +{ + res[2] = __builtin_mul_overflow (x, y, res + 0); + res[3] = __builtin_mul_overflow (y, x, res + 1); +} + +/* { dg-final { scan-tree-dump-times {\.ADD_OVERFLOW} 1 "optimized" } } */ +/* { dg-final { scan-tree-dump-times {\.SUB_OVERFLOW} 2 "optimized" } } */ +/* { dg-final { scan-tree-dump-times {\.MUL_OVERFLOW} 1 "optimized" } } */