From patchwork Fri Nov 12 17:55:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 47555 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAA0D385842A for ; Fri, 12 Nov 2021 17:56:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BAA0D385842A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1636739779; bh=1yBFfuOJRTmSxeAFr+dD/MeFVkxEplumj+Epo62ZAHY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=oyx6LiUrlnKQAMMhtxrTTUtYnfH1z8j6Q6sXbNHqI3OE7sabfBkD8B9cpjDU2RIvK YMRdbYoO8zvMd1vrzMavfaGCxricNKEfQGQ5tnixFvh1efAuYfIGkwQp60+6beMIdU 652nGRCBQOOzrVPaySKC/HERHOuW3dz8PsujhDeY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id E3558385840B for ; Fri, 12 Nov 2021 17:55:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3558385840B Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0EB88D6E for ; Fri, 12 Nov 2021 09:55:49 -0800 (PST) Received: from localhost (unknown [10.32.98.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA28E3F718 for ; Fri, 12 Nov 2021 09:55:48 -0800 (PST) To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [PATCH] vect: Fix SVE mask_gather_load/store_store tests Date: Fri, 12 Nov 2021 17:55:47 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Sandiford via Gcc-patches From: Richard Sandiford Reply-To: Richard Sandiford Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" If-conversion now applies rewrite_to_defined_overflow to the address calculation in an IFN_MASK_LOAD. This means that we end up with: cast_base = (uintptr_t) base; uncast_sum = cast_base + offset; sum = (orig_type *) uncast_sum; If the target supports IFN_MASK_GATHER_LOAD with pointer-sized offsets for the given vectype, we wouldn't look through the sum cast and so would needlessly vectorise the uncast_sum addition. This showed up as several failures in gcc.target/aarch64/sve. Regstrapped on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Richard gcc/ * tree-vect-data-refs.c (vect_check_gather_scatter): Continue processing conversions if the current offset is a pointer. --- gcc/tree-vect-data-refs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-vect-data-refs.c b/gcc/tree-vect-data-refs.c index f1d7f01a9ce..888ad72f3a9 100644 --- a/gcc/tree-vect-data-refs.c +++ b/gcc/tree-vect-data-refs.c @@ -4139,6 +4139,7 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo, /* Don't include the conversion if the target is happy with the current offset type. */ if (use_ifn_p + && !POINTER_TYPE_P (TREE_TYPE (off)) && vect_gather_scatter_fn_p (loop_vinfo, DR_IS_READ (dr), masked_p, vectype, memory_type, TREE_TYPE (off), scale, &ifn,