From patchwork Wed Nov 24 14:06:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 48064 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2AB53857C59 for ; Wed, 24 Nov 2021 14:07:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2AB53857C59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1637762822; bh=7qGXwC/G2PtU2kFhqKB1B9we2PJfN1XoiokJbD1fDm4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PRUyy32K8GZbJZn6/HwM/a3Ueb2TCxCmAvhE8uILn7pK3gFJVU93NzXPoVFqj1ng3 BQbsItYhWLnNnWCuXHtkq8pqoqYWQD4Jj7lzSkTQ/1X0E7mBQao/2PRrCGZ/+aLYTU 5p4lBmZXFRPXtVfkFLG5fqswRVdXAntZqu0JA+5E= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7A47C3857C6B for ; Wed, 24 Nov 2021 14:06:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A47C3857C6B Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-51PIGSekP96endQbxJG_Zg-1; Wed, 24 Nov 2021 09:06:21 -0500 X-MC-Unique: 51PIGSekP96endQbxJG_Zg-1 Received: by mail-qk1-f200.google.com with SMTP id p18-20020a05620a057200b00467bc32b45aso2184948qkp.12 for ; Wed, 24 Nov 2021 06:06:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:from:subject:cc; bh=oWsOKZgdyoGAxgXkmpmsgBheHFqKLhDyQ0ecWFztfp4=; b=SFzXIDHdUdRyF4xcMrh96fYtwCIp8MlFZDO419X/K2O0kBr1gBYaNlYaRFGbgTQiXJ rnEJkS648WUXotASwgHkL2fyHkrQEc/9TQopMGTIgBHX/wPM2fgXxS1eiLoYLlq/RVBD 0fQ92NLdnXRBg+mw0uzoZg0FEJj89/34uaOefJiHqBZVsQROV9SVCALt7sk2sP1Z0mIH Chgg+MdTJaUWESn4V5iH+BhlC8aXTiTqxirEt9rNtiMAlfiwNbcXeeU4q1N7WECogA0o Hho4JfGmo60y7veLEoX25nnybMlB8z4tsXELkhaLK+Y3fHbohhNhhnTsWcBfJtQA8aGx uDzQ== X-Gm-Message-State: AOAM531yJccipUWIF9KdaRDLlJ4RZFQoKiSKdUkLWvWkej7E1ruyp7R+ 86u36Rjs0IGsomdNhrpzrwIN68fJ28DinCc3X3mkNRmAKY8kcZUe3E5OvbCKXd6ea/jibUV5zVB ADxqmOyVI/dYOmOaYxMa/4P8HMSowkZrnl+FnE9UwerT6LMEpzCGYsZCfp1jOQM0AFwoCyA== X-Received: by 2002:ac8:7fc2:: with SMTP id b2mr7900074qtk.114.1637762780885; Wed, 24 Nov 2021 06:06:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwIcIiy/0q1mAfaBp7oPnGmYgg3YNvPgB2WBKtteYTu4jm3I8PnRd0DyAs9UIA9frRX03wQA== X-Received: by 2002:ac8:7fc2:: with SMTP id b2mr7900043qtk.114.1637762780628; Wed, 24 Nov 2021 06:06:20 -0800 (PST) Received: from ?IPV6:2607:fea8:a262:5f00::38cf? ([2607:fea8:a262:5f00::38cf]) by smtp.gmail.com with ESMTPSA id d17sm7630246qtx.96.2021.11.24.06.06.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 06:06:19 -0800 (PST) Message-ID: Date: Wed, 24 Nov 2021 09:06:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 To: gcc-patches Subject: [COMMITTED] Range-on-edge trace tweak. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-CA X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew MacLeod via Gcc-patches From: Andrew MacLeod Reply-To: Andrew MacLeod Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" When working with the trace output, I noticed the columns were getting out of sync. When range_on_edge is called with a constant value, it use to not output a trace for that. When I added the unexecutable edge code, It possible to request a constant on an unexecutable edge  that now returns UNDEFINED.  The trace output prints the header, but returns for a constant before outputting the trailer and realigning the columns. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed as obvious. Andrew From a031bb7a585f789df2aed856a57646b8c45d0878 Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Fri, 19 Nov 2021 13:27:18 -0500 Subject: [PATCH 1/4] Range-on-edge trace tweak. Trace formatting gets out of sync when range on edge is called with a constant. * gimple-range.cc (gimple_ranger::range_on_edge): Call trailer when a constant is encountered to terminate the trace. --- gcc/gimple-range.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/gimple-range.cc b/gcc/gimple-range.cc index a2b68b2bc80..9ca568ce55d 100644 --- a/gcc/gimple-range.cc +++ b/gcc/gimple-range.cc @@ -216,7 +216,7 @@ gimple_ranger::range_on_edge (irange &r, edge e, tree name) bool res = true; if (!gimple_range_ssa_p (name)) - return get_tree_range (r, name, NULL); + res = get_tree_range (r, name, NULL); else { range_on_exit (r, e->src, name); @@ -230,7 +230,7 @@ gimple_ranger::range_on_edge (irange &r, edge e, tree name) if (idx) tracer.trailer (idx, "range_on_edge", res, name, r); - return true; + return res; } // fold_range wrapper for range_of_stmt to use as an internal client. -- 2.17.2