From patchwork Fri Apr 21 18:27:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 68146 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E322D3857038 for ; Fri, 21 Apr 2023 18:27:55 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 08DEB3858D20 for ; Fri, 21 Apr 2023 18:27:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08DEB3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ventanamicro.com Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-63f273b219eso258891b3a.1 for ; Fri, 21 Apr 2023 11:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1682101657; x=1684693657; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XBV8k8B/lA142ehKATe11Gee/gmLx5HUKFKoZPBIFbw=; b=KdvWcD36AXuN4e0+O3I38ap+uOTiBqVsYP34jwlTLzUl1B5v7RbB8872621d2AFHXY ooT3Sm5RNcIPxZbXjfuX28cpiOk8JRTrVKYU2bpZRxY3RIiKPIUVeWQu9sGXyvhTpzpd 11CoVSZcCuLGO0Yw4OKMPNQPUgEQXQOfcttw9XORLVviX7bRl9aEdANZQA+JQt2VxOzg neNw5cROor2UCMI3ru3unMl4Af8Qsp03tUNvmuvyCkMBQparqe2PvOC8FpBCTqQ1pAuh 9Bw75l3Xb6er7mlltvbbszB+tXYjZ1bdgKAHNNi8vhPoiLOyFzYBO33HbUDnzqzdfDWq uo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682101657; x=1684693657; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XBV8k8B/lA142ehKATe11Gee/gmLx5HUKFKoZPBIFbw=; b=Whwhi7UucBdY3GK3BYsBq5dxFsRBh5vAjrll6KqHfIYAkd3b64Hcz7zLrg2sFqN3kK KcYmacoiVynWoOrhl85DIfpEHUY2SVvLKNaXl7fGB0YdMdznWQlYDlPZJRecaFZFdjYL 9TUNPLl8h3d30yefM6F4UEYhFh1FoTC+VuXNYe2E/13zFhvqk9eUhP6TOkHoo6y1yA4M I0En+yvww4fFT7eScBmEuIVt1hrmYAXbRt3mlzAY18Gh6uyH4CN8KQyeGSvrecp6GSj7 Xsv8zYeh2PzSx90D2ikAYELQv/lgYu3rGvoB1op/2PgxPcXWcNWQe3FTWd1cthTXo/3a 6CLQ== X-Gm-Message-State: AAQBX9d2zvSUGWiEe2aStBRW5mVaitgq9uz0/C0sROOy2HM7kcEJjyc4 LwBpYvfBLoQ0QguBFQiffEJfX+iNbMwcVGyTEI0= X-Google-Smtp-Source: AKy350adEvJyUE9pYRNKP+ElG6ECwy82gvqogXk2GaiyODgFfFq6W8gjzzwWJCYhIn73oHJMLEvWEA== X-Received: by 2002:a05:6a00:230b:b0:63b:8778:99e4 with SMTP id h11-20020a056a00230b00b0063b877899e4mr8045990pfh.2.1682101657239; Fri, 21 Apr 2023 11:27:37 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id u20-20020aa78494000000b0062bada5db75sm3377654pfn.172.2023.04.21.11.27.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 11:27:36 -0700 (PDT) Message-ID: Date: Fri, 21 Apr 2023 12:27:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: "gcc-patches@gcc.gnu.org" From: Jeff Law Subject: [committed] [PR testsuite/109549] Adjust x86 testsuite for recent if-conversion cost checking X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This test expected if-conversion to happen for a sequence which appears to always cost more than a branchy sequence. This was exposed by a recent change to the if-converter to add checking in a path where it was missing. So I've just adjusted the test to assume it should never if-convert into cmov instructions. Committed to the trunk. There's a few of the embedded targets that are regressing in similar manners, so I'm not closing the PR yet. jeff commit f1f18198b069f461155191ecba41bc87bf5689dd Author: Jeff Law Date: Fri Apr 21 12:22:24 2023 -0600 Adjust x86 testsuite for recent if-conversion cost checking gcc/testsuite PR testsuite/109549 * gcc.target/i386/cmov6.c: No longer expect this test to generate 'cmov' instructions. diff --git a/gcc/testsuite/gcc.target/i386/cmov6.c b/gcc/testsuite/gcc.target/i386/cmov6.c index 535326e4c2a..5111c8a9099 100644 --- a/gcc/testsuite/gcc.target/i386/cmov6.c +++ b/gcc/testsuite/gcc.target/i386/cmov6.c @@ -1,6 +1,9 @@ /* { dg-do compile } */ /* { dg-options "-O2 -march=k8" } */ -/* { dg-final { scan-assembler "cmov\[^6\]" } } */ +/* if-converting this sequence would require two cmov + instructions and seems to always cost more independent + of the TUNE_ONE_IF_CONV setting. */ +/* { dg-final { scan-assembler-not "cmov\[^6\]" } } */ /* Verify that blocks are converted to conditional moves. */ extern int bar (int, int);