diff mbox series

libstdc++: drop bogus 'dg_do run' directive

Message ID f7c7c0f329ddf7397baf756dd9c6bf2f398fcadc.1722440629.git.sam@gentoo.org
State Committed
Commit f7221267238395ff66da962271fdcf7c7f9bb7dd
Headers
Series libstdc++: drop bogus 'dg_do run' directive |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm warning Patch is already merged

Commit Message

Sam James July 31, 2024, 3:43 p.m. UTC 
  We already have a valid 'dg-do run' (- vs _) directive, so drop the bogus
one.

libstdc++-v3/ChangeLog:
	* testsuite/28_regex/traits/char/translate.cc: Drop bogus 'dg_do run'.
---
OK? No regressions in the logs but it's a bit weird that it's got a proper
directive with a target specifier so I thought I'd check rather than doing
it as obvious.

 libstdc++-v3/testsuite/28_regex/traits/char/translate.cc | 1 -
 1 file changed, 1 deletion(-)

Comments

Jonathan Wakely July 31, 2024, 4:03 p.m. UTC | #1 
On Wed, 31 Jul 2024 at 16:45, Sam James <sam@gentoo.org> wrote:
>
> We already have a valid 'dg-do run' (- vs _) directive, so drop the bogus
> one.
>
> libstdc++-v3/ChangeLog:
>         * testsuite/28_regex/traits/char/translate.cc: Drop bogus 'dg_do run'.
> ---
> OK? No regressions in the logs but it's a bit weird that it's got a proper
> directive with a target specifier so I thought I'd check rather than doing
> it as obvious.

Definitely OK. Dejagnu will ignore it because it doesn't start with
dg- so it is useless.

Even if it was used, it would be wrong because std::regex can't be
used in C++98 so the c++11 effective target is needed.


>
>  libstdc++-v3/testsuite/28_regex/traits/char/translate.cc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc b/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
> index e2552e3cbf05..65119e67e25b 100644
> --- a/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
> +++ b/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
> @@ -1,4 +1,3 @@
> -// { dg_do run }
>  // { dg-do run { target c++11 } }
>  // { dg-timeout-factor 2 }
>
>
> --
> 2.45.2
>
Sam James July 31, 2024, 4:21 p.m. UTC | #2 
Jonathan Wakely <jwakely@redhat.com> writes:

> On Wed, 31 Jul 2024 at 16:45, Sam James <sam@gentoo.org> wrote:
>>
>> We already have a valid 'dg-do run' (- vs _) directive, so drop the bogus
>> one.
>>
>> libstdc++-v3/ChangeLog:
>>         * testsuite/28_regex/traits/char/translate.cc: Drop bogus 'dg_do run'.
>> ---
>> OK? No regressions in the logs but it's a bit weird that it's got a proper
>> directive with a target specifier so I thought I'd check rather than doing
>> it as obvious.
>
> Definitely OK. Dejagnu will ignore it because it doesn't start with
> dg- so it is useless.

Thank you! Will push shortly.

>
> Even if it was used, it would be wrong because std::regex can't be
> used in C++98 so the c++11 effective target is needed.

That's the missing piece I was looking for -- I just didn't want to be
dropping the bogus directive and covering up if something else was wrong
there.

> [...]

thanks,
sam
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc b/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
index e2552e3cbf05..65119e67e25b 100644
--- a/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
+++ b/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
@@ -1,4 +1,3 @@ 
-// { dg_do run }
 // { dg-do run { target c++11 } }
 // { dg-timeout-factor 2 }