From patchwork Mon Jan 6 14:51:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Uecker X-Patchwork-Id: 104183 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 822E03858C98 for ; Mon, 6 Jan 2025 14:53:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 822E03858C98 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=tugraz.at header.i=@tugraz.at header.a=rsa-sha256 header.s=mailrelay header.b=OE8Mv5VO X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mailrelay.tugraz.at (mailrelay.tugraz.at [129.27.2.202]) by sourceware.org (Postfix) with ESMTPS id 0E5503858D21 for ; Mon, 6 Jan 2025 14:52:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E5503858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=tugraz.at Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tugraz.at ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E5503858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.27.2.202 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736175120; cv=none; b=mvRIlU1+AOky1q8NTblsi/0exPkd0XnesbVCrRZWFpOMk66BZCFioiZNI7zeDFhWLKioRHjDcX2fiUE5lcssNVoNtbGS68RByZ/4Q9PpguO+SP3bku48CchOR0VCHGNZ6Q7eKz8jNm36mbvwssiI6F7YhyLnGLkl1aewdr3M+hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736175120; c=relaxed/simple; bh=tnnxffKT7i57Bjrf1L3rmvz5PDgDnFI5CBmn7l5GlH8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=B4OlOivQh9EbhWkD6YEv5FegJAtKQFe4cKBfJ7RBw46rpSlsD72aznbftNu4atXS2gcMs36y3bupj6jj8SUzxPEqaAYGjilGeLGKv5tXDpHl9RWcJQTt/QMAoyOhduGxf1dfq+alNmVnOuMQzOMhhrO2MEmppEn+JWk0uWRITh0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E5503858D21 Received: from vra-172-82.tugraz.at (vra-172-82.tugraz.at [129.27.172.82]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4YRcZw5WCyz3wlQ; Mon, 6 Jan 2025 15:51:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1736175113; bh=uIp0IOHBsc4nMBmnNgjgv9eFlnSk3ZY/jQDq0QYv6oY=; h=Subject:From:To:Cc:Date; b=OE8Mv5VOHG3pOPGBwwKUr2pR5qpNCZvT35BTsrbCdPQUZ78OyzVTgISl540PtsoLe dyh3YC0pTHlVLh1kzsnKC7ZeQuwXAeXpCHcoUOnLvuuHkEmu9m9OWUMIUJKuh6Wl0C Fz7CqJiHLbypPgcQpXIxJksgkaMVe7UH1KJAgtxI= Message-ID: Subject: [PATCH] c: Restore warning for incomplete structures declared in parameter list [PR117866] From: Martin Uecker To: gcc-patches@gcc.gnu.org Cc: "josmyers@redhat.com" , Sam James Date: Mon, 06 Jan 2025 15:51:52 +0100 User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-TUG-Backscatter-control: G/VXY7/6zeyuAY/PU2/0qw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Happy new year! Please consider the following patch. Bootstrapped and regression tested on x86_64. c: Restore warning for incomplete structures declared in parameter list [PR117866] In C23 mode the warning about declaring structures and union in parameter lists was removed, because it is possible to redeclare a compatible type elsewhere. This is not the case for incomplete types, so restore the warning for those types. PR c/117886 gcc/c/ChangeLog: * c-decl.cc (get_parm_info): Change condition for warning. gcc/testsuite/ChangeLog: * gcc.dg/pr117866.c: New test. * gcc.dg/struct-pr118007.c: Adapt. diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc index f60b2a54a17..56d13884182 100644 --- a/gcc/c/c-decl.cc +++ b/gcc/c/c-decl.cc @@ -8677,7 +8677,7 @@ get_parm_info (bool ellipsis, tree expr) if (b->id) { /* The %s will be one of 'struct', 'union', or 'enum'. */ - if (!flag_isoc23) + if (!flag_isoc23 || !COMPLETE_TYPE_P (decl)) warning_at (b->locus, 0, "%<%s %E%> declared inside parameter list" " will not be visible outside of this definition or" diff --git a/gcc/testsuite/gcc.dg/pr117866.c b/gcc/testsuite/gcc.dg/pr117866.c new file mode 100644 index 00000000000..3caf707791d --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr117866.c @@ -0,0 +1,5 @@ +/* { dg-do compile } */ +/* { dg-options "-std=c23" } */ + +void convert(struct fractpoint *pt); /* { dg-warning "declared inside parameter list" } */ + diff --git a/gcc/testsuite/gcc.dg/strub-pr118007.c b/gcc/testsuite/gcc.dg/strub-pr118007.c index 6c24cad6529..51f48245b3f 100644 --- a/gcc/testsuite/gcc.dg/strub-pr118007.c +++ b/gcc/testsuite/gcc.dg/strub-pr118007.c @@ -2,4 +2,4 @@ /* { dg-do compile } */ /* { dg-options "-fstrub=all -O2" } */ -void rb_ec_error_print(struct rb_execution_context_struct *volatile) {} +void rb_ec_error_print(struct rb_execution_context_struct *volatile) {} /* { dg-warning "declared inside parameter list" } */