From patchwork Wed May 25 20:30:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: will schmidt X-Patchwork-Id: 54390 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A7A3383064A for ; Wed, 25 May 2022 20:32:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A7A3383064A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1653510736; bh=nYqw+Rr8WDr5UA84UAr5IqYgFetftXNBuL7X0M0UBQk=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GFkO3oF5yImTU2jzteNkTZWUFwQ0vQnxbwApKXr8KvJcp/8jzWCmBxGvHySphPIZ1 TsDga/YPJOZH8aklRcOwiBYsjhYsiL16XAK6R6HDaQlSnofnGxw6fMNImV24DOkH1i qkxnJzMcKpwWFOcO3cUMRgwJ+0mom9zUAfgjId80= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 8E9C33830653 for ; Wed, 25 May 2022 20:30:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E9C33830653 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24PJjXqJ017896; Wed, 25 May 2022 20:30:58 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g9t6xsgv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 20:30:58 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24PK3uCe015534; Wed, 25 May 2022 20:30:57 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g9t6xsguy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 20:30:57 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24PKD5HD026975; Wed, 25 May 2022 20:30:56 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma03wdc.us.ibm.com with ESMTP id 3g93v90e9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 20:30:56 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24PKUtPr32047588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 May 2022 20:30:56 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D5CF0C6055; Wed, 25 May 2022 20:30:55 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53D27C605B; Wed, 25 May 2022 20:30:55 +0000 (GMT) Received: from lexx (unknown [9.160.34.81]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 25 May 2022 20:30:55 +0000 (GMT) Message-ID: Subject: [PATCH, rs6000] Clean up the option_mask defines (part 3) To: Segher Boessenkool , David Edelsohn Date: Wed, 25 May 2022 15:30:54 -0500 In-Reply-To: <6591013b62270c39c912f0c13c4cd12ffbaf75a2.camel@vnet.ibm.com> References: <6591013b62270c39c912f0c13c4cd12ffbaf75a2.camel@vnet.ibm.com> X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: RKXQhkqWM8GJJw5phO4Owf9gEWAKQPVN X-Proofpoint-ORIG-GUID: -2Z7eFUxQ_SFxpF8YU7C-DSkOgvIwElZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_05,2022-05-25_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=881 clxscore=1015 mlxscore=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205250095 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: will schmidt via Gcc-patches From: will schmidt Reply-To: will schmidt Cc: GCC Patches Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" [PATCH, rs6000] Clean up the option_mask defines (part 3) Hi, Per code review, the MASK_REGNAMES, OPTION_MASK_REGNAMES, MASK_PROTOTYPE, OPTION_MASK_PROTOTYPE options are not used elsewhere in the codebase. Thus it should be safe to remove them. This includes an update to a nearby comment to hint that most of the MASK_ options have now been replaced with their OPTION_MASK_ equivalents. Regtested OK on power10. OK for trunk? diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h index dcf632c1f1ad..fe77a343d2e1 100644 --- a/gcc/config/rs6000/rs6000.h +++ b/gcc/config/rs6000/rs6000.h @@ -503,12 +503,13 @@ extern int rs6000_vector_align[]; answers if the arguments are not in the normal range. */ #define TARGET_MINMAX (TARGET_HARD_FLOAT && TARGET_PPC_GFXOPT \ && (TARGET_P9_MINMAX || !flag_trapping_math)) /* In switching from using target_flags to using rs6000_isa_flags, the options - machinery creates OPTION_MASK_ instead of MASK_. For now map - OPTION_MASK_ back into MASK_. */ + machinery creates OPTION_MASK_ instead of MASK_. The MASK_ + options that have not yet been replaced by their OPTION_MASK_ + equivalents are defined here. */ #define MASK_STRICT_ALIGN OPTION_MASK_STRICT_ALIGN #ifndef IN_LIBGCC2 #define MASK_POWERPC64 OPTION_MASK_POWERPC64 #endif @@ -519,18 +520,10 @@ extern int rs6000_vector_align[]; #ifdef TARGET_LITTLE_ENDIAN #define MASK_LITTLE_ENDIAN OPTION_MASK_LITTLE_ENDIAN #endif -#ifdef TARGET_REGNAMES -#define MASK_REGNAMES OPTION_MASK_REGNAMES -#endif - -#ifdef TARGET_PROTOTYPE -#define MASK_PROTOTYPE OPTION_MASK_PROTOTYPE -#endif - #ifdef TARGET_MODULO #define RS6000_BTM_MODULO OPTION_MASK_MODULO #endif