Message ID | e3aeafdecc4829ffe0fa75058788122a809fc6df.camel@mengyan1223.wang |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 599CF385801E for <patchwork@sourceware.org>; Thu, 24 Feb 2022 18:35:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 599CF385801E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1645727752; bh=d+n8gECfZOPwtyB6qqeh5rYB6eAOJM9hI61cAzZ2vs0=; h=Subject:To:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WzO+PikDjmoOK8SZUzvmKG4GpOiOsoFowqROy1SDh8pvbc9eFo6iOLjlDyT/MK0ZZ 6+F0fQgEIoxsxRn3sgU1X7RcqeXEMYREGAboZ20CpdDvHpeXfpibeL7OaI+BecqU3k IwvTN1OAyYuylR+2Hb+wosFo66WHsnLomcyg8yk4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id B41E23858432 for <gcc-patches@gcc.gnu.org>; Thu, 24 Feb 2022 18:35:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B41E23858432 Received: from [IPv6:240e:358:1147:5a00:fbe5:ccc7:1e82:c134] (unknown [IPv6:240e:358:1147:5a00:fbe5:ccc7:1e82:c134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id DCAC26642B for <gcc-patches@gcc.gnu.org>; Thu, 24 Feb 2022 13:35:20 -0500 (EST) Message-ID: <e3aeafdecc4829ffe0fa75058788122a809fc6df.camel@mengyan1223.wang> Subject: [PATCH] libgcc: fix a warning calling find_fde_tail To: gcc-patches@gcc.gnu.org Date: Fri, 25 Feb 2022 02:35:07 +0800 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3038.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, JMQ_SPF_NEUTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Xi Ruoyao via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Xi Ruoyao <xry111@mengyan1223.wang> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
libgcc: fix a warning calling find_fde_tail
|
|
Commit Message
Xi Ruoyao
Feb. 24, 2022, 6:35 p.m. UTC
Bootstrapped on x86_64-linux-gnu. OK for master? The third parameter of find_fde_tail is an _Unwind_Ptr (which is an integer type instead of a pointer), but we are passing NULL to it. This causes a -Wint-conversion warning. libgcc/ * unwind-dw2-fde-dip.c (_Unwind_Find_FDE): Call find_fde_tail with 0 instead of NULL. --- libgcc/unwind-dw2-fde-dip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) else
Comments
On Fri, Feb 25, 2022 at 02:35:07AM +0800, Xi Ruoyao via Gcc-patches wrote: > Bootstrapped on x86_64-linux-gnu. OK for master? > > The third parameter of find_fde_tail is an _Unwind_Ptr (which is an > integer type instead of a pointer), but we are passing NULL to it. This > causes a -Wint-conversion warning. > > libgcc/ > > * unwind-dw2-fde-dip.c (_Unwind_Find_FDE): Call find_fde_tail > with 0 instead of NULL. Ok (except that the second ChangeLog entry line should be indented just with a tab, not any spaces after the tab). > --- a/libgcc/unwind-dw2-fde-dip.c > +++ b/libgcc/unwind-dw2-fde-dip.c > @@ -514,7 +514,7 @@ _Unwind_Find_FDE (void *pc, struct dwarf_eh_bases > *bases) > # if DLFO_STRUCT_HAS_EH_DBASE > (_Unwind_Ptr) dlfo.dlfo_eh_dbase, > # else > - NULL, > + 0, > # endif > bases); > else > -- > 2.35.1 > Jakub
On Thu, 2022-02-24 at 19:53 +0100, Jakub Jelinek wrote: > On Fri, Feb 25, 2022 at 02:35:07AM +0800, Xi Ruoyao via Gcc-patches > wrote: > > Bootstrapped on x86_64-linux-gnu. OK for master? > > > > The third parameter of find_fde_tail is an _Unwind_Ptr (which is an > > integer type instead of a pointer), but we are passing NULL to it. > > This > > causes a -Wint-conversion warning. > > > > libgcc/ > > > > * unwind-dw2-fde-dip.c (_Unwind_Find_FDE): Call > > find_fde_tail > > with 0 instead of NULL. > > Ok (except that the second ChangeLog entry line should be indented > just > with a tab, not any spaces after the tab). Pushed as r12-7375, with the ChangeLog corrected.
diff --git a/libgcc/unwind-dw2-fde-dip.c b/libgcc/unwind-dw2-fde-dip.c index 3d6f39f5460..7f9be5e6b02 100644 --- a/libgcc/unwind-dw2-fde-dip.c +++ b/libgcc/unwind-dw2-fde-dip.c @@ -514,7 +514,7 @@ _Unwind_Find_FDE (void *pc, struct dwarf_eh_bases *bases) # if DLFO_STRUCT_HAS_EH_DBASE (_Unwind_Ptr) dlfo.dlfo_eh_dbase, # else - NULL, + 0, # endif bases);