diff mbox series

[1/3] testsuite: move single-file LTO pr62026 test to torture

Message ID d33d6a3406ef1f2034c9796c11e55315a70e4b76.1729893964.git.sam@gentoo.org
State New
Headers
Series Move some single-file LTO tests to torture |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed

Commit Message

Sam James Oct. 25, 2024, 10:06 p.m. UTC 
  This only started being used recently in r15-4682-g03ff420aa0a916 and
pinskia pointed out we may as well make it a proper torture test
instead as it's a single file LTO test.

gcc/testsuite/ChangeLog:
	PR lto/62026

	* g++.dg/lto/pr62026_0.C: Move to...
	* g++.dg/torture/pr62026.C: ...here.
---
 gcc/testsuite/g++.dg/{lto/pr62026_0.C => torture/pr62026.C} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename gcc/testsuite/g++.dg/{lto/pr62026_0.C => torture/pr62026.C} (75%)

Comments

Andrew Pinski Oct. 25, 2024, 10:10 p.m. UTC | #1 
On Fri, Oct 25, 2024 at 3:08 PM Sam James <sam@gentoo.org> wrote:
>
> This only started being used recently in r15-4682-g03ff420aa0a916 and
> pinskia pointed out we may as well make it a proper torture test
> instead as it's a single file LTO test.
>
> gcc/testsuite/ChangeLog:
>         PR lto/62026
>
>         * g++.dg/lto/pr62026_0.C: Move to...
>         * g++.dg/torture/pr62026.C: ...here.
> ---
>  gcc/testsuite/g++.dg/{lto/pr62026_0.C => torture/pr62026.C} | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>  rename gcc/testsuite/g++.dg/{lto/pr62026_0.C => torture/pr62026.C} (75%)
>
> diff --git a/gcc/testsuite/g++.dg/lto/pr62026_0.C b/gcc/testsuite/g++.dg/torture/pr62026.C
> similarity index 75%
> rename from gcc/testsuite/g++.dg/lto/pr62026_0.C
> rename to gcc/testsuite/g++.dg/torture/pr62026.C
> index d6445ee9b4d..4a6a219b520 100644
> --- a/gcc/testsuite/g++.dg/lto/pr62026_0.C
> +++ b/gcc/testsuite/g++.dg/torture/pr62026.C
> @@ -1,5 +1,5 @@
> -// { dg-lto-do link }
> -// { dg-lto-options {{-flto -O3 -r -Wno-return-type}} }
> +// { dg-do link }
> +// { dg-additional-options "-O3 -r -Wno-return-type" }

Do you need -O3 to the bug? Since the torture options add the -On for
you though for -flto it only tests -O2.

Thanks,
Andrew

>  class C;
>  class F {
>    virtual C m_fn1();
> --
> 2.47.0
>
Sam James Oct. 31, 2024, 8:54 p.m. UTC | #2 
Andrew Pinski <pinskia@gmail.com> writes:

> On Fri, Oct 25, 2024 at 3:08 PM Sam James <sam@gentoo.org> wrote:
>>
>> This only started being used recently in r15-4682-g03ff420aa0a916 and
>> pinskia pointed out we may as well make it a proper torture test
>> instead as it's a single file LTO test.
>>
>> gcc/testsuite/ChangeLog:
>>         PR lto/62026
>>
>>         * g++.dg/lto/pr62026_0.C: Move to...
>>         * g++.dg/torture/pr62026.C: ...here.
>> ---
>>  gcc/testsuite/g++.dg/{lto/pr62026_0.C => torture/pr62026.C} | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>  rename gcc/testsuite/g++.dg/{lto/pr62026_0.C => torture/pr62026.C} (75%)
>>
>> diff --git a/gcc/testsuite/g++.dg/lto/pr62026_0.C b/gcc/testsuite/g++.dg/torture/pr62026.C
>> similarity index 75%
>> rename from gcc/testsuite/g++.dg/lto/pr62026_0.C
>> rename to gcc/testsuite/g++.dg/torture/pr62026.C
>> index d6445ee9b4d..4a6a219b520 100644
>> --- a/gcc/testsuite/g++.dg/lto/pr62026_0.C
>> +++ b/gcc/testsuite/g++.dg/torture/pr62026.C
>> @@ -1,5 +1,5 @@
>> -// { dg-lto-do link }
>> -// { dg-lto-options {{-flto -O3 -r -Wno-return-type}} }
>> +// { dg-do link }
>> +// { dg-additional-options "-O3 -r -Wno-return-type" }
>
> Do you need -O3 to the bug? Since the torture options add the -On for
> you though for -flto it only tests -O2.

Actually, I will drop this one, as -r doesn't play well in torture and
keep it as-is.

The other 2 still stand.

>
> Thanks,
> Andrew
>
>>  class C;
>>  class F {
>>    virtual C m_fn1();
>> --
>> 2.47.0
>>
diff mbox series

Patch

diff --git a/gcc/testsuite/g++.dg/lto/pr62026_0.C b/gcc/testsuite/g++.dg/torture/pr62026.C
similarity index 75%
rename from gcc/testsuite/g++.dg/lto/pr62026_0.C
rename to gcc/testsuite/g++.dg/torture/pr62026.C
index d6445ee9b4d..4a6a219b520 100644
--- a/gcc/testsuite/g++.dg/lto/pr62026_0.C
+++ b/gcc/testsuite/g++.dg/torture/pr62026.C
@@ -1,5 +1,5 @@ 
-// { dg-lto-do link }
-// { dg-lto-options {{-flto -O3 -r -Wno-return-type}} }
+// { dg-do link }
+// { dg-additional-options "-O3 -r -Wno-return-type" }
 class C;
 class F {
   virtual C m_fn1();