From patchwork Thu Oct 24 12:53:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 99485 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69C50385840F for ; Thu, 24 Oct 2024 12:54:18 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 564C53858D35 for ; Thu, 24 Oct 2024 12:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 564C53858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 564C53858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729774424; cv=none; b=KIv4TcadpbtA9KXxSqWEAvmZBcfHgPikh7UozM7W8i4lYh7PoCn/6q0ophi91U0DSmjOY5MXfT+UrHBVUuiLzPZw+p99IFQo68MCFOsDaFic7yKVAhF++30x5vRyQsvhteoqdTBUfWN0Uz+Gjerl6Hsx4fXN9OtAS9x4xdKyZ+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729774424; c=relaxed/simple; bh=tNiN9U1PPMvY+SQZRFRMLRXMURWy/CZN7IaU4VlRRYQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=BF53UslBmbnoOlJ7k4AVsdvx9HvJDRC9By7R+Fd4SA4DlI56Oke4Ntz/404y73BlLB8ZrBfkIgL4es43P5cJZd09/3CKfmFuu/V+miTXL7fAnFb8QkqtuktpMJtzwjvhv7ix9Nush1smW4B8zj8PlGYkKWdhqWSchz/gD3t2n/E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729774417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=uKlcLXiINojxzvZag0iCTi1VRC7u30nUQpEJI7fVBLg=; b=GlY0wGt6BFmXPICMjdn0Fgy16l7Hh4kZZ9QknsN+ESleZDRhms7ajisXV7/QFlP0fUqx6u Gh+J4I4kyj5r6JGNtNqZTMq8HGedxfNCpuDNDfuCQ878viX8jHp05tDwMAZ2jSXSZzLElI uEv+ZGYeIXxxhsBVdS1JV6/vlYHglqE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-koqMELN3PmqrtrzqTy2XNg-1; Thu, 24 Oct 2024 08:53:35 -0400 X-MC-Unique: koqMELN3PmqrtrzqTy2XNg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7b14073eabdso120146085a.3 for ; Thu, 24 Oct 2024 05:53:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729774414; x=1730379214; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0eA4j2MDJW0zC0wiNWVXcRjENOg2DNbrLHh8ou3ytHI=; b=LWGqQewqTGWo4xc0DIavEB91IzaA+6HhS7mhIKnyxASXsLpLfvsGWi43dFWJiX4Ept gvQ33KZPS9oM5HUbE0iA56ePUkHVL8W15bkjqp9FumLrTZrau+J1RZYtNf+3ErAoKmVD HbTBaJtheZO9R81bpn4Z75/SLBmzsR6N+kF/+55VDvqQPpmFEazgt9jcSb7CB8qqBqtV jdBps/DYsVACnAWg1pOjwyh/nFv7pjRJalpoGp8r6S7YW0UQv4j2Eq1s94y4xrOrnWpZ 1RDjpEFZvjW34pHrwnGa0t+jLq06SwrGvDEjP/T4N59z2P3m719iX7qVh8M0FACikEa4 IfFg== X-Gm-Message-State: AOJu0YxKkNFVJnHG2EwtRaltBNXFJFa6A7YrUikMCueHaDEtdnVwvxw+ OXu5NQFPJ0GmOLu2oUcNZqYwy+5vfZubg3S6hsDPoLeVaMbCY8Pmep7QgLgsmqaB5A0CdtDqH1z BNy540kbYa2dbuikZwwpgBAHiosi6vXiN/P/9cs6ypqJqXjLm+EOVwIrxUeC1SyCZnqA8qqOgz3 ZYCdEA8QG2ZJBFTv8ttWZh3wBas/FhyaXXrJuitI4SwA== X-Received: by 2002:a05:620a:3193:b0:7b1:11d9:446e with SMTP id af79cd13be357-7b17e54075fmr680577485a.3.1729774414630; Thu, 24 Oct 2024 05:53:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYUjoyf8Wp1Ajhm7WGLXeVgWbp4tYwT4Y9VtQrfUZdqO7cZixSoJqd5MG1nNIvq2Y1O8im9g== X-Received: by 2002:a05:620a:3193:b0:7b1:11d9:446e with SMTP id af79cd13be357-7b17e54075fmr680574185a.3.1729774414059; Thu, 24 Oct 2024 05:53:34 -0700 (PDT) Received: from [192.168.0.174] ([104.219.121.80]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b165a78a56sm483101585a.112.2024.10.24.05.53.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 05:53:33 -0700 (PDT) Message-ID: Date: Thu, 24 Oct 2024 08:53:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: gcc-patches , aldy@quesejoda.com From: Andrew MacLeod Subject: [COMMITTED 2/4] - Remove pointer_min_max_operator. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org Similarly, the class pointer_min_max_operator was used back when it was shared with irange.  With prange, these operations are performed via bool operator_min::fold_range (prange &r, tree type, const prange &op1, const prange &op2, relation_trio) const   and bool operator_max::fold_range (prange &r, tree type, const prange &op1, const prange &op2, relation_trio) const This patch removes the unused clas to avoid confusion. Bootstraps on x86_64-pc-linux-gnu with no regressions.  pushed. Andrew From b6e18f91e75a28e16b4fa117d8275ab146acbb01 Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Mon, 21 Oct 2024 18:11:43 -0400 Subject: [PATCH 2/4] Remove pointer_min_max_operator. The pointer_min_max_operator class was used before the current dispatch system was created. These operations have been transferred to operator_min::fold_range () and operator_max::fold_range () with prange operands. This class is no longer used for anything, delete it. * range-op-ptr.cc (class pointer_min_max_operator): Remove. (pointer_min_max_operator::wi_fold): Remove. --- gcc/range-op-ptr.cc | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/gcc/range-op-ptr.cc b/gcc/range-op-ptr.cc index 4f4b2cf6bab..f8ce62d5719 100644 --- a/gcc/range-op-ptr.cc +++ b/gcc/range-op-ptr.cc @@ -379,34 +379,6 @@ pointer_plus_operator::op2_range (irange &r, tree type, return true; } -class pointer_min_max_operator : public range_operator -{ -public: - virtual void wi_fold (irange & r, tree type, - const wide_int &lh_lb, const wide_int &lh_ub, - const wide_int &rh_lb, const wide_int &rh_ub) const; -} op_ptr_min_max; - -void -pointer_min_max_operator::wi_fold (irange &r, tree type, - const wide_int &lh_lb, - const wide_int &lh_ub, - const wide_int &rh_lb, - const wide_int &rh_ub) const -{ - // For MIN/MAX expressions with pointers, we only care about - // nullness. If both are non null, then the result is nonnull. - // If both are null, then the result is null. Otherwise they - // are varying. - if (!wi_includes_zero_p (type, lh_lb, lh_ub) - && !wi_includes_zero_p (type, rh_lb, rh_ub)) - r.set_nonzero (type); - else if (wi_zero_p (type, lh_lb, lh_ub) && wi_zero_p (type, rh_lb, rh_ub)) - r.set_zero (type); - else - r.set_varying (type); -} - class pointer_and_operator : public range_operator { public: -- 2.45.0