[03/11] aarch64: Remove redundant generic cpu entry

Message ID cad25dc8-5b8c-374e-7122-af84fe44e683@e124511.cambridge.arm.com
State New
Headers
Series aarch64: Refactor target parsing |

Commit Message

Andrew Carlotti Jan. 10, 2025, 5:22 p.m. UTC
  The list of cores in aarch64-common.cc included an explicit "generic"
entry, despite this entry also being present in aarch64-cores.def.

gcc/ChangeLog:

	* common/config/aarch64/aarch64-common.cc
	(all_cores): Remove explicit generic entry.
  

Comments

Richard Sandiford Jan. 14, 2025, 3:30 p.m. UTC | #1
Andrew Carlotti <andrew.carlotti@arm.com> writes:
> The list of cores in aarch64-common.cc included an explicit "generic"
> entry, despite this entry also being present in aarch64-cores.def.
>
> gcc/ChangeLog:
>
> 	* common/config/aarch64/aarch64-common.cc
> 	(all_cores): Remove explicit generic entry.

OK, thanks.

Richard

>
>
> diff --git a/gcc/common/config/aarch64/aarch64-common.cc b/gcc/common/config/aarch64/aarch64-common.cc
> index 92df8b619305ba8b1c9a4b92f0674f02784f1a3a..75600548fdc6ba6383174ba81202a3a079a2bf27 100644
> --- a/gcc/common/config/aarch64/aarch64-common.cc
> +++ b/gcc/common/config/aarch64/aarch64-common.cc
> @@ -189,7 +189,6 @@ static constexpr processor_name_to_arch all_cores[] =
>  #define AARCH64_CORE(NAME, CORE_IDENT, C, ARCH_IDENT, E, F, G, H, I) \
>    {NAME, AARCH64_ARCH_##ARCH_IDENT, feature_deps::cpu_##CORE_IDENT},
>  #include "config/aarch64/aarch64-cores.def"
> -  {"generic", AARCH64_ARCH_V8A, feature_deps::V8A ().enable},
>    {"", aarch64_no_arch, 0}
>  };
>
  

Patch

diff --git a/gcc/common/config/aarch64/aarch64-common.cc b/gcc/common/config/aarch64/aarch64-common.cc
index 92df8b619305ba8b1c9a4b92f0674f02784f1a3a..75600548fdc6ba6383174ba81202a3a079a2bf27 100644
--- a/gcc/common/config/aarch64/aarch64-common.cc
+++ b/gcc/common/config/aarch64/aarch64-common.cc
@@ -189,7 +189,6 @@  static constexpr processor_name_to_arch all_cores[] =
 #define AARCH64_CORE(NAME, CORE_IDENT, C, ARCH_IDENT, E, F, G, H, I) \
   {NAME, AARCH64_ARCH_##ARCH_IDENT, feature_deps::cpu_##CORE_IDENT},
 #include "config/aarch64/aarch64-cores.def"
-  {"generic", AARCH64_ARCH_V8A, feature_deps::V8A ().enable},
   {"", aarch64_no_arch, 0}
 };