diff mbox series

[committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany

Message ID c94078cd-64a9-24ee-ed92-d7301991381c@pfeifer.com
State Committed
Commit f94598ffaf5affbc9421ff230502357b07c55d9c
Headers
Series [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gcc_check--master-arm warning Patch is already merged

Commit Message

Gerald Pfeifer May 20, 2024, 2:44 p.m. UTC 
  On Wed, 5 Jul 2023, Joern Rennecke wrote:
> I haven't worked with these targets in years and can't really do 
> sensible maintenance or reviews of patches for them. I am currently 
> working on optimizations for other ports like RISC-V.

I noticed MAINTAINERS was not updated, so pushed the patch below.

Gerald


commit f94598ffaf5affbc9421ff230502357b07c55d9c
Author: Gerald Pfeifer <gerald@pfeifer.com>
Date:   Mon May 20 16:43:05 2024 +0200

    MAINTAINERS: Update Joern Rennecke's status
    
    This is per his mail to gcc@gcc.gnu.org on 7 Jul 2023.
    
    ChangeLog:
            * MAINTAINERS: Move Joern Rennecke from arc and epiphany maintainer
            to Write After Approval.

Comments

Richard Biener May 21, 2024, 6:05 a.m. UTC | #1 
On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Wed, 5 Jul 2023, Joern Rennecke wrote:
> > I haven't worked with these targets in years and can't really do
> > sensible maintenance or reviews of patches for them. I am currently
> > working on optimizations for other ports like RISC-V.
>
> I noticed MAINTAINERS was not updated, so pushed the patch below.

That leaves the epiphany port unmaintained.  Should we automatically add such
ports to the list of obsoleted ports?

Richard.

> Gerald
>
>
> commit f94598ffaf5affbc9421ff230502357b07c55d9c
> Author: Gerald Pfeifer <gerald@pfeifer.com>
> Date:   Mon May 20 16:43:05 2024 +0200
>
>     MAINTAINERS: Update Joern Rennecke's status
>
>     This is per his mail to gcc@gcc.gnu.org on 7 Jul 2023.
>
>     ChangeLog:
>             * MAINTAINERS: Move Joern Rennecke from arc and epiphany maintainer
>             to Write After Approval.
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e0add6bef8..e2870eef2ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -56,7 +56,6 @@ aarch64 port          Kyrylo Tkachov          <ktkachov@gcc.gnu.org>
>  alpha port             Richard Henderson       <rth@gcc.gnu.org>
>  amdgcn port            Julian Brown            <julian@codesourcery.com>
>  amdgcn port            Andrew Stubbs           <ams@baylibre.com>
> -arc port               Joern Rennecke          <gnu@amylaar.uk>
>  arc port               Claudiu Zissulescu      <claziss@synopsys.com>
>  arm port               Nick Clifton            <nickc@redhat.com>
>  arm port               Richard Earnshaw        <richard.earnshaw@arm.com>
> @@ -68,7 +67,6 @@ c6x port              Bernd Schmidt           <bernds_cb1@t-online.de>
>  cris port              Hans-Peter Nilsson      <hp@axis.com>
>  c-sky port             Xianmiao Qu             <cooper.qu@linux.alibaba.com>
>  c-sky port             Yunhai Shang            <yunhai@linux.alibaba.com>
> -epiphany port          Joern Rennecke          <gnu@amylaar.uk>
>  fr30 port              Nick Clifton            <nickc@redhat.com>
>  frv port               Nick Clifton            <nickc@redhat.com>
>  frv port               Alexandre Oliva         <aoliva@gcc.gnu.org>
> @@ -634,6 +632,7 @@ Joe Ramsay                                  <joe.ramsay@arm.com>
>  Rolf Rasmussen                                 <rolfwr@gcc.gnu.org>
>  Fritz Reese                                    <fritzoreese@gmail.com>
>  Volker Reichelt                                        <v.reichelt@netcologne.de>
> +Joern Rennecke                                 <gnu@amylaar.uk>
>  Bernhard Reutner-Fischer                       <rep.dot.nop@gmail.com>
>  Tom Rix                                                <trix@redhat.com>
>  Thomas Rodgers                                 <trodgers@redhat.com>
Jeff Law May 21, 2024, 1:57 p.m. UTC | #2 
On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>>
>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
>>> I haven't worked with these targets in years and can't really do
>>> sensible maintenance or reviews of patches for them. I am currently
>>> working on optimizations for other ports like RISC-V.
>>
>> I noticed MAINTAINERS was not updated, so pushed the patch below.
> 
> That leaves the epiphany port unmaintained.  Should we automatically add such
> ports to the list of obsoleted ports?
Given that epiphany has randomly failed tests for the last 3+ years due 
to bugs in its patterns, yes, it really needs to be deprecated.

I tried to fix the worst of the offenders in epiphany.md a few years 
back and gave up.  Essentially seemingly innocent changes in the RTL 
will cause reload to occasionally not see a path to get constraints 
satisfied.  So a test which passes today, will flip to failing tomorrow 
while some other test of tests will go the other way.



jeff
Paul Koning May 21, 2024, 2:02 p.m. UTC | #3 
> On May 21, 2024, at 9:57 AM, Jeff Law <jeffreyalaw@gmail.com> wrote:
> 
> 
> 
> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>>> 
>>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
>>>> I haven't worked with these targets in years and can't really do
>>>> sensible maintenance or reviews of patches for them. I am currently
>>>> working on optimizations for other ports like RISC-V.
>>> 
>>> I noticed MAINTAINERS was not updated, so pushed the patch below.
>> That leaves the epiphany port unmaintained.  Should we automatically add such
>> ports to the list of obsoleted ports?
> Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated.
> 
> I tried to fix the worst of the offenders in epiphany.md a few years back and gave up.  Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied.  So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way.

Does LRA make that issue go away, or does it not help?

	paul
Jeff Law May 21, 2024, 4:21 p.m. UTC | #4 
On 5/21/24 8:02 AM, Paul Koning wrote:
> 
> 
>> On May 21, 2024, at 9:57 AM, Jeff Law <jeffreyalaw@gmail.com> wrote:
>>
>>
>>
>> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
>>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>>>>
>>>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
>>>>> I haven't worked with these targets in years and can't really do
>>>>> sensible maintenance or reviews of patches for them. I am currently
>>>>> working on optimizations for other ports like RISC-V.
>>>>
>>>> I noticed MAINTAINERS was not updated, so pushed the patch below.
>>> That leaves the epiphany port unmaintained.  Should we automatically add such
>>> ports to the list of obsoleted ports?
>> Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated.
>>
>> I tried to fix the worst of the offenders in epiphany.md a few years back and gave up.  Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied.  So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way.
> 
> Does LRA make that issue go away, or does it not help?
LRA didn't trivially work on epiphany.  I didn't care enough about the 
port to try and make it LRA compatible.

jeff
Richard Biener May 21, 2024, 4:43 p.m. UTC | #5 
On Tue, May 21, 2024 at 6:21 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 5/21/24 8:02 AM, Paul Koning wrote:
> >
> >
> >> On May 21, 2024, at 9:57 AM, Jeff Law <jeffreyalaw@gmail.com> wrote:
> >>
> >>
> >>
> >> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote:
> >>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
> >>>>
> >>>> On Wed, 5 Jul 2023, Joern Rennecke wrote:
> >>>>> I haven't worked with these targets in years and can't really do
> >>>>> sensible maintenance or reviews of patches for them. I am currently
> >>>>> working on optimizations for other ports like RISC-V.
> >>>>
> >>>> I noticed MAINTAINERS was not updated, so pushed the patch below.
> >>> That leaves the epiphany port unmaintained.  Should we automatically add such
> >>> ports to the list of obsoleted ports?
> >> Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated.
> >>
> >> I tried to fix the worst of the offenders in epiphany.md a few years back and gave up.  Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied.  So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way.
> >
> > Does LRA make that issue go away, or does it not help?
> LRA didn't trivially work on epiphany.  I didn't care enough about the
> port to try and make it LRA compatible.

In that case LRA will make the issue go away (the port, that is ...).

Richard.

>
> jeff
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 8e0add6bef8..e2870eef2ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -56,7 +56,6 @@  aarch64 port		Kyrylo Tkachov		<ktkachov@gcc.gnu.org>
 alpha port		Richard Henderson	<rth@gcc.gnu.org>
 amdgcn port		Julian Brown		<julian@codesourcery.com>
 amdgcn port		Andrew Stubbs		<ams@baylibre.com>
-arc port		Joern Rennecke		<gnu@amylaar.uk>
 arc port		Claudiu Zissulescu	<claziss@synopsys.com>
 arm port		Nick Clifton		<nickc@redhat.com>
 arm port		Richard Earnshaw	<richard.earnshaw@arm.com>
@@ -68,7 +67,6 @@  c6x port		Bernd Schmidt		<bernds_cb1@t-online.de>
 cris port		Hans-Peter Nilsson	<hp@axis.com>
 c-sky port		Xianmiao Qu		<cooper.qu@linux.alibaba.com>
 c-sky port		Yunhai Shang		<yunhai@linux.alibaba.com>
-epiphany port		Joern Rennecke		<gnu@amylaar.uk>
 fr30 port		Nick Clifton		<nickc@redhat.com>
 frv port		Nick Clifton		<nickc@redhat.com>
 frv port		Alexandre Oliva		<aoliva@gcc.gnu.org>
@@ -634,6 +632,7 @@  Joe Ramsay					<joe.ramsay@arm.com>
 Rolf Rasmussen					<rolfwr@gcc.gnu.org>
 Fritz Reese					<fritzoreese@gmail.com>
 Volker Reichelt					<v.reichelt@netcologne.de>
+Joern Rennecke					<gnu@amylaar.uk>
 Bernhard Reutner-Fischer			<rep.dot.nop@gmail.com>
 Tom Rix						<trix@redhat.com>
 Thomas Rodgers					<trodgers@redhat.com>