diff mbox series

Fortran: Fix scope for OMP AFFINITY clause iterator variables [PR103695]

Message ID c5c6bc87-86d6-bd31-0895-0c7bf6393641@codesourcery.com
State New
Headers
Series Fortran: Fix scope for OMP AFFINITY clause iterator variables [PR103695] |

Commit Message

Sandra Loosemore Jan. 19, 2022, 9:53 p.m. UTC 
  This patch is for PR103695, marked as a P1 regression.  OK to check in?

-Sandra

Comments

Thomas Koenig Jan. 19, 2022, 10:01 p.m. UTC | #1 
Hi Sandra,

> This patch is for PR103695, marked as a P1 regression.  OK to check in?

I'm not an OpenMP expert, but this looks straightforward enough.

I assume you ran a regression-test?  OK if that is the case.

Thanks for the patch!

Best regards

	Thomas
Sandra Loosemore Jan. 20, 2022, 9:34 p.m. UTC | #2 
On 1/19/22 3:01 PM, Thomas Koenig wrote:
> 
> Hi Sandra,
> 
>> This patch is for PR103695, marked as a P1 regression.  OK to check in?
> 
> I'm not an OpenMP expert, but this looks straightforward enough.
> 
> I assume you ran a regression-test?  OK if that is the case.

Yes, test results on x86_64-linux-gnu look good.

Tobias pointed out to me that this bug was likely also the cause of the 
ICE reported in PR102621, so I verified that was also fixed now, added 
the test case from that issue to the patch, and committed this version.

-Sandra
diff mbox series

Patch

commit 21f8ac540b73e3838b63924e3c7e6c2ad25568ee
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Wed Jan 19 12:50:49 2022 -0800

    Fortran: Fix scope for OMP AFFINITY clause iterator variables [PR103695]
    
    gfc_finish_var_decl was confused by the undocumented overloading of
    the proc_name field in struct gfc_namespace to contain iterator
    variables for the OpenMP AFFINITY clause, causing it to insert the
    decls in the wrong scope.  This patch adds a new distinct field to
    hold these variables.
    
    2022-01-19  Sandra Loosemore  <sandra@codesourcery.com>
    
    	PR fortran/103695
    
    	gcc/fortran
    	* gfortran.h (struct gfc_namespace) Add omp_affinity_iterator
    	field.
    	* dump-parse-tree.cc (show_iterator): Use it.
    	* openmp.cc (gfc_match_iterator): Likewise.
    	(resolve_omp_clauses): Likewise.
    	* trans-decl.cc (gfc_finish_var_decl): Likewise.
    	* trans-openmp.cc (handle_iterator): Likewise.
    
    	gcc/testsuite/
    	* gfortran.dg/gomp/affinity-clause-3.f90: Adjust pattern.
    	* gfortran.dg/gomp/pr103695.f90: New.

diff --git a/gcc/fortran/dump-parse-tree.cc b/gcc/fortran/dump-parse-tree.cc
index a618ae2..3112cae 100644
--- a/gcc/fortran/dump-parse-tree.cc
+++ b/gcc/fortran/dump-parse-tree.cc
@@ -1302,10 +1302,10 @@  show_code (int level, gfc_code *c)
 static void
 show_iterator (gfc_namespace *ns)
 {
-  for (gfc_symbol *sym = ns->proc_name; sym; sym = sym->tlink)
+  for (gfc_symbol *sym = ns->omp_affinity_iterators; sym; sym = sym->tlink)
     {
       gfc_constructor *c;
-      if (sym != ns->proc_name)
+      if (sym != ns->omp_affinity_iterators)
 	fputc (',', dumpfile);
       fputs (sym->name, dumpfile);
       fputc ('=', dumpfile);
diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h
index 00a558a..993879f 100644
--- a/gcc/fortran/gfortran.h
+++ b/gcc/fortran/gfortran.h
@@ -2107,6 +2107,9 @@  typedef struct gfc_namespace
   /* !$ACC ROUTINE clauses.  */
   gfc_omp_clauses *oacc_routine_clauses;
 
+  /* !$ACC TASK AFFINITY iterator symbols.  */
+  gfc_symbol *omp_affinity_iterators;
+
   /* !$ACC ROUTINE names.  */
   gfc_oacc_routine_name *oacc_routine_names;
 
diff --git a/gcc/fortran/openmp.cc b/gcc/fortran/openmp.cc
index 9b73b9f..073e5a1 100644
--- a/gcc/fortran/openmp.cc
+++ b/gcc/fortran/openmp.cc
@@ -1123,7 +1123,7 @@  gfc_match_iterator (gfc_namespace **ns, bool permit_var)
       if (last)
 	last->tlink = sym;
       else
-	(*ns)->proc_name = sym;
+	(*ns)->omp_affinity_iterators = sym;
       last = sym;
       sym->declared_at = prev_loc;
       sym->ts = ts;
@@ -6832,8 +6832,8 @@  resolve_omp_clauses (gfc_code *code, gfc_omp_clauses *omp_clauses,
 		    && n->u2.ns && !n->u2.ns->resolved)
 		  {
 		    n->u2.ns->resolved = 1;
-		    for (gfc_symbol *sym = n->u2.ns->proc_name; sym;
-			 sym = sym->tlink)
+		    for (gfc_symbol *sym = n->u2.ns->omp_affinity_iterators;
+			 sym; sym = sym->tlink)
 		      {
 			gfc_constructor *c;
 			c = gfc_constructor_first (sym->value->value.constructor);
diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc
index 1112ca9..6493cc2 100644
--- a/gcc/fortran/trans-decl.cc
+++ b/gcc/fortran/trans-decl.cc
@@ -647,6 +647,9 @@  gfc_finish_var_decl (tree decl, gfc_symbol * sym)
 	       && sym->ns->proc_name->attr.flavor == FL_LABEL)
 	/* This is a BLOCK construct.  */
 	add_decl_as_local (decl);
+      else if (sym->ns->omp_affinity_iterators)
+	/* This is a block-local iterator.  */
+	add_decl_as_local (decl);
       else
 	gfc_add_decl_to_parent_function (decl);
     }
diff --git a/gcc/fortran/trans-openmp.cc b/gcc/fortran/trans-openmp.cc
index 9eabf68..d5a6b2d 100644
--- a/gcc/fortran/trans-openmp.cc
+++ b/gcc/fortran/trans-openmp.cc
@@ -2483,7 +2483,7 @@  static tree
 handle_iterator (gfc_namespace *ns, stmtblock_t *iter_block, tree block)
 {
   tree list = NULL_TREE;
-  for (gfc_symbol *sym = ns->proc_name; sym; sym = sym->tlink)
+  for (gfc_symbol *sym = ns->omp_affinity_iterators; sym; sym = sym->tlink)
     {
       gfc_constructor *c;
       gfc_se se;
diff --git a/gcc/testsuite/gfortran.dg/gomp/affinity-clause-3.f90 b/gcc/testsuite/gfortran.dg/gomp/affinity-clause-3.f90
index 3fd39fe..eebe4dd 100644
--- a/gcc/testsuite/gfortran.dg/gomp/affinity-clause-3.f90
+++ b/gcc/testsuite/gfortran.dg/gomp/affinity-clause-3.f90
@@ -11,4 +11,4 @@  subroutine foo
   !$omp end task
 end
 ! { dg-final { scan-tree-dump-times "= ibar \\(&C\\." 3 "gimple" } }
-! { dg-final { scan-tree-dump-times "= ibar \\(j\\." 1 "gimple" } }
+! { dg-final { scan-tree-dump-times "= ibar \\(&j" 1 "gimple" } }
diff --git a/gcc/testsuite/gfortran.dg/gomp/pr103695.f90 b/gcc/testsuite/gfortran.dg/gomp/pr103695.f90
new file mode 100644
index 0000000..cc9764e
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/gomp/pr103695.f90
@@ -0,0 +1,18 @@ 
+! This test case used to ICE in verify_ssa due to the iterator variable j
+! incorrectly being inserted into program scope.
+
+program p
+   integer :: i
+   do i = 1, 3
+      call sub (s(i))
+   end do
+contains
+   function s(n) result(z)
+      integer, target, intent(in) :: n
+      integer, pointer :: z
+      integer :: a(8), b(8), c(8)
+      !$omp task affinity (iterator(j=1:8) : a(j), b(j), c(j))
+      !$omp end task
+      z => n
+   end
+end