diff mbox series

[v1,1/1] aarch64: Ignore vcopy_lane_indices.c on 32-bit targets

Message ID bmm.hk7bt2bq6c.gcc.gcc-TEST.karmea01.187.1.1@forge-stage.sourceware.org
State New
Headers
Series aarch64: Ignore vcopy_lane_indices.c on 32-bit targets |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_simplebootstrap_build--master-arm-bootstrap fail Build failed
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed

Commit Message

Karl Meakin via Sourceware Forge July 8, 2026, 1:01 p.m. UTC 
  From: Karl Meakin <karl.meakin@arm.com>

The `vcopy_lane` family of intrinsics are only available on AArch64
targets (ie not on 32-bit targets), so the test should be ignored on
those targets.

gcc/testsuite/ChangeLog:

	* gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c:
	Don't test this file on 32-bit targets.
---
 .../gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrea Pinski July 9, 2026, 8:17 a.m. UTC | #1 
On Wed, Jul 8, 2026 at 6:03 AM Karl Meakin via Sourceware Forge
<forge-bot+karmea01@forge-stage.sourceware.org> wrote:
>
> From: Karl Meakin <karl.meakin@arm.com>
>
> The `vcopy_lane` family of intrinsics are only available on AArch64
> targets (ie not on 32-bit targets), so the test should be ignored on
> those targets.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c:
>         Don't test this file on 32-bit targets.
> ---
>  .../gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
> index a289659aec2c..839b1a832347 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
> @@ -1,4 +1,4 @@
> -/* { dg-do assemble } */
> +/* { dg-do compile { target { aarch64-*-* } } } */

Is there a reason why you changed it from assemble to compile?
Otherwise ok.

>
>  #include <arm_neon.h>
>
> --
> 2.54.0
>
Karl Meakin July 9, 2026, 3:35 p.m. UTC | #2 
On 09/07/2026 09:17, Andrea Pinski wrote:
> On Wed, Jul 8, 2026 at 6:03 AM Karl Meakin via Sourceware Forge
> <forge-bot+karmea01@forge-stage.sourceware.org> wrote:
>> From: Karl Meakin <karl.meakin@arm.com>
>>
>> The `vcopy_lane` family of intrinsics are only available on AArch64
>> targets (ie not on 32-bit targets), so the test should be ignored on
>> those targets.
>>
>> gcc/testsuite/ChangeLog:
>>
>>          * gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c:
>>          Don't test this file on 32-bit targets.
>> ---
>>   .../gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c  | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
>> index a289659aec2c..839b1a832347 100644
>> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
>> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
>> @@ -1,4 +1,4 @@
>> -/* { dg-do assemble } */
>> +/* { dg-do compile { target { aarch64-*-* } } } */
> Is there a reason why you changed it from assemble to compile?
> Otherwise ok.
The test is only checking the error messages, not the emitted assembly, 
so assembling the code is unnecessary.
>>   #include <arm_neon.h>
>>
>> --
>> 2.54.0
>>
Andrea Pinski July 9, 2026, 3:44 p.m. UTC | #3 
On Thu, Jul 9, 2026 at 8:36 AM Karl Meakin <karl.meakin@arm.com> wrote:
>
> On 09/07/2026 09:17, Andrea Pinski wrote:
> > On Wed, Jul 8, 2026 at 6:03 AM Karl Meakin via Sourceware Forge
> > <forge-bot+karmea01@forge-stage.sourceware.org> wrote:
> >> From: Karl Meakin <karl.meakin@arm.com>
> >>
> >> The `vcopy_lane` family of intrinsics are only available on AArch64
> >> targets (ie not on 32-bit targets), so the test should be ignored on
> >> those targets.
> >>
> >> gcc/testsuite/ChangeLog:
> >>
> >>          * gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c:
> >>          Don't test this file on 32-bit targets.
> >> ---
> >>   .../gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c  | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
> >> index a289659aec2c..839b1a832347 100644
> >> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
> >> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
> >> @@ -1,4 +1,4 @@
> >> -/* { dg-do assemble } */
> >> +/* { dg-do compile { target { aarch64-*-* } } } */
> > Is there a reason why you changed it from assemble to compile?
> > Otherwise ok.
> The test is only checking the error messages, not the emitted assembly,
> so assembling the code is unnecessary.

oh ok. Then approved.

> >>   #include <arm_neon.h>
> >>
> >> --
> >> 2.54.0
> >>
>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
index a289659aec2c..839b1a832347 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_indices.c
@@ -1,4 +1,4 @@ 
-/* { dg-do assemble } */
+/* { dg-do compile { target { aarch64-*-* } } } */
 
 #include <arm_neon.h>