From patchwork Tue Jun 2 08:58:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon via Sourceware Forge X-Patchwork-Id: 136265 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20D194BA2E2F for ; Tue, 2 Jun 2026 09:11:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20D194BA2E2F X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from forge-stage.sourceware.org (vm08.sourceware.org [IPv6:2620:52:6:3111::39]) by sourceware.org (Postfix) with ESMTPS id A7F154BA23DC for ; Tue, 2 Jun 2026 08:59:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7F154BA23DC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=forge-stage.sourceware.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=forge-stage.sourceware.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A7F154BA23DC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2620:52:6:3111::39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780390767; cv=none; b=sCK9kohezBBP3CCkdR+v2+yvZJd488UCzQGJV2JNc6EGpgcab87NPlKdNuk740CBEMXavV7FOk014Y6l3cH+k95NpuiMgGPc+lz+6PzF0Y+Lic5lsl5SbNB+qX554oOG8BgGyQC8LCfuURMjLKe3JqqnF3zrAe277pbcvs03fX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780390767; c=relaxed/simple; bh=i8opZdjNAgQUob4K6XUkfhq8fCr8yrTwRSWghTrnqxs=; h=From:Date:Subject:To:Message-ID; b=Fj7HDsbKHA31rmyJdeJCN8+fb1vGnnKZ1v7QaXvychP5p1WXZSDURiETjN6UK/zQ/LaOZflZA7mgGfakBJuWa9iuACrRT/joUsG2vbI3Umn+EdSpQcaZ8SSjf5+d6OFL5u+XXd3KoCIMVNdTJBUFZOTVPxuWOnOaxvsRCe91CAM= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7F154BA23DC Received: from forge-stage.sourceware.org (localhost [IPv6:::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by forge-stage.sourceware.org (Postfix) with ESMTPS id 6ED1242A02 for ; Tue, 02 Jun 2026 08:59:27 +0000 (UTC) From: Christophe Lyon via Sourceware Forge Date: Tue, 02 Jun 2026 08:58:30 +0000 Subject: [PATCH v1 1/1] top-level: Split forgejo format checks To: gcc-patches mailing list Message-ID: X-Mailer: batrachomyomachia X-Requested-Reviewer: rdfm X-Pull-Request-Organization: gcc X-Pull-Request-Repository: gcc-TEST X-Pull-Request: https://forge.sourceware.org/gcc/gcc-TEST/pulls/169 References: In-Reply-To: X-Patch-URL: https://forge.sourceware.org/clyon/gcc-TEST/commit/bd7a534847b5eb2933ff356c99bd6ecbd80a2279 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: gcc-patches mailing list , clyon@gcc.gnu.org Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org From: Christophe Lyon Since contrib/check_GNU_style.py has lots of false positives, it is causing the forgejo CI format-checks workflow to fail too frequently. To make it clearer, split the current checks (check_GNU_style.py and git_check_commit.py) so that we clearly see which one passes and which one passes in the forge UI. ChangeLog: * .forgejo/workflows/format-checks.yaml: Split format checks into GNU-style-check and ChangeLog-format-check. --- .forgejo/workflows/format-checks.yaml | 33 +++++++++++++++------------ 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/.forgejo/workflows/format-checks.yaml b/.forgejo/workflows/format-checks.yaml index 6139cb2cb7d5..27c4d42003a5 100644 --- a/.forgejo/workflows/format-checks.yaml +++ b/.forgejo/workflows/format-checks.yaml @@ -3,15 +3,12 @@ on: types: [opened, synchronize, reopened] jobs: - format-checks: + GNU-style-check: runs-on: sourceware-runner - outputs: - styleoutput: ${{ steps.check_gnu_style.outputs.styleresult }} - verifyoutput: ${{ steps.gcc_verify.outputs.verifyresult }} steps: - name: install dependencies run: | - echo "Installing node.js" + echo "Installing dependencies" apt-get update apt-get install -qq -y nodejs git python3 python3-git python3-termcolor python3-unidiff @@ -23,7 +20,6 @@ jobs: - name: check GNU style id: check_gnu_style - continue-on-error: true run: | echo "Running check_GNU_style.py" git fetch origin ${FORGEJO_BASE_REF}:${FORGEJO_BASE_REF} @@ -32,18 +28,25 @@ jobs: echo "Checking GNU style for $sha" git show $sha | ./contrib/check_GNU_style.py - done - echo "styleresult=pass" | tee -a $FORGEJO_OUTPUT + + ChangeLog-format-check: + runs-on: sourceware-runner + steps: + - name: install dependencies + run: | + echo "Installing dependencies" + apt-get update + apt-get install -qq -y nodejs git python3 python3-git python3-termcolor python3-unidiff + + # Checkout GCC sources, request an history depth of 100, + # hopefully sufficient for all patch series (the default is 1) + - uses: actions/checkout@v4 + with: + fetch-depth: 100 - name: gcc-verify id: gcc_verify - continue-on-error: true run: | echo "Running gcc-verify check" + git fetch origin ${FORGEJO_BASE_REF}:${FORGEJO_BASE_REF} ./contrib/gcc-changelog/git_check_commit.py ${FORGEJO_BASE_REF}..${FORGEJO_SHA} - echo "verifyresult=pass" | tee -a $FORGEJO_OUTPUT - - - name: final-result - run: | - echo "Computing final result" - test "${{ steps.check_gnu_style.outputs.styleresult }}" = "pass" - test "${{ steps.gcc_verify.outputs.verifyresult }}" = "pass"