diff mbox series

[v1,1/1] top-level: Split forgejo format checks

Message ID bmm.hj3g79m88u.gcc.gcc-TEST.clyon.169.1.1@forge-stage.sourceware.org
State New
Headers
Series top-level: Split forgejo format checks |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_simplebootstrap_build--master-aarch64-bootstrap success Build passed
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_simplebootstrap_build--master-arm-bootstrap success Build passed

Commit Message

Christophe Lyon via Sourceware Forge June 2, 2026, 8:58 a.m. UTC 
  From: Christophe Lyon <christophe.lyon@arm.com>

Since contrib/check_GNU_style.py has lots of false positives, it is
causing the forgejo CI format-checks workflow to fail too frequently.

To make it clearer, split the current checks (check_GNU_style.py and
git_check_commit.py) so that we clearly see which one passes and which
one passes in the forge UI.

ChangeLog:
	* .forgejo/workflows/format-checks.yaml: Split format checks into
	GNU-style-check and ChangeLog-format-check.
---
 .forgejo/workflows/format-checks.yaml | 33 +++++++++++++++------------
 1 file changed, 18 insertions(+), 15 deletions(-)
diff mbox series

Patch

diff --git a/.forgejo/workflows/format-checks.yaml b/.forgejo/workflows/format-checks.yaml
index 6139cb2cb7d5..27c4d42003a5 100644
--- a/.forgejo/workflows/format-checks.yaml
+++ b/.forgejo/workflows/format-checks.yaml
@@ -3,15 +3,12 @@  on:
     types: [opened, synchronize, reopened]
 
 jobs:
-  format-checks:
+  GNU-style-check:
     runs-on: sourceware-runner
-    outputs:
-      styleoutput: ${{ steps.check_gnu_style.outputs.styleresult }}
-      verifyoutput: ${{ steps.gcc_verify.outputs.verifyresult }}
     steps:
       - name: install dependencies
         run: |
-          echo "Installing node.js"
+          echo "Installing dependencies"
           apt-get update
           apt-get install -qq -y nodejs git python3 python3-git python3-termcolor python3-unidiff
 
@@ -23,7 +20,6 @@  jobs:
 
       - name: check GNU style
         id: check_gnu_style
-        continue-on-error: true
         run: |
           echo "Running check_GNU_style.py"
           git fetch origin ${FORGEJO_BASE_REF}:${FORGEJO_BASE_REF}
@@ -32,18 +28,25 @@  jobs:
             echo "Checking GNU style for $sha"
             git show $sha | ./contrib/check_GNU_style.py -
           done
-          echo "styleresult=pass" | tee -a $FORGEJO_OUTPUT
+
+  ChangeLog-format-check:
+    runs-on: sourceware-runner
+    steps:
+      - name: install dependencies
+        run: |
+          echo "Installing dependencies"
+          apt-get update
+          apt-get install -qq -y nodejs git python3 python3-git python3-termcolor python3-unidiff
+
+      # Checkout GCC sources, request an history depth of 100,
+      # hopefully sufficient for all patch series (the default is 1)
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 100
 
       - name: gcc-verify
         id: gcc_verify
-        continue-on-error: true
         run: |
           echo "Running gcc-verify check"
+          git fetch origin ${FORGEJO_BASE_REF}:${FORGEJO_BASE_REF}
           ./contrib/gcc-changelog/git_check_commit.py ${FORGEJO_BASE_REF}..${FORGEJO_SHA}
-          echo "verifyresult=pass" | tee -a $FORGEJO_OUTPUT
-
-      - name: final-result
-        run: |
-          echo "Computing final result"
-          test "${{ steps.check_gnu_style.outputs.styleresult }}" = "pass"
-          test "${{ steps.gcc_verify.outputs.verifyresult }}" = "pass"