diff mbox series

[libgfortran] PR105361 Followup fix to test case

Message ID a06cfbf7-367e-44b5-a859-a7a213a9b990@gmail.com
State New
Headers
Series [libgfortran] PR105361 Followup fix to test case |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm fail Patch failed to apply
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 fail Patch failed to apply

Commit Message

Jerry D July 31, 2024, 4:08 p.m. UTC 
  I plan to push this soon to hopefully fix some test breakage on some 
architetures.  It is simple and obvious. I did not get any feedback on 
this and I do not have access to the machines in question.

Regression tested on linux-x86-64.

Regards,

Jerry

commit bc4ee05dc7c60d534ef927ac5e679f67fb99d54b
Author: Jerry DeLisle <jvdelisle@gcc.gnu.org>
Date:   Wed Jul 31 08:58:17 2024 -0700

     Fortran: Add newline character to test input.

     gcc/testsuite/ChangeLog:

             PR libfortran/105361

             * gfortran.dg/pr105361.f90: Add newline character to test
             input to provide more compliant test.

Comments

Andre Vehreschild Aug. 1, 2024, 6:22 a.m. UTC | #1 
Hi Jerry,

looks fine to me. The change is so small that I see no harm, ok to merge.
Thanks for the patch.

- Andre

On Wed, 31 Jul 2024 09:08:54 -0700
Jerry D <jvdelisle2@gmail.com> wrote:

> I plan to push this soon to hopefully fix some test breakage on some
> architetures.  It is simple and obvious. I did not get any feedback on
> this and I do not have access to the machines in question.
>
> Regression tested on linux-x86-64.
>
> Regards,
>
> Jerry
>
> commit bc4ee05dc7c60d534ef927ac5e679f67fb99d54b
> Author: Jerry DeLisle <jvdelisle@gcc.gnu.org>
> Date:   Wed Jul 31 08:58:17 2024 -0700
>
>      Fortran: Add newline character to test input.
>
>      gcc/testsuite/ChangeLog:
>
>              PR libfortran/105361
>
>              * gfortran.dg/pr105361.f90: Add newline character to test
>              input to provide more compliant test.
>
> diff --git a/gcc/testsuite/gfortran.dg/pr105361.f90
> b/gcc/testsuite/gfortran.dg/pr105361.f90
> index e2d3b07caca..62821c2802d 100644
> --- a/gcc/testsuite/gfortran.dg/pr105361.f90
> +++ b/gcc/testsuite/gfortran.dg/pr105361.f90
> @@ -27,7 +27,7 @@ program main
>     type(foo) :: a, b
>     real :: c, d
>     open(10, access="stream")
> -  write(10) "1 2" ! // NEW_LINE('A')
> +  write(10) "1 2" // NEW_LINE('A')
>     close(10)
>     open(10)
>     read(10,*) c, d


--
Andre Vehreschild * Email: vehre ad gmx dot de
diff mbox series

Patch

diff --git a/gcc/testsuite/gfortran.dg/pr105361.f90 
b/gcc/testsuite/gfortran.dg/pr105361.f90
index e2d3b07caca..62821c2802d 100644
--- a/gcc/testsuite/gfortran.dg/pr105361.f90
+++ b/gcc/testsuite/gfortran.dg/pr105361.f90
@@ -27,7 +27,7 @@  program main
    type(foo) :: a, b
    real :: c, d
    open(10, access="stream")
-  write(10) "1 2" ! // NEW_LINE('A')
+  write(10) "1 2" // NEW_LINE('A')
    close(10)
    open(10)
    read(10,*) c, d