From patchwork Fri Feb 2 10:52:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 85224 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A19E43858034 for ; Fri, 2 Feb 2024 10:53:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E45473858403 for ; Fri, 2 Feb 2024 10:52:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E45473858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E45473858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706871161; cv=none; b=GtzhjJH1NK4fCOu++a/Noh2KEBXSGf9g2RotHkh/4LUZ8scHkQ8M7Ug7oZjupV6whebifMvxrHdk88ANu0Zsl4xqQqoPuHY0V498RVLD+upjP2x3yD5dE/NQe+eopsRnuwgqBzzfPUWqV/UM92iR1s98Nm+Oc49s8CmltRAN0SQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706871161; c=relaxed/simple; bh=iTA5k52m+eG8U19eBPaZ3jd/72GZlWEaDDvIX3hmE9Q=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ZhS3ey1fFGHA77oFmgc+eNfLRhbC1rAgeFNvCplLd+eZVQ2rN12pf5hqg+vZzcN9VyxfKWKakMwQ/UoDcX6KkA8za/wRfP+RylBOVp3A8l1XUTtiQ0UQhx5mY2Q1xtWFH2+ShexXnv5TeNxVLywNKt2/xWFv79FgWZoVEQTR0yE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706871158; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=KYkZB+kuGQ2yFLQU915hodjlWhlBgJpqemM6AJfZmHU=; b=MUV5zBKn9xhoGUaYkuxswIrnUf6vZQGkIWsDYcw6MCsMwZSAfsMdroG4CKHaVmCZxSrtd3 P4C/LR5UA/E9R1CzVXmFJ5JF7q5+ai+5JCXr4YEDnwUb81/Qk+CQNds5LIuelHb27yb6Bm IMs4TU75VHcvkZT/PpxC9QpHWM8pvUY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-dUNjy82HOg-PcQ0ymWrDgQ-1; Fri, 02 Feb 2024 05:52:37 -0500 X-MC-Unique: dUNjy82HOg-PcQ0ymWrDgQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B2CA1C0BA45 for ; Fri, 2 Feb 2024 10:52:37 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4046492BC6 for ; Fri, 2 Feb 2024 10:52:36 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 412AqUBN2707413 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Fri, 2 Feb 2024 11:52:30 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 412AqU122707412 for gcc-patches@gcc.gnu.org; Fri, 2 Feb 2024 11:52:30 +0100 Date: Fri, 2 Feb 2024 11:52:29 +0100 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org Subject: [committed] libgcc: Export XF, TF, HF and BFmode specific _BitInt symbols from libgcc_s.so.1 [PR113700] Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Hi! Rainer pointed out that __PFX__ and __FIXPTPFX__ prefix replacement is done solely for libgcc-std.ver.in and not for the *.ver files in config. I've used the __PFX__ prefix even in config/i386/libgcc-glibc.ver because it was used for similar symbols in libgcc-std.ver.in, and that results in those symbols being STB_LOCAL in libgcc_s.so.1. Tests still work because gcc by default uses -static-libgcc when linking (unlike g++ etc.), but would have failed when using -shared-libgcc (but I see nothing in the testsuite actually testing with -shared-libgcc, so am not adding tests). With the patch, libgcc_s.so.1 now exports __fixtfbitint@@GCC_14.0.0 FUNC GLOBAL DEFAULT __fixxfbitint@@GCC_14.0.0 FUNC GLOBAL DEFAULT __floatbitintbf@@GCC_14.0.0 FUNC GLOBAL DEFAULT __floatbitinthf@@GCC_14.0.0 FUNC GLOBAL DEFAULT __floatbitinttf@@GCC_14.0.0 FUNC GLOBAL DEFAULT __floatbitintxf@@GCC_14.0.0 FUNC GLOBAL DEFAULT on x86_64-linux which it wasn't before. Tested on x86_64-linux, committed to trunk as obvious. 2024-02-02 Jakub Jelinek PR target/113700 * config/i386/libgcc-glibc.ver (GCC_14.0.0): Remove __PFX prefixes from symbol names. Jakub --- libgcc/config/i386/libgcc-glibc.ver.jj 2024-01-03 22:33:38.380691216 +0100 +++ libgcc/config/i386/libgcc-glibc.ver 2024-02-02 11:39:59.374523748 +0100 @@ -229,10 +229,10 @@ GCC_13.0.0 { %inherit GCC_14.0.0 GCC_13.0.0 GCC_14.0.0 { - __PFX__fixxfbitint - __PFX__fixtfbitint - __PFX__floatbitintbf - __PFX__floatbitinthf - __PFX__floatbitintxf - __PFX__floatbitinttf + __fixxfbitint + __fixtfbitint + __floatbitintbf + __floatbitinthf + __floatbitintxf + __floatbitinttf }