From patchwork Fri Dec 1 07:34:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 81073 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7345C385C414 for ; Fri, 1 Dec 2023 07:34:58 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D1D293858C62 for ; Fri, 1 Dec 2023 07:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1D293858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1D293858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701416083; cv=none; b=B+bCf8c6gCVxOij3xoPiaOzphSBVk1M4FV01Sl9vkBdSxdKWw6eQkuF7PvbJ6zPauCmGsxa+6lFNmUrjNC/v/+d1DjkaxHvwdlRWocgYpPMAbLKeokcKwd0kLw8koAY3cdAgDEs9HjJkl28eThNg/oSyIJzuQtAIiU0GEtv4LmA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701416083; c=relaxed/simple; bh=PYiK3fPYtgaNWRVEg2Q76R0JdkvHxUchvujCxozUq9U=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=UXiQI1M6Ne+otoYOrDWR8NX1PJhm5ZFw1XXPxcnr4Z+aSfz8tcdosCSWiWNXMob4n6tkJQqB8qu7Nnp1EAz/cOqLd9TueUyINk6r7DDFSJ/wWRUzzWZM2dpAE9QDBAA+I4n6yYfLdQt2DD/8xZav6L9zXkql5zmknBN3tY6A7m0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701416081; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=Zvc1T6FaGdA4cpVeUI4T+7OEG6AkKj93DYoj9KBxCgo=; b=g8bfHX5wyKPMlfbyyc7r4FCxTEkLx8+w+HefmVK87GPR59JwZKTyG20/cfIblJoC5b6XKS 2di/QulOm+tImH+5Z586ptuPFGR3XynEC0YsVecRumPto+djDgBbrU+AmSsacYg6cHTYJ7 82NgRxTauBDCwKKSJ5gYCxrF+pIIbXM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-frjP0tjTOjWYwXp5vA3UhA-1; Fri, 01 Dec 2023 02:34:39 -0500 X-MC-Unique: frjP0tjTOjWYwXp5vA3UhA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80E9B185A784; Fri, 1 Dec 2023 07:34:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 44B5F40C6EBB; Fri, 1 Dec 2023 07:34:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3B17YatU540163 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 1 Dec 2023 08:34:37 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3B17YZgi540162; Fri, 1 Dec 2023 08:34:35 +0100 Date: Fri, 1 Dec 2023 08:34:35 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] lower-bitint: Fix ICE on bitint-39.c Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Hi! torture/bitint-39.c ICEs with -O1; the problem is that the finish_arith_overflow code in one spot replaces use_stmt with an assignment or cast, but if unlucky and m_gsi iterator is the same statement, when the code later tree clobber = build_clobber (TREE_TYPE (var), CLOBBER_EOL); g = gimple_build_assign (var, clobber); gsi_insert_after (&m_gsi, g, GSI_SAME_STMT); it will insert after iterator which contains already replaced statement and that causes the gimple chain corruption. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2023-12-01 Jakub Jelinek * gimple-lower-bitint.cc (bitint_large_huge::finish_arith_overflow): When replacing use_stmt which is gsi_stmt (m_gsi), update m_gsi to the new statement. Jakub --- gcc/gimple-lower-bitint.cc.jj 2023-11-30 10:57:40.095555940 +0100 +++ gcc/gimple-lower-bitint.cc 2023-11-30 12:46:34.715093396 +0100 @@ -3682,6 +3682,8 @@ bitint_large_huge::finish_arith_overflow else g = gimple_build_assign (lhs2, NOP_EXPR, ovf); gsi_replace (&gsi, g, true); + if (gsi_stmt (m_gsi) == use_stmt) + m_gsi = gsi_for_stmt (g); break; } }