| Message ID | ZPbZGGqmV8L+/rni@tucnak |
|---|---|
| State | New |
| Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org>
X-Original-To: patchwork@sourceware.org
Delivered-To: patchwork@sourceware.org
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 86B09385843A
for <patchwork@sourceware.org>; Tue, 5 Sep 2023 07:31:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86B09385843A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
s=default; t=1693899067;
bh=hzyIxr2s6C8g8/cC/P4IuedumbMkis+G/oDxAFIX8uA=;
h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:
List-Post:List-Help:List-Subscribe:From:Reply-To:From;
b=sv6CHEWEsslTpGYoICxQasULwTtFp7c67J/le2qaNFmErlk54qZqzHzNqB4nAcEIx
IjpTDTu5Z+IABS4yEFzHCIrYwCD6Tag/oticR/Xbndbe4N3CcHFwUI3gnhMC76uW9m
sv6VPPLHwyk5fXDarALBRMci6bdL3opkEXoQd8mo=
X-Original-To: gcc-patches@gcc.gnu.org
Delivered-To: gcc-patches@gcc.gnu.org
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by sourceware.org (Postfix) with ESMTPS id A1BF7385842E
for <gcc-patches@gcc.gnu.org>; Tue, 5 Sep 2023 07:30:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1BF7385842E
Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])
by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-688-50o6RJiMOmSTJEZ0ddW9xw-1; Tue, 05 Sep 2023 03:30:34 -0400
X-MC-Unique: 50o6RJiMOmSTJEZ0ddW9xw-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com
[10.11.54.8])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54D333C11A04;
Tue, 5 Sep 2023 07:30:34 +0000 (UTC)
Received: from tucnak.zalov.cz (unknown [10.45.224.16])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B15BC02996;
Tue, 5 Sep 2023 07:30:33 +0000 (UTC)
Received: from tucnak.zalov.cz (localhost [127.0.0.1])
by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3857UWLu2877006
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
Tue, 5 Sep 2023 09:30:32 +0200
Received: (from jakub@localhost)
by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3857UW262877005;
Tue, 5 Sep 2023 09:30:32 +0200
Date: Tue, 5 Sep 2023 09:30:32 +0200
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH 18/12] Handle BITINT_TYPE in build_{,
minus_}one_cst [PR102989]
Message-ID: <ZPbZGGqmV8L+/rni@tucnak>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
From: Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org>
Reply-To: Jakub Jelinek <jakub@redhat.com>
Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org
Sender: "Gcc-patches"
<gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org>
|
| Series |
None
|
|
Commit Message
Jakub Jelinek
Sept. 5, 2023, 7:30 a.m. UTC
Hi! Recent match.pd changes trigger ICE in build_minus_one_cst, apparently I forgot to handle BITINT_TYPE in these (while I've handled it in build_zero_cst). Will commit as obvious together with the rest of the series when the last patches are approved. 2023-09-05 Jakub Jelinek <jakub@redhat.com> PR c/102989 * tree.cc (build_one_cst, build_minus_one_cst): Handle BITINT_TYPE like INTEGER_TYPE. Jakub
Comments
On Tue, Sep 5, 2023 at 12:31 AM Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Hi! > > Recent match.pd changes trigger ICE in build_minus_one_cst, apparently > I forgot to handle BITINT_TYPE in these (while I've handled it in > build_zero_cst). > > Will commit as obvious together with the rest of the series when the last > patches are approved. I assume there was a testcase that will be added when _BitInt front-end support gets added. Thanks, Andrew > > 2023-09-05 Jakub Jelinek <jakub@redhat.com> > > PR c/102989 > * tree.cc (build_one_cst, build_minus_one_cst): Handle BITINT_TYPE > like INTEGER_TYPE. > > --- gcc/tree.cc.jj 2023-09-04 09:45:33.444059843 +0200 > +++ gcc/tree.cc 2023-09-05 08:57:31.420059962 +0200 > @@ -2546,7 +2546,7 @@ build_one_cst (tree type) > { > case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE: > case POINTER_TYPE: case REFERENCE_TYPE: > - case OFFSET_TYPE: > + case OFFSET_TYPE: case BITINT_TYPE: > return build_int_cst (type, 1); > > case REAL_TYPE: > @@ -2599,7 +2599,7 @@ build_minus_one_cst (tree type) > { > case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE: > case POINTER_TYPE: case REFERENCE_TYPE: > - case OFFSET_TYPE: > + case OFFSET_TYPE: case BITINT_TYPE: > return build_int_cst (type, -1); > > case REAL_TYPE: > > Jakub >
On Tue, Sep 05, 2023 at 02:42:39PM -0700, Andrew Pinski wrote: > On Tue, Sep 5, 2023 at 12:31 AM Jakub Jelinek via Gcc-patches > > Recent match.pd changes trigger ICE in build_minus_one_cst, apparently > > I forgot to handle BITINT_TYPE in these (while I've handled it in > > build_zero_cst). > > > > Will commit as obvious together with the rest of the series when the last > > patches are approved. > > I assume there was a testcase that will be added when _BitInt > front-end support gets added. After working around the build_nonstandard_integer_type in match.pd (in that case the single one, I know there are some others) the ICE was on dg-torture/bitint-42.c at -O1/-Os, so no new testcase needs to be added. Jakub
--- gcc/tree.cc.jj 2023-09-04 09:45:33.444059843 +0200 +++ gcc/tree.cc 2023-09-05 08:57:31.420059962 +0200 @@ -2546,7 +2546,7 @@ build_one_cst (tree type) { case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE: case POINTER_TYPE: case REFERENCE_TYPE: - case OFFSET_TYPE: + case OFFSET_TYPE: case BITINT_TYPE: return build_int_cst (type, 1); case REAL_TYPE: @@ -2599,7 +2599,7 @@ build_minus_one_cst (tree type) { case INTEGER_TYPE: case ENUMERAL_TYPE: case BOOLEAN_TYPE: case POINTER_TYPE: case REFERENCE_TYPE: - case OFFSET_TYPE: + case OFFSET_TYPE: case BITINT_TYPE: return build_int_cst (type, -1); case REAL_TYPE: