Message ID | ZBAoNGDJPNd069B5@tucnak |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 173873858C2F for <patchwork@sourceware.org>; Tue, 14 Mar 2023 07:55:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 173873858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678780502; bh=TaIWIqoyyAedghmUzAoQHyMgu00U7iuSl7Dz+mnguVA=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hK28FUZO6S6ci70sqM2joiZtKvQjj3SmQgRJgJFslnjsOMMxShCs8qtNkKK1CJiUw fRw7OyIjtl1CFKebbXxros24qrwC/kCmqAuJNo6y1IWk96tEGTEC9lLHPov8HcS3a/ G/6AixMB2DmwMGiIQgZlB08ZfzpbZVBEYqrvNiAs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 231313858D32 for <gcc-patches@gcc.gnu.org>; Tue, 14 Mar 2023 07:54:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 231313858D32 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-450-akE2SVNfNO-fjJLs2L19bw-1; Tue, 14 Mar 2023 03:54:32 -0400 X-MC-Unique: akE2SVNfNO-fjJLs2L19bw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27D1E101A521 for <gcc-patches@gcc.gnu.org>; Tue, 14 Mar 2023 07:54:32 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAFD5140EBF4; Tue, 14 Mar 2023 07:54:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32E7sTOT606962 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 14 Mar 2023 08:54:30 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32E7sTnV606961; Tue, 14 Mar 2023 08:54:29 +0100 Date: Tue, 14 Mar 2023 08:54:28 +0100 To: Jason Merrill <jason@redhat.com> Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] testsuite: Fix up g++.dg/cpp2a/concepts-lambda3.C [PR108972] Message-ID: <ZBAoNGDJPNd069B5@tucnak> References: <20230310184938.2531120-1-jason@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230310184938.2531120-1-jason@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jakub Jelinek <jakub@redhat.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
testsuite: Fix up g++.dg/cpp2a/concepts-lambda3.C [PR108972]
|
|
Commit Message
Jakub Jelinek
March 14, 2023, 7:54 a.m. UTC
Hi! On Fri, Mar 10, 2023 at 01:49:38PM -0500, Jason Merrill via Gcc-patches wrote: > gcc/testsuite/ChangeLog: > > * g++.dg/cpp2a/concepts-lambda3.C: Run at lower std levels, > but expect errors. I'm seeing +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++11 compilation failed to produce executable +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++14 compilation failed to produce executable +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++17 compilation failed to produce executable +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++98 compilation failed to produce executable with this change, and if I test with GXX_TESTSUITE_STDS=98,11,14,17,20,2b make check-g++ -k RUNTESTFLAGS="--target_board=unix\{-m32,-m64,-m64/-fconcepts\} dg.exp=concepts-lambda3.C" I see even FAILs for the -fconcepts case, so apparently even -std=c++17 -fconcepts isn't enough to make it compile without errors. The following patch will expect errors for all of c++17_down and will make the test dg-do compile for that case too, such that the UNRESOLVED stuff is gone. Ok for trunk? 2023-03-14 Jakub Jelinek <jakub@redhat.com> PR c++/108972 * g++.dg/cpp2a/concepts-lambda3.C: Use dg-do run only for c++20, for c++17_down dg-do compile. Expect dg-excess-errors for c++17_down rather than ! concepts. Jakub
Comments
On 3/14/23 03:54, Jakub Jelinek wrote: > Hi! > > On Fri, Mar 10, 2023 at 01:49:38PM -0500, Jason Merrill via Gcc-patches wrote: >> gcc/testsuite/ChangeLog: >> >> * g++.dg/cpp2a/concepts-lambda3.C: Run at lower std levels, >> but expect errors. > > I'm seeing > +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++11 compilation failed to produce executable > +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++14 compilation failed to produce executable > +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++17 compilation failed to produce executable > +UNRESOLVED: g++.dg/cpp2a/concepts-lambda3.C -std=c++98 compilation failed to produce executable > with this change, and if I test with > GXX_TESTSUITE_STDS=98,11,14,17,20,2b make check-g++ -k RUNTESTFLAGS="--target_board=unix\{-m32,-m64,-m64/-fconcepts\} dg.exp=concepts-lambda3.C" > I see even FAILs for the -fconcepts case, so apparently even -std=c++17 > -fconcepts isn't enough to make it compile without errors. > > The following patch will expect errors for all of c++17_down and will > make the test dg-do compile for that case too, such that the UNRESOLVED > stuff is gone. > > Ok for trunk? OK. > 2023-03-14 Jakub Jelinek <jakub@redhat.com> > > PR c++/108972 > * g++.dg/cpp2a/concepts-lambda3.C: Use dg-do run only for c++20, > for c++17_down dg-do compile. Expect dg-excess-errors for c++17_down > rather than ! concepts. > > --- gcc/testsuite/g++.dg/cpp2a/concepts-lambda3.C.jj 2023-03-13 23:01:42.082959131 +0100 > +++ gcc/testsuite/g++.dg/cpp2a/concepts-lambda3.C 2023-03-14 08:48:12.834128044 +0100 > @@ -1,5 +1,6 @@ > -// { dg-do run } > -// { dg-excess-errors "" { target { ! concepts } } } (PR108972) > +// { dg-do run { target c++20 } } > +// { dg-do compile { target c++17_down } } > +// { dg-excess-errors "" { target { c++17_down } } } (PR108972) > > template<typename T> > concept C1 = __is_same_as(T, int) > > > Jakub >
--- gcc/testsuite/g++.dg/cpp2a/concepts-lambda3.C.jj 2023-03-13 23:01:42.082959131 +0100 +++ gcc/testsuite/g++.dg/cpp2a/concepts-lambda3.C 2023-03-14 08:48:12.834128044 +0100 @@ -1,5 +1,6 @@ -// { dg-do run } -// { dg-excess-errors "" { target { ! concepts } } } (PR108972) +// { dg-do run { target c++20 } } +// { dg-do compile { target c++17_down } } +// { dg-excess-errors "" { target { c++17_down } } } (PR108972) template<typename T> concept C1 = __is_same_as(T, int)