Message ID | Z35Ggbdz9r2AZnZe@tucnak |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1887A3858D21 for <patchwork@sourceware.org>; Wed, 8 Jan 2025 09:35:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1887A3858D21 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=heYBmqrn X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 3676A3858D28 for <gcc-patches@gcc.gnu.org>; Wed, 8 Jan 2025 09:34:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3676A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3676A3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736328846; cv=none; b=p//rDDopHuSYQIiQvHlnRtcPDI48/VDESHli3lnfrP9GLK9T0Z6iosmD78CG7QDqRjrw93wrs5rHjjw32kPmAneBl2zj8WapW4MclqS+weeZ7xXHvx2eO6SF8Y4T/RVdeu+UuqEfH+/phrNb6MstOeQeUdbWwgfY1vDxq/W9ORo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736328846; c=relaxed/simple; bh=N+jEYTDWg75kbIIRck3UOycirUYfVV/oUvqq44aKXc4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=p0Xo+57w0kQeA6qA3iual6Nu/eAd6NtSuv6m8JwkiB1sQf11Ink7a1ge0PGEV5cIjNVo3V8HgNVprYYx0Von770533XLQSWB9b/HRkhbwU+QdMsoSs146Kwq95uf32A4lGsx885seFJ/xOxDpheuX8SIrGXcpCJrfmsUnQ9bKMc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3676A3858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736328846; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=b3UL50WPDLUYaVoNGo98pjWiItzFjJWDZASymcqo4B8=; b=heYBmqrnl8627RBu5jNTHtlRBT/PKYhNODDuNF07yuTF02I00R/yJXJssk6rSC//UOkQkT pZ5WcuHJpn1uLzMtE/tgQh/swpQzf0gpyjnJSgkLMHGHdmjNEGuOhGms+3q8VwSQjhcGtH MyaTDIM/eWAX1H+hNDGCmNZ5dK+h8Cs= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-rzlVy8o3PZ6VWHY6tHMuGQ-1; Wed, 08 Jan 2025 04:34:00 -0500 X-MC-Unique: rzlVy8o3PZ6VWHY6tHMuGQ-1 X-Mimecast-MFC-AGG-ID: rzlVy8o3PZ6VWHY6tHMuGQ Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FCC7195609F; Wed, 8 Jan 2025 09:33:59 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9224D195608D; Wed, 8 Jan 2025 09:33:57 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 5089XsPv3357571 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 8 Jan 2025 10:33:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 5089Xshg3357570; Wed, 8 Jan 2025 10:33:54 +0100 Date: Wed, 8 Jan 2025 10:33:53 +0100 From: Jakub Jelinek <jakub@redhat.com> To: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: [PATCH] fortran: Bump MOD_VERSION to "16" [PR118337] Message-ID: <Z35Ggbdz9r2AZnZe@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NL1noEtcSa71KNZxGnijN2iGQUDAJwJ4Lb2t3HklZtw_1736328839 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Reply-To: Jakub Jelinek <jakub@redhat.com> Errors-To: gcc-patches-bounces~patchwork=sourceware.org@gcc.gnu.org |
Series |
fortran: Bump MOD_VERSION to "16" [PR118337]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | success | Build passed |
Commit Message
Jakub Jelinek
Jan. 8, 2025, 9:33 a.m. UTC
Hi! As mentioned in the PR, there is a *.mod incompatibility between GCC 14 and GCC 15, at least when using iso_c_binding or iso_fortran_env intrinsic modules, because new entries have been added to those modules in the middle, causing changes in the constants emitted in the *.mod files. Also, I fear modules produced with GCC 15 with -funsigned and using UNSIGNED in the modules will be unreadable by GCC 14. The following patch just bumps MOD_VERSION for this. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Note, I'll post incrementally a WIP on accepting also MOD_VERSION "15", but it is unfinished. 2025-01-08 Jakub Jelinek <jakub@redhat.com> PR fortran/118337 * module.cc (MOD_VERSION): Bump to "16". Jakub
Comments
On Wed, Jan 08, 2025 at 10:33:53AM +0100, Jakub Jelinek wrote: > > As mentioned in the PR, there is a *.mod incompatibility between GCC 14 and > GCC 15, at least when using iso_c_binding or iso_fortran_env intrinsic > modules, because new entries have been added to those modules in the middle, > causing changes in the constants emitted in the *.mod files. > > Also, I fear modules produced with GCC 15 with -funsigned and using UNSIGNED > in the modules will be unreadable by GCC 14. > > The following patch just bumps MOD_VERSION for this. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > Yes. While working on f_c_string(), it never occurred to me that the version number should have been bumped. Thanks for the sleuthing you've done so far.
Am 08.01.25 um 19:18 schrieb Steve Kargl: > While working on f_c_string(), it never occurred to me > that the version number should have been bumped. Thanks > for the sleuthing you've done so far. Same for me! Best regards Thomas
--- gcc/fortran/module.cc.jj 2025-01-02 11:47:31.697201637 +0100 +++ gcc/fortran/module.cc 2025-01-07 21:41:46.866494776 +0100 @@ -84,7 +84,7 @@ along with GCC; see the file COPYING3. /* Don't put any single quote (') in MOD_VERSION, if you want it to be recognized. */ -#define MOD_VERSION "15" +#define MOD_VERSION "16" /* Structure that describes a position within a module file. */