From patchwork Wed Mar 9 09:59:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 51811 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 252113858018 for ; Wed, 9 Mar 2022 09:59:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 252113858018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1646819984; bh=Xjd0Igb2yMZBRA0dvaUUUcc9BdSoM0aeNR9KYNFIkl4=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JMcN1u06g5dN/BeXnpAv1MzFfhaLrvWc0M52wePkmcRvI9Pitj8ShKScyydd7BK65 oHDcNu/1jXUAHjQjQV1c3WrtXMR82Q+EBaYGe6lnHcsxv/O5U/38/iTOiuWAiPufPE 15/VwUT1gumCj444xdwRrG6Oc0s+h9vVAaPXgz+4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5156F3858D28 for ; Wed, 9 Mar 2022 09:59:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5156F3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-474-RykA8jVUM8mgI6H9UfUx7Q-1; Wed, 09 Mar 2022 04:59:10 -0500 X-MC-Unique: RykA8jVUM8mgI6H9UfUx7Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B7A0180FD71; Wed, 9 Mar 2022 09:59:09 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12DDF7FD0F; Wed, 9 Mar 2022 09:59:08 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 2299x5ul3182704 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Mar 2022 10:59:06 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 2299x4gM3182703; Wed, 9 Mar 2022 10:59:04 +0100 Date: Wed, 9 Mar 2022 10:59:04 +0100 To: Richard Biener Subject: [PATCH] x86, v2: Define LIBGCC2_UNWIND_ATTRIBUTE on ia32 [PR104781] Message-ID: References: <20220307150628.68146-1-hjl.tools@gmail.com> <6ropo03n-18ns-p21-p717-oo9r6nss789p@fhfr.qr> MIME-Version: 1.0 In-Reply-To: <6ropo03n-18ns-p21-p717-oo9r6nss789p@fhfr.qr> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" On Wed, Mar 09, 2022 at 08:18:38AM +0100, Richard Biener wrote: > I wonder if this is a good case for general-regs-only instead? At > least no-sse cannot be functionally equivalent (since then we would > not have needed general-regs-only ...). I think general-regs-only is approx. equivalent to no-mmx,no-sse, we don't really need/want mmx in the unwinder I guess. The following seems to work fine too, regtested with -O2 -msse2 -mfpmath=sse -mstackrealign in {C,CXX,XC,TC}FLAGS on i686-linux (where without the patch it fails to build). 2022-03-09 Jakub Jelinek PR target/104781 * config/i386/i386.h (LIBGCC2_UNWIND_ATTRIBUTE): Define for ia32. Jakub --- gcc/config/i386/i386.h.jj 2022-02-25 21:59:29.356291326 +0100 +++ gcc/config/i386/i386.h 2022-03-09 10:00:38.242376504 +0100 @@ -2848,6 +2848,12 @@ extern enum attr_cpu ix86_schedule; #define NUM_X86_64_MS_CLOBBERED_REGS 12 #endif +/* __builtin_eh_return can't handle stack realignment, so restrict to + general regs in 32-bit libgcc functions that call it. */ +#ifndef __x86_64__ +#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("general-regs-only"))) +#endif + /* Local variables: version-control: t