From patchwork Thu Feb 2 14:30:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 64150 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB6F63858C30 for ; Thu, 2 Feb 2023 14:31:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB6F63858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675348270; bh=VvrPCKnEwh7C1F9cqnIVmkcS+c/7ODQgiHavdrFK7zM=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=FJefy41fK/9lSFj17B2YOF2gAGs64fC1hQfRyJDY7/feAIswGfVkHReR34V7MPU2F t7XcJeJKHGqNgwiFOG5nbexrQnshmj40cjg6DMbFM5uRSZZSJU1cw3BmlQxtVxCTHx VTJeyPI9EgPdg4mqo0eXNrFB0C35h2YLfKlgiWg8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D71233858C60 for ; Thu, 2 Feb 2023 14:30:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D71233858C60 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-113-79zrTxgVNQCS4Otg49kYOA-1; Thu, 02 Feb 2023 09:30:35 -0500 X-MC-Unique: 79zrTxgVNQCS4Otg49kYOA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFEFE85A588; Thu, 2 Feb 2023 14:30:34 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76631C15BA0; Thu, 2 Feb 2023 14:30:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 312EUUGl1324583 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 2 Feb 2023 15:30:31 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 312EUTMO1324582; Thu, 2 Feb 2023 15:30:29 +0100 Date: Thu, 2 Feb 2023 15:30:29 +0100 To: Richard Biener , Patrick Palka Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] tree: Use comdat tree_code_{type,length} even for C++11/14 [PR108634] Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! The recent change to undo the tree_code_type/tree_code_length excessive duplication apparently broke building the Linux kernel plugin. While it is certainly desirable that GCC plugins are built with the same compiler as GCC has been built and with the same options (at least the important ones), it might be hard to arrange that, e.g. if gcc is built using a cross-compiler but the plugin then built natively, or GCC isn't bootstrapped for other reasons, or just as in the kernel case they were building the plugin with -std=gnu++11 while the bootstrapped GCC has been built without any such option and so with whatever the compiler defaulted to. For C++17 and later tree_code_{type,length} are UNIQUE symbols with those assembler names, while for C++11/14 they were _ZL14tree_code_type and _ZL16tree_code_length. The following patch uses a comdat var for those even for C++11/14 as suggested by Maciej Cencora. Relying on weak attribute is not an option because not all hosts support it and there are non-GNU system compilers. While we could use it unconditionally, I think defining a template just to make it comdat is weird, and the compiler itself is always built with the same compiler. Plugins, being separate shared libraries, will have a separate copy of the arrays if they are ODR-used in the plugin, so there is not a big deal if e.g. cc1plus uses tree_code_type while plugin uses _ZN19tree_code_type_tmplILi0EE14tree_code_typeE or vice versa. Tested in non-bootstrapped build with both -std=gnu++17 and -std=gnu++11, ok for trunk if it passes full bootstrap/regtest? 2023-02-02 Jakub Jelinek PR plugins/108634 * tree-core.h (tree_code_type, tree_code_length): For C++11 or C++14, don't declare as extern const arrays. (tree_code_type_tmpl, tree_code_length_tmpl): New types with static constexpr member arrays for C++11 or C++14. * tree.h (TREE_CODE_CLASS): For C++11 or C++14 use tree_code_type_tmpl <0>::tree_code_type instead of tree_code_type. (TREE_CODE_LENGTH): For C++11 or C++14 use tree_code_length_tmpl <0>::tree_code_length instead of tree_code_length. * tree.cc (tree_code_type, tree_code_length): Remove. Jakub --- gcc/tree-core.h.jj 2023-01-27 10:51:27.575399052 +0100 +++ gcc/tree-core.h 2023-02-02 15:06:05.048665279 +0100 @@ -2285,19 +2285,27 @@ struct floatn_type_info { extern bool tree_contains_struct[MAX_TREE_CODES][64]; /* Class of tree given its code. */ -#if __cpp_inline_variables >= 201606L #define DEFTREECODE(SYM, NAME, TYPE, LENGTH) TYPE, #define END_OF_BASE_TREE_CODES tcc_exceptional, +#if __cpp_inline_variables < 201606L +template +struct tree_code_type_tmpl { + static constexpr enum tree_code_class tree_code_type[] = { +#include "all-tree.def" + }; +}; + +template +constexpr enum tree_code_class tree_code_type_tmpl::tree_code_type[]; +#else constexpr inline enum tree_code_class tree_code_type[] = { #include "all-tree.def" }; +#endif #undef DEFTREECODE #undef END_OF_BASE_TREE_CODES -#else -extern const enum tree_code_class tree_code_type[]; -#endif /* Each tree code class has an associated string representation. These must correspond to the tree_code_class entries. */ @@ -2305,18 +2313,27 @@ extern const char *const tree_code_class /* Number of argument-words in each kind of tree-node. */ -#if __cpp_inline_variables >= 201606L #define DEFTREECODE(SYM, NAME, TYPE, LENGTH) LENGTH, #define END_OF_BASE_TREE_CODES 0, + +#if __cpp_inline_variables < 201606L +template +struct tree_code_length_tmpl { + static constexpr unsigned char tree_code_length[] = { +#include "all-tree.def" + }; +}; + +template +constexpr unsigned char tree_code_length_tmpl::tree_code_length[]; +#else constexpr inline unsigned char tree_code_length[] = { #include "all-tree.def" }; +#endif #undef DEFTREECODE #undef END_OF_BASE_TREE_CODES -#else -extern const unsigned char tree_code_length[]; -#endif /* Vector of all alias pairs for global symbols. */ extern GTY(()) vec *alias_pairs; --- gcc/tree.h.jj 2023-01-27 20:09:16.183970583 +0100 +++ gcc/tree.h 2023-02-02 14:37:17.255004291 +0100 @@ -177,7 +177,12 @@ code_helper::is_builtin_fn () const #define TREE_CODE_CLASS_STRING(CLASS)\ tree_code_class_strings[(int) (CLASS)] +#if __cpp_inline_variables < 201606L +#define TREE_CODE_CLASS(CODE) \ + tree_code_type_tmpl <0>::tree_code_type[(int) (CODE)] +#else #define TREE_CODE_CLASS(CODE) tree_code_type[(int) (CODE)] +#endif /* Nonzero if NODE represents an exceptional code. */ @@ -271,7 +276,12 @@ code_helper::is_builtin_fn () const #define EXPR_P(NODE) IS_EXPR_CODE_CLASS (TREE_CODE_CLASS (TREE_CODE (NODE))) +#if __cpp_inline_variables < 201606L +#define TREE_CODE_LENGTH(CODE) \ + tree_code_length_tmpl <0>::tree_code_length[(int) (CODE)] +#else #define TREE_CODE_LENGTH(CODE) tree_code_length[(int) (CODE)] +#endif /* Helper macros for math builtins. */ --- gcc/tree.cc.jj 2023-02-02 10:54:44.302473853 +0100 +++ gcc/tree.cc 2023-02-02 14:20:58.712251654 +0100 @@ -74,34 +74,6 @@ along with GCC; see the file COPYING3. #include "asan.h" #include "ubsan.h" -#if __cpp_inline_variables < 201606L -/* Tree code classes. */ - -#define DEFTREECODE(SYM, NAME, TYPE, LENGTH) TYPE, -#define END_OF_BASE_TREE_CODES tcc_exceptional, - -const enum tree_code_class tree_code_type[] = { -#include "all-tree.def" -}; - -#undef DEFTREECODE -#undef END_OF_BASE_TREE_CODES - -/* Table indexed by tree code giving number of expression - operands beyond the fixed part of the node structure. - Not used for types or decls. */ - -#define DEFTREECODE(SYM, NAME, TYPE, LENGTH) LENGTH, -#define END_OF_BASE_TREE_CODES 0, - -const unsigned char tree_code_length[] = { -#include "all-tree.def" -}; - -#undef DEFTREECODE -#undef END_OF_BASE_TREE_CODES -#endif - /* Names of tree components. Used for printing out the tree and error messages. */ #define DEFTREECODE(SYM, NAME, TYPE, LEN) NAME,