Activate gcc builder problem emails (Was: [PATCH v2] genmultilib: Add sanity check)

Message ID Y3wDPIFQikJu2Opz@wildebeest.org
State New
Headers
Series Activate gcc builder problem emails (Was: [PATCH v2] genmultilib: Add sanity check) |

Commit Message

Mark Wielaard Nov. 21, 2022, 11:01 p.m. UTC
  Hi Christophe,

On Mon, Nov 21, 2022 at 01:35:34PM +0100, Christophe Lyon wrote:
> On 11/21/22 13:32, Mark Wielaard wrote:
> > > I've just sent a fix:
> > > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606887.html
> > > 
> > > Hopefully that one is right
> > 
> > The buildbot gcc builds are turning green again!
> > https://builder.sourceware.org/buildbot/#/changes/13736
> 
> Good! I didn't imagine the feedback would be so fast :-)
> 
> BTW, I don't remember receiving an email from the buildbot after the
> breakage, does it send such emails for binutils/gdb only?

You are right, we didn't seem to have any problem report emails for
the gcc builds. The attached (pushed) patch activates email reports
for the quick gcc builders. Whenever they fail the patch author should
get an email now. Also it will now sent email to gcc-testresults if a
build starts failing or becomes successful again.

Note that we don't have good reporting for the full gcc builders
yet. We don't have regression detection yet, so we can only see that
the full testsuite passes or fails. All results are put into the
bunsen database though.

Cheers,

Mark
  

Patch

From adbdb81530f97880facb942afe14781c1006e283 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Mon, 21 Nov 2022 23:47:53 +0100
Subject: [PATCH] Add mail notifiers for gcc builds

Change gcc_fedrawhide_x86_64_builder tag from "gcc" to "gcc-full"
like other "full" builders (debian-amd64, ubuntu-armhf and ubuntu-arm64).

Add mail notifiers for builders tagged "gcc". One to sent email to
patch author if a new problem (failed build) appears. Another to
sent email to gcc-testresults whenever a build changes from success
to failed or the other way around.
---
 builder/master.cfg | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index 61bf4f1..b25731d 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -2888,7 +2888,7 @@  gcc_fedrawhide_x86_64_builder = util.BuilderConfig(
         name="gcc-fedrawhide-x86_64",
         collapseRequests=True,
         workernames=["fedrawhide-x86_64"],
-        tags=["gcc", "fedora", "x86_64"],
+        tags=["gcc-full", "fedora", "x86_64"],
         factory=gcc_factory)
 c['builders'].append(gcc_fedrawhide_x86_64_builder)
 
@@ -3857,6 +3857,27 @@  mn_elfutils_try = reporters.MailNotifier(
         generators=[generator_elfutils_try])
 c['services'].append(mn_elfutils_try)
 
+# Problem report for the whole gcc tagged builder set
+# Goes to patch author if a new problem appears
+generator_gcc = reporters.BuildSetStatusGenerator(
+        mode=('problem',), tags=['gcc'])
+mn_gcc = reporters.MailNotifier(
+        fromaddr="builder@sourceware.org",
+        sendToInterestedUsers=True,
+        generators=[generator_gcc])
+c['services'].append(mn_gcc)
+
+# Change report for the whole gcc tagged builder set
+# Goes to the mailinglist if a builder result changes
+generator_gcc_change = reporters.BuildSetStatusGenerator(
+        mode=('change',), tags=['gcc'])
+mn_gcc_change = reporters.MailNotifier(
+        fromaddr="builder@sourceware.org",
+        sendToInterestedUsers=False,
+        extraRecipients=['gcc-testresults@gcc.gnu.org'],
+        generators=[generator_gcc_change])
+c['services'].append(mn_gcc_change)
+
 # Problem report for the whole gccrust tagged builder set
 generator_gccrust = reporters.BuildSetStatusGenerator(
         mode=('problem',), tags=['gccrust'])
-- 
2.30.2