[8/8,Arm] Introduce multilibs for PACBTI target feature. [Was RE: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature.]
Message ID | PAXPR08MB707593E3D8C45E0FD6887E5BEA869@PAXPR08MB7075.eurprd08.prod.outlook.com |
---|---|
State | Superseded |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F2043858405 for <patchwork@sourceware.org>; Thu, 28 Oct 2021 11:49:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F2043858405 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1635421793; bh=URftdqbrJm4dKFYeoAA0MY13WngBZfQ2QEaCBSZm7uw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Z0HsqfHsHo0BaN8rWtY6PuqIPgey/sZSxO5LNHLxqQqLJYAyJ/YaJzQpnfTlMDRnA 3Z3aul8N7fBUxsgTjKvUHKMXKo3W3ondPy6GwHUSyOTubB9hq+nuPgVtSRjJIhmZnD iV15j/bA587ttri20Iry1c3ldEIULvKUFcktRFUI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2047.outbound.protection.outlook.com [40.107.22.47]) by sourceware.org (Postfix) with ESMTPS id 4C4F0385802E for <gcc-patches@gcc.gnu.org>; Thu, 28 Oct 2021 11:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C4F0385802E Received: from AS8PR04CA0154.eurprd04.prod.outlook.com (2603:10a6:20b:331::9) by VI1PR0802MB2495.eurprd08.prod.outlook.com (2603:10a6:800:b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Thu, 28 Oct 2021 11:43:59 +0000 Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::ef) by AS8PR04CA0154.outlook.office365.com (2603:10a6:20b:331::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Thu, 28 Oct 2021 11:43:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Thu, 28 Oct 2021 11:43:58 +0000 Received: ("Tessian outbound 7b0bcc4a550a:v108"); Thu, 28 Oct 2021 11:43:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from 795b51839364.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE05F8F7-A5D9-466B-B07B-E71B56973B02.1; Thu, 28 Oct 2021 11:43:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 795b51839364.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Oct 2021 11:43:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxV1VJzAlJbqbTxg7+Cq+As2jVPYRNeQIGcsUGW/m1o8XjSe/xiw5zrd2LnJ+fsk2/6udG9xlePST09awnpoH3qnGvkaaCwAL4NAOncg0lasedQHev38IdNNf9SOT5SmNMBgkY44LVo6PhNhNbE6TlE+sYyG8AccxR8Ew1F8VizHkpggBYYR/PSUx5r2ZXzG4VyFkRGU0rsvqb9Av5fKoTyEiX5KA0fs0VfVzSSFTYCc3WHPoLVhzQOMXfVzsMOIGp/Cp/TPd6vAGGizjkeuSQyzDlPFxKY25nQgAlGvzTuOorHEiswDEDRTo7gSBTgLNsvqcylhe50RYQClXIRVNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=URftdqbrJm4dKFYeoAA0MY13WngBZfQ2QEaCBSZm7uw=; b=CDhpi+joAgsHsG+2kBTlJnKFDlRdTebTYCRqphSIWJaqHY+VsfA+PovRfZAqlXQ1CKRT45dG28i/XIrX6JdSPvIbb12F7jARZO7bXXsrn/UH6FhpQ9cibIjpR/lhyJ2hbVLHHZJ1PywCO78LxpxCci5RNFX4CX5FYCaTQLXIxDyMBpawZQPP4IpcaEDKTX+1KbilNDsYhbzwfK5ovTVfL7GP8g+fvt6XTWquFg52PQYkBx/njrkd5dRRBSQmK/8PWvYdVqLbQJUHKxWn20ady+PGrmdZzb6W0E/s1hoRLv24xCUpdjsPGB15VyfjKKOxPGmO/yzNQQxihzExVjvxhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from PAXPR08MB7075.eurprd08.prod.outlook.com (2603:10a6:102:201::15) by PAXPR08MB7365.eurprd08.prod.outlook.com (2603:10a6:102:225::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct 2021 11:43:51 +0000 Received: from PAXPR08MB7075.eurprd08.prod.outlook.com ([fe80::9c7f:ad76:ac66:26f2]) by PAXPR08MB7075.eurprd08.prod.outlook.com ([fe80::9c7f:ad76:ac66:26f2%9]) with mapi id 15.20.4628.020; Thu, 28 Oct 2021 11:43:51 +0000 To: Richard Earnshaw <Richard.Earnshaw@arm.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> Subject: [Patch 8/8, Arm, GCC] Introduce multilibs for PACBTI target feature. [Was RE: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature.] Thread-Topic: [Patch 8/8, Arm, GCC] Introduce multilibs for PACBTI target feature. [Was RE: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature.] Thread-Index: AdfL75GOe3NVGpOITZqkCD7MDkZL6A== Date: Thu, 28 Oct 2021 11:43:51 +0000 Message-ID: <PAXPR08MB707593E3D8C45E0FD6887E5BEA869@PAXPR08MB7075.eurprd08.prod.outlook.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ts-tracking-id: 1519EEAF911A4C4C8FE8C853A0A46DF0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 37cafd0b-6d18-47da-80d0-08d99a083ade x-ms-traffictypediagnostic: PAXPR08MB7365:|VI1PR0802MB2495: X-Microsoft-Antispam-PRVS: <VI1PR0802MB24957488FD3E9760DDFCA2D8EA869@VI1PR0802MB2495.eurprd08.prod.outlook.com> x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0v3FbNYbOsCa41BMTcxQXFFwUA20zgh4DSCakbEZfF/nX2k5s0invkrR8pEqni/eV4EggArjTA9Mh3ViIWtLVpuLneMvfzpTUHEYHG5JkvM4DKGdLxJT5KoVaN02ooNbuSg8XbbFoNyZl8n2B4Lbs5O1yadi1mZ5TbxWdQW1fd4PxoTsNyAIh7C4aP/6cn0ISfQlcrjzMHp7Bc4rTxIRwFxK14lUIunXqHp4VxndPqQAI7jER+4nL6bxZ0+lW8cvZ1gxUg9Q+nTrFHXhtSpXSCoQpj3TgOQNhu51s0oWx/QdW6lGCuOg1a/ytpNSDZoBKUbv3SsO55Z3ws5MQTMubc1HM+vp1dQniZOcJ+DplI3oaq6HbRr0h7PWBOJKFFiJpBnEgDgJ/pL4FfucajcCbaYtuWiDg735MsTtfPkhivOnnyaJMuI+zt4ZUkhUW7iB+Unb3mcw9TFTDLexufTUevCX9wWVZk3lfdi1W/aqtPPvVhSMshBYr4lL6xEinpeJXsjdSb8hct57Z1mTO1cDQkTf8W7AfWJC9u+DgCfcIBel3ryMV5jYmnati0LdljCI3DpblZh3pXG/FBxQ9o5oiIP7sy29ZLT6KSLuLAdGiAhWJFsxhNNdRBzXw286dlnZGDmYX+0yB+PcyBWB83Rq/I/Iwt11g6459ZsbyvqELEFU/NNgktEVtkbzEg6BGxEG1dIkW4kt+n6DXjFLAno4zg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB7075.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(53546011)(71200400001)(33656002)(8936002)(38070700005)(508600001)(9686003)(2906002)(83380400001)(6506007)(86362001)(99936003)(64756008)(316002)(66556008)(66476007)(66946007)(4744005)(76116006)(186003)(26005)(110136005)(38100700002)(66446008)(55016002)(5660300002)(7696005)(52536014)(122000001); DIR:OUT; SFP:1101; Content-Type: multipart/mixed; boundary="_002_PAXPR08MB707593E3D8C45E0FD6887E5BEA869PAXPR08MB7075eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7365 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a5e91a2b-8434-47ad-5302-08d99a08365f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GbYpoSrA5P28fmrJjQe17bsMcI32l0WcVgPszKjgEq4Ovfz/v9G49r9b6ytJO5CuWxRwRV41eKTbAUJD2wkdr6D+xJSJall3y3VmAeSsfA3dwMtd1NHm/R1uYIIEPTpMneyOcVt26ULCHMr+7cyfFLQ7IHKpZd8QBlg7TzwktswDx7DooHI+FS9IPXCrWqaplne2f6bkfY4ajsoWLlRXVJbrwCOcngGCZYOiV3Mk4D4yTEPe1sLL8FJK2JrPbpsNOLV8YzJfzYppVLJkWpsqTcpF/ubz27CRDcNgKOTIrLI0hC/WVHP0c1mKKA2VaSg3PwGhfH/yVvBDRUtXKK3tV5Yvav/qFNKRSN2MIn7VQnwy7VJkS7xE4Q/EF/IfTm5ojKS2nfMA7GjWQkg15ttBjzcDa+G9WRT/+QkeRmYMckBVE9Yx73Wqcd1HuRwsCwl4mk3Isqv2zHhOo2DeFYhVuQmBMBBgji2ysWlqBSlX8UtveqUgNkx9KYSC7X/Rno1VzPXjId8pRqkr+bsP3LK1qsva99kpzfJtekE3FykEe9qp/kmaCnf7xqF85FwigkHv3OwGc47zAyMVIgagvx59VU8cPpO18Q/OYgu3Rr6C0WOLFldiWDQjiOvO30AWr/WWkngXKli9x88JJos3ezlBd2GzRakS+3lt4iEbAQQEOSA61fqBlOqJMOUXe1x4hF1YrRCb8QgJC/D6Q2dUzYuqPg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(52536014)(508600001)(70586007)(70206006)(33656002)(2906002)(36860700001)(81166007)(110136005)(99936003)(47076005)(55016002)(316002)(26005)(21480400003)(7696005)(8936002)(86362001)(8676002)(356005)(83380400001)(53546011)(5660300002)(82310400003)(9686003)(186003)(235185007)(6506007)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 11:43:58.7102 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37cafd0b-6d18-47da-80d0-08d99a083ade X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2495 X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Tejas Belagod via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Tejas Belagod <Tejas.Belagod@arm.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
[1/8,Arm,AArch64] Refactor mbranch-protection option parsing and make it common to AArch32 and AArch64 backends. [Was RE: [Patch 2/7, Arm, GCC] Add option -mbranch-protection.]
|
|
Commit Message
Tejas Belagod
Oct. 28, 2021, 11:43 a.m. UTC
> -----Original Message----- > From: Gcc-patches <gcc-patches- > bounces+belagod=gcc.gnu.org@gcc.gnu.org> On Behalf Of Tejas Belagod via > Gcc-patches > Sent: Friday, October 8, 2021 1:19 PM > To: gcc-patches@gcc.gnu.org > Subject: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature. > > Hi, > > This patch adds a multilib for pacbti target feature. > > Tested on arm-none-eabi. OK for trunk? > > 2021-10-04 Tejas Belagod <tbelagod@arm.com> > > gcc/ChangeLog: > > * config/arm/t-rmprofile: Add multilib rules for +pacbti. This patch adds a multilib for pacbti target feature. 2021-10-04 Tejas Belagod <tbelagod@arm.com> gcc/ChangeLog: * config/arm/t-rmprofile: Add multilib rules for +pacbti. Tested the following configurations, OK for trunk? -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp mcmodel=small and tiny aarch64-none-linux-gnu native test and bootstrap Thanks, Tejas.
Comments
On 28/10/2021 12:43, Tejas Belagod via Gcc-patches wrote: > > >> -----Original Message----- >> From: Gcc-patches <gcc-patches- >> bounces+belagod=gcc.gnu.org@gcc.gnu.org> On Behalf Of Tejas Belagod via >> Gcc-patches >> Sent: Friday, October 8, 2021 1:19 PM >> To: gcc-patches@gcc.gnu.org >> Subject: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature. >> >> Hi, >> >> This patch adds a multilib for pacbti target feature. >> >> Tested on arm-none-eabi. OK for trunk? >> >> 2021-10-04 Tejas Belagod <tbelagod@arm.com> >> >> gcc/ChangeLog: >> >> * config/arm/t-rmprofile: Add multilib rules for +pacbti. > > > This patch adds a multilib for pacbti target feature. > > 2021-10-04 Tejas Belagod <tbelagod@arm.com> > > gcc/ChangeLog: > > * config/arm/t-rmprofile: Add multilib rules for +pacbti. > > Tested the following configurations, OK for trunk? > > -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft > -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp > mcmodel=small and tiny > aarch64-none-linux-gnu native test and bootstrap > > Thanks, > Tejas. > I can't decide whether this is too much, or too little. But it doesn't feel right as it is. Ideally we don't want yet another multilib. It would be better to have one of the existing multilib variants made pac/bti safe. And secondly, what about the hand-written assembler files in libgcc? Don't they need updating to be PAC/BTI safe? Also, does this even do what you intend it to do? It adds the PAC/BTI architectural feature, but it doesn't actually enable PAC/BTI in the generated code. R.
Richard Earnshaw via Gcc-patches <gcc-patches@gcc.gnu.org> writes: > On 28/10/2021 12:43, Tejas Belagod via Gcc-patches wrote: >> >>> -----Original Message----- >>> From: Gcc-patches <gcc-patches- >>> bounces+belagod=gcc.gnu.org@gcc.gnu.org> On Behalf Of Tejas Belagod via >>> Gcc-patches >>> Sent: Friday, October 8, 2021 1:19 PM >>> To: gcc-patches@gcc.gnu.org >>> Subject: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature. >>> >>> Hi, >>> >>> This patch adds a multilib for pacbti target feature. >>> >>> Tested on arm-none-eabi. OK for trunk? >>> >>> 2021-10-04 Tejas Belagod <tbelagod@arm.com> >>> >>> gcc/ChangeLog: >>> >>> * config/arm/t-rmprofile: Add multilib rules for +pacbti. >> This patch adds a multilib for pacbti target feature. >> 2021-10-04 Tejas Belagod <tbelagod@arm.com> >> gcc/ChangeLog: >> * config/arm/t-rmprofile: Add multilib rules for +pacbti. >> Tested the following configurations, OK for trunk? >> -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft >> -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp >> mcmodel=small and tiny >> aarch64-none-linux-gnu native test and bootstrap >> Thanks, >> Tejas. >> Hi Richard, > I can't decide whether this is too much, or too little. But it > doesn't feel right as it is. > > Ideally we don't want yet another multilib. It would be better to > have one of the existing multilib variants made pac/bti safe. > > And secondly, what about the hand-written assembler files in libgcc? > Don't they need updating to be PAC/BTI safe? I agree with you, this patch is missing at least bti landing pads in the hand-written assembler files in libgcc. > Also, does this even do what you intend it to do? It adds the PAC/BTI > architectural feature, but it doesn't actually enable PAC/BTI in the > generated code. Good point, I'll fix this too in the upcoming respin. Thanks for reviewing. BR Andrea
Richard Earnshaw via Gcc-patches <gcc-patches@gcc.gnu.org> writes: > On 28/10/2021 12:43, Tejas Belagod via Gcc-patches wrote: >> >>> -----Original Message----- >>> From: Gcc-patches <gcc-patches- >>> bounces+belagod=gcc.gnu.org@gcc.gnu.org> On Behalf Of Tejas Belagod via >>> Gcc-patches >>> Sent: Friday, October 8, 2021 1:19 PM >>> To: gcc-patches@gcc.gnu.org >>> Subject: [Patch 7/7, Arm, GCC] Introduce multilibs for PACBTI target feature. >>> >>> Hi, >>> >>> This patch adds a multilib for pacbti target feature. >>> >>> Tested on arm-none-eabi. OK for trunk? >>> >>> 2021-10-04 Tejas Belagod <tbelagod@arm.com> >>> >>> gcc/ChangeLog: >>> >>> * config/arm/t-rmprofile: Add multilib rules for +pacbti. >> This patch adds a multilib for pacbti target feature. >> 2021-10-04 Tejas Belagod <tbelagod@arm.com> >> gcc/ChangeLog: >> * config/arm/t-rmprofile: Add multilib rules for +pacbti. >> Tested the following configurations, OK for trunk? >> -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft >> -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp >> mcmodel=small and tiny >> aarch64-none-linux-gnu native test and bootstrap >> Thanks, >> Tejas. >> > > I can't decide whether this is too much, or too little. But it > doesn't feel right as it is. > > Ideally we don't want yet another multilib. It would be better to > have one of the existing multilib variants made pac/bti safe. Right, which one do you think we want to pick? Thanks Andrea
diff --git a/gcc/config/arm/t-rmprofile b/gcc/config/arm/t-rmprofile index a6036bf0a5191a3cac3bfbe2329783204d5c3ef4..241bf1939e30ae7890ae332556d33759f538ced5 100644 --- a/gcc/config/arm/t-rmprofile +++ b/gcc/config/arm/t-rmprofile @@ -27,8 +27,8 @@ # Arch and FPU variants to build libraries with -MULTI_ARCH_OPTS_RM = march=armv6s-m/march=armv7-m/march=armv7e-m/march=armv7e-m+fp/march=armv7e-m+fp.dp/march=armv8-m.base/march=armv8-m.main/march=armv8-m.main+fp/march=armv8-m.main+fp.dp/march=armv8.1-m.main+mve -MULTI_ARCH_DIRS_RM = v6-m v7-m v7e-m v7e-m+fp v7e-m+dp v8-m.base v8-m.main v8-m.main+fp v8-m.main+dp v8.1-m.main+mve +MULTI_ARCH_OPTS_RM = march=armv6s-m/march=armv7-m/march=armv7e-m/march=armv7e-m+fp/march=armv7e-m+fp.dp/march=armv8-m.base/march=armv8-m.main/march=armv8-m.main+fp/march=armv8-m.main+fp.dp/march=armv8.1-m.main+mve/march=armv8.1-m.main+pacbti +MULTI_ARCH_DIRS_RM = v6-m v7-m v7e-m v7e-m+fp v7e-m+dp v8-m.base v8-m.main v8-m.main+fp v8-m.main+dp v8.1-m.main+mve v8.1-m.main+pacbti # Base M-profile (no fp) MULTILIB_REQUIRED += mthumb/march=armv6s-m/mfloat-abi=soft @@ -36,6 +36,7 @@ MULTILIB_REQUIRED += mthumb/march=armv7-m/mfloat-abi=soft MULTILIB_REQUIRED += mthumb/march=armv7e-m/mfloat-abi=soft MULTILIB_REQUIRED += mthumb/march=armv8-m.base/mfloat-abi=soft MULTILIB_REQUIRED += mthumb/march=armv8-m.main/mfloat-abi=soft +MULTILIB_REQUIRED += mthumb/march=armv8.1-m.main+pacbti/mfloat-abi=soft # ARMv7e-M with FP (single and double precision variants) MULTILIB_REQUIRED += mthumb/march=armv7e-m+fp/mfloat-abi=hard @@ -93,3 +94,4 @@ MULTILIB_MATCHES += march?armv8-m.main=mlibarch?armv8-m.main MULTILIB_MATCHES += march?armv8-m.main+fp=mlibarch?armv8-m.main+fp MULTILIB_MATCHES += march?armv8-m.main+fp.dp=mlibarch?armv8-m.main+fp.dp MULTILIB_MATCHES += march?armv8.1-m.main+mve=mlibarch?armv8.1-m.main+mve +MULTILIB_MATCHES += march?armv8.1-m.main+pacbti=mlibarch?armv8.1-m.main+pacbti