| Message ID | LO4P265MB5914451ED93CD4B7617714A0804EA@LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM |
|---|---|
| State | Committed |
| Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA7CD385661A for <patchwork@sourceware.org>; Fri, 2 Jun 2023 15:45:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by sourceware.org (Postfix) with ESMTPS id 8AD733858D32; Fri, 2 Jun 2023 15:44:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AD733858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=imgtec.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=imgtec.com Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 352717Wv026268; Fri, 2 Jun 2023 16:44:51 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:content-type:mime-version; s= dk201812; bh=eRGUdsTvOc/wiC6DHkV3AU+Pq20xrLzWOUnoGyqR4W8=; b=j38 VsryWjYCt0XaxLAg/elHDDOyyJGFz/AYVV5jLoV401Md+hxNDoE9XaNebYscXDw6 uFHC20cQx8FmgbvirmKz+MYmcQEGLpUwB2XMqy4oxnQmJbvKQzsSllDPw+PWuG66 ImTH704R2p0wFBO7vno7ShlP2+zE+8889l4QG8tw5g2272+YLyuTHdHY/4BtwFp9 numVP77RqohqT9oQACDM9rqlKQmBDLN1kBWUd27S4NOED/bO/b6+sCj4aSnRJRVd g3y5pw/Ox7zZJMMttbZw+RXGKEveBdzNvcLu0rUmlUx3GeUuAJ/FcPH2fQ9UcJeO ZTKRPRnYM6RSjyUWh4A== Received: from hhmail05.hh.imgtec.org ([217.156.249.195]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 3qwcfw2nj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 02 Jun 2023 16:44:50 +0100 (BST) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL05.hh.imgtec.org (10.100.10.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 2 Jun 2023 16:44:49 +0100 Received: from GBR01-CWL-obe.outbound.protection.outlook.com (104.47.20.54) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 2 Jun 2023 16:44:49 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=btm9W0apnOuE+lv9ZEs+5zFb+1Dlo9IkgM5OF3VxHNGpEE+zePCmjHM+khuA9aB1ZSv9uu3SOhdwaWkqshntbkaPPD3SAXM5knACoc9O60GvAMru3sgERlk4H9AxVaVF/jS1xDPuNiYq3gazvDQr1h4wTzlpKW/JJ1S+Pa7nDyjP4mvB9FKejbmnKdwt0axQDzndzXsgQ4Od7ecBaNOjbu32QWtjuWVidllBKmI0S6joABQdhrOOl5po/I0nKYt5p4onmGnrIdR2jEph1L2yWPTcYVVSiViFEGYs41s0t9rH9WR13znogpN4Ex6sm4snxS9/+Vrw4hS/+mu+LsNAzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eRGUdsTvOc/wiC6DHkV3AU+Pq20xrLzWOUnoGyqR4W8=; b=niLZaIrKBw4icURgwZlH9uwSgyXRN8k3xgk0Wiet8m84Ubc55rmBahrzDPSg7oLRkg+stuiL19oHWPA/SxjWkEEGau0CmBVkaPy+fAsb6dFqcEiVTV60nAVNMGfEekKSDQ+Cv7mUdeJMy/LC6iYmsofUY4Y1jkR0gSkhMox8M2rgE2GClufH2R0LpD3k73eROGNfwS3yJXRXoXgd9e0ihlKaTjNgXVeEDgF7msHG5iQg+KKkPjaFaEF2MqwLf646n1GCTTlmt/LcqrkCdlrBOVTi8EnnPBIrg/9KJYfSn0GMSx0YQuxoRL8qIF8RhKTdH10nknISIsylr5UbY44Lng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eRGUdsTvOc/wiC6DHkV3AU+Pq20xrLzWOUnoGyqR4W8=; b=o3X+jNNJ1T5Qht8MhY2lUMiRaQAkd8inzp0UC7l8p7TvQZer6fJ/ltAhExs8r9BwmeY4vyYhYCCwgNY3BJpBC98DATovPA95828bDKtXfV3sXujFzEI5TYJM0QYg5zQTNNxJIUlucKZxiEEWq7y48K9qAnwIfDOIx9dIr9/3aW0= Received: from LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:29f::11) by CWXP265MB5178.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:195::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.12; Fri, 2 Jun 2023 15:44:48 +0000 Received: from LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM ([fe80::5216:71c2:1971:c383]) by LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM ([fe80::5216:71c2:1971:c383%5]) with mapi id 15.20.6477.010; Fri, 2 Jun 2023 15:44:48 +0000 From: Joseph Faulls <Joseph.Faulls@imgtec.com> To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> CC: "jwakely@redhat.com" <jwakely@redhat.com> Subject: [PATCH] libstdc++: Do not assume existence of char8_t codecvt facet Thread-Topic: [PATCH] libstdc++: Do not assume existence of char8_t codecvt facet Thread-Index: AdmVaSivprw39rGJSv2JDlaDfMrGiw== Date: Fri, 2 Jun 2023 15:44:48 +0000 Message-ID: <LO4P265MB5914451ED93CD4B7617714A0804EA@LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LO4P265MB5914:EE_|CWXP265MB5178:EE_ x-ms-office365-filtering-correlation-id: f3170520-5a64-4b2b-9b1c-08db63804be9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9qt6P1KG6qDhXB+pM6y8O6Ny+rI57BiixGrV7A/Uro9QTvJQkbBEQkQhT4w7HQERUfmCwtQxRHw7atzIllWmkl5Y7RCkJoIU5VI3rc21VqAq29na0Fjl/b57IUL00DOuL8NhDRfO3af75o9JWDKRI2vL8TR9fEbWhu5ByVB/Q//K9Pmybm3Bwfs/Dqj//L3aALZJVIi2wR3aGJ3QxJydOSMM8srAH2G1GVn84kk53whrgcVOpbpHklfSb01ga4bXz93QRlB+cadeqHFTurKaGNqcQdL4zFR78MWKRIrdOB6D1l1znaLrrxKKxsHwzS884mgd2CeBjrDKJtX+/At6ZSmwwIYVElG47aR0FXnu/qgYrgXHHFfLvRlBJ/F1EgI61YeHRc/G9FF6LliPncPul5E/PPG9k6TSFZ6OFJjD9DpC6jh8aqUjUfvnhdSc7VkcksNFa7CMwR4ZtbZvcfXkqudRVkpQD5vYs+JzrsQLojFZLRHm2rkV0yZMK7JcbYl17y2GLwe6G052OUnGj9Bf8B7OX8ZAhHUZx+mN3JCmVxerN/NTaEl7YRBtypWME5hb9AcXyor7EznzSiKOa466yADygY68qlix1nYMb+Co2FTuaSWsOzTZsAsERokJ5zQ8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(366004)(39850400004)(396003)(136003)(346002)(451199021)(52536014)(41300700001)(5660300002)(316002)(86362001)(64756008)(66446008)(66476007)(66556008)(66946007)(38070700005)(76116006)(110136005)(2906002)(4744005)(8676002)(8936002)(478600001)(38100700002)(4326008)(122000001)(33656002)(7696005)(186003)(71200400001)(26005)(6506007)(9686003)(55016003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: JjB/aFzmOW/FYA92i0s4+X4fxp4+pVCuT31ElE1/p83PX1uvEEJgR0nzLaMMQH9gJWg4ulXuf7bvjYQxOKkTKDagPOu+x3A3Vu6LN28soZk25GNMCSyr9pMbCko3bU9SKkA6qxyqCEzIbIHFJhgfvttJNEAYwS81si6QxiKVOeiRMcOYWggxU/OUxWSqnWiZAm85Y+Yl7jZ1rV1J+1ut4h+aHah3mEY0C7Bnkhj8hmwCYj0MKQzJnvcnGGhtySKS9POAoBt3P5wdmIT9OXfR8EDMW1QCYReGI2NUbmV1GdHlXMU1nzmSbslPiYKHtVXHyB+/RgGN5pzV7gM1YjMThRAUNOQq/XYH6hlzOYtmf8O+cJMQSZwvH66ehd03B0ydbICTLTnJpjVnXpqzHCY7gdFjY2oVgMgSsJGfhk6uyfktjDnm+Ue72f2dWi2usNe1KXc+ljB1nqh4IT1SubLqDGx6a6sBVor2pS3vMoFzURVwIF+Erpx4HhAHzoq9THBP3NN+eXvdT+L1e3Szrr4NI+mdXHGb8kIjkkQTS3TuCPqI6YQ8s62gzpdi8jdmdOzS9RHWxTRROI41KM51twhFJgizMs9PFmR0HWRKSm36eag+cY67PFCSpdTyJuwvjZj6Moi4iP6V6bLaANKw8Plvf8pXsIt1FPE/6giKtMG/vAQM4p2w4SrZswH1Bh0XDC/fUvFF2F/W7In7LoMFKtZCFdN0N5dQqEpJZ4/tnGRdnVhTe8cTkNTodl2LV5b381bmlYbprmka3fA2gB/8OZmK3HhwVJOPA9xrjdg+fy2bK/zbHy/sIXgh/HwBQOHQoGQ+Y9ALLFlGMcTRrAnNMW+53IWzlvS+sTI8h0gy/Q9s7cosA9iqqwdWuOj+Lo4TIBPcRfQ14/IUX+VRamAkenMApJewmUKbHb7ZUkab4JirmyHV+tSBAcEx+xEcVks9IjEa782MkpNQyeNaeib3ZnyqzdJPF42k2iAvR0STjLhWvHdhSxra3lZHBZa5crkkp6KGBQHwJEl2tpfU+n0r/DkatZDR1jzziIkWzmKmDHcvCaZGchDkJ+WQGq+kLR549QvycfOAlrbd7oGQ8XfwPZugMcEBTLWk1hkgYv+RQZO0EIP8KEX4F38M1vOjZFQ4cP9O3TWW62QmemoJrAeqwpt0ycKy/yuemPTdX3n4+ltxyZc2ki3hmmd7inulyLZPhFgrpMKSQsj0ZVOC8immJuDjlwgP61w8DxTniT/5rgWNJdqol5cWkdhaLlGImOQsZLlw5kfgucIQkHAsx0GHKwlzfxa4gjePkEbxg0in9/kt14frZC9qzJDi1n2Gv2o1x86n6LdiFUbsgwu5OBW+2emEeHJuGBW/d+t69KoIJyS5zsHXKz6Osu298mvU1epMaRtO9/wpZTNr8zesm2LNu6gQgg/Ed7rHhMbkSl48VjAMJRtV3fDFVGkKL6Y88L9qqYAMRMvmHf7uJCFMrC8BoGcRLCEutez3OAE0LGWdSjty7kYmDeOO6enjqZPDpJn3rYlzlkS1mArSjpl4EqP/vcAJExt5dp0CE54vvJmWzk8lDmL44URkb7Fue2jvbmFOYbYe MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LO4P265MB5914.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f3170520-5a64-4b2b-9b1c-08db63804be9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 15:44:48.3489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uunAWvhHDWX80NyXSAGgU6bnOMHZQWEqCsdyy7frgrjziz+1MQtQHkcl4KgYWthuhlmQIfhVb78cYgIeoEVdbuRGXodEuAVeEUjqLbKzHbA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB5178 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-GUID: EomQeFXV72jlGlZvtSSWimJi8GAVbGTp X-Proofpoint-ORIG-GUID: EomQeFXV72jlGlZvtSSWimJi8GAVbGTp X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
| Series |
libstdc++: Do not assume existence of char8_t codecvt facet
|
|
Checks
| Context | Check | Description |
|---|---|---|
| linaro-tcwg-bot/tcwg_gcc_build--master-arm | fail | Patch failed to apply |
| linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | fail | Patch failed to apply |
| linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 | pending | Test started |
| linaro-tcwg-bot/tcwg_gcc_check--master-arm | pending | Test started |
Commit Message
Joseph Faulls
June 2, 2023, 3:44 p.m. UTC
It is not required that codecvt<char8_t, char, mbstate_t> facet be supported by
the locale, nor is it added as part of the default locale. This can lead to
dangerous behaviour when static_cast.
libstdc++-v3/ChangeLog:
* include/bits/locale_classes.tcc: Remove check.
---
libstdc++-v3/include/bits/locale_classes.tcc | 3 ---
1 file changed, 3 deletions(-)
--
2.34.1
Comments
On Fri, 2 Jun 2023 at 16:45, Joseph Faulls wrote: > It is not required that codecvt<char8_t, char, mbstate_t> facet be > supported by > > the locale, nor is it added as part of the default locale. This can lead to > > dangerous behaviour when static_cast. > Ouch, yes indeed. I don't know why I added that there. Thanks for the patch, I'll apply it to trunk and gcc-13 ASAP. > > libstdc++-v3/ChangeLog: > > > > * include/bits/locale_classes.tcc: Remove check. > > --- > > libstdc++-v3/include/bits/locale_classes.tcc | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/libstdc++-v3/include/bits/locale_classes.tcc > b/libstdc++-v3/include/bits/locale_classes.tcc > > index 94838cd7796..2351dd5bcfb 100644 > > --- a/libstdc++-v3/include/bits/locale_classes.tcc > > +++ b/libstdc++-v3/include/bits/locale_classes.tcc > > @@ -129,9 +129,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > _GLIBCXX_STD_FACET(time_put<wchar_t>); > > _GLIBCXX_STD_FACET(messages<wchar_t>); > > #endif > > -#ifdef _GLIBCXX_USE_CHAR8_T > > - _GLIBCXX_STD_FACET(codecvt<char8_t, char, mbstate_t>); > > -#endif > > #if __cplusplus >= 201103L > > _GLIBCXX_STD_FACET(codecvt<char16_t, char, mbstate_t>); > > _GLIBCXX_STD_FACET(codecvt<char32_t, char, mbstate_t>); > > -- > > 2.34.1 >
On Fri, 2 Jun 2023 at 17:52, Jonathan Wakely <jwakely@redhat.com> wrote: > On Fri, 2 Jun 2023 at 16:45, Joseph Faulls wrote: > >> It is not required that codecvt<char8_t, char, mbstate_t> facet be >> supported by >> >> the locale, nor is it added as part of the default locale. This can lead >> to >> >> dangerous behaviour when static_cast. >> > > Ouch, yes indeed. I don't know why I added that there. Thanks for the > patch, I'll apply it to trunk and gcc-13 ASAP. > I've pushed it to trunk now. As it's only removing 3 lines I don't think we need a copyright assignment or DCO sign-off for this patch - thanks for contributing it. I think what I intended to check for there was codecvt<char16_t, char8_t, mbstate_t> and codecvt<char32_t, char8_t, mbstate_t>, but I had a brainfart. > > > > >> >> libstdc++-v3/ChangeLog: >> >> >> >> * include/bits/locale_classes.tcc: Remove check. >> >> --- >> >> libstdc++-v3/include/bits/locale_classes.tcc | 3 --- >> >> 1 file changed, 3 deletions(-) >> >> >> >> diff --git a/libstdc++-v3/include/bits/locale_classes.tcc >> b/libstdc++-v3/include/bits/locale_classes.tcc >> >> index 94838cd7796..2351dd5bcfb 100644 >> >> --- a/libstdc++-v3/include/bits/locale_classes.tcc >> >> +++ b/libstdc++-v3/include/bits/locale_classes.tcc >> >> @@ -129,9 +129,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> >> _GLIBCXX_STD_FACET(time_put<wchar_t>); >> >> _GLIBCXX_STD_FACET(messages<wchar_t>); >> >> #endif >> >> -#ifdef _GLIBCXX_USE_CHAR8_T >> >> - _GLIBCXX_STD_FACET(codecvt<char8_t, char, mbstate_t>); >> >> -#endif >> >> #if __cplusplus >= 201103L >> >> _GLIBCXX_STD_FACET(codecvt<char16_t, char, mbstate_t>); >> >> _GLIBCXX_STD_FACET(codecvt<char32_t, char, mbstate_t>); >> >> -- >> >> 2.34.1 >> >
diff --git a/libstdc++-v3/include/bits/locale_classes.tcc b/libstdc++-v3/include/bits/locale_classes.tcc index 94838cd7796..2351dd5bcfb 100644 --- a/libstdc++-v3/include/bits/locale_classes.tcc +++ b/libstdc++-v3/include/bits/locale_classes.tcc @@ -129,9 +129,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _GLIBCXX_STD_FACET(time_put<wchar_t>); _GLIBCXX_STD_FACET(messages<wchar_t>); #endif -#ifdef _GLIBCXX_USE_CHAR8_T - _GLIBCXX_STD_FACET(codecvt<char8_t, char, mbstate_t>); -#endif #if __cplusplus >= 201103L _GLIBCXX_STD_FACET(codecvt<char16_t, char, mbstate_t>); _GLIBCXX_STD_FACET(codecvt<char32_t, char, mbstate_t>);