Message ID | DM4PR11MB5487D12DCC77C6F69B1B6775EC3D9@DM4PR11MB5487.namprd11.prod.outlook.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2DC083858403 for <patchwork@sourceware.org>; Sun, 6 Nov 2022 13:00:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DC083858403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667739640; bh=jqne24RKORzJ24gDO5wvvtyLHaQvJ0FCyS0Zp+3H0xs=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Tw1pqawBLLVhaKYn/95GrH+kUtyiJgfNnLt26+Oh5LCgQ8558uHwbJb08/SvdcOfa 5J17uWMFUYa8wvFhZ7KKwX/ubr3DQ+7LUQ0xogPIEN26BFyOR6lQvXEKmN/lSNljAf fUkb/H5Y74ykambseA+6zyr5aRwmO7bUhVvdtZZc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 6C8F03858CDB for <gcc-patches@gcc.gnu.org>; Sun, 6 Nov 2022 12:59:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C8F03858CDB X-IronPort-AV: E=McAfee;i="6500,9779,10522"; a="293594280" X-IronPort-AV: E=Sophos;i="5.96,142,1665471600"; d="scan'208";a="293594280" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 04:59:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10522"; a="586688392" X-IronPort-AV: E=Sophos;i="5.96,142,1665471600"; d="scan'208";a="586688392" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 06 Nov 2022 04:59:28 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 6 Nov 2022 04:59:27 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 6 Nov 2022 04:59:27 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 6 Nov 2022 04:59:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWNSm7KtThMqW6e6RxXf/GvzGxY+IPF+sdsUGEOXS6lT5bQ7jAqWkAqKpvlVX+E1pUUMrS5wbdEcy64c0vYb77ShN5gEnP7e47EemLweDeoFSqYzrEck9Gz1uiPoKqCHD6Nd7+drSArRtH3ypgBvj5rc35ZN16qf+vpZE3JdwckKHa/kaz161ylo5jK/ITxMQzX/meV+c7H61mTsK8ZX+Ow13OqYJbRxKh/pCk85Mg3oAweXre8OJ1elbb6nmsVDJDC97jWBIOsErjc2W+8TKqpKb3oEGVCMMQZseQtWryCsFJH97O44yB4v++YSucDdI8The7BA5XYMCSwa6YyUFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqne24RKORzJ24gDO5wvvtyLHaQvJ0FCyS0Zp+3H0xs=; b=PVlyRRVpCKkep4ckTjqYCIXAm/u4iEKy5oCQy/5g9rTT3J+B70IZX2qpstahFgiWoBgQsr/0lSxU4msKO+BDJxPgSdL71/8NbsESok9kx3F+tzfO8bMxio+EiUsgzYiySjCk+XDgnzRn7SDMBQWnUZqm2knznczB9fSPaUfuQ2h6t4KYJRtftefeEIo9DelD15FqjLANK1V2Kh3yT1Kva/yTfwDtOosiD5KZV82pLiNDpxcC/MiodgSk2/VdFm+nHbDc3ZcgUAP3PUfAbBKuCWMplK4C7SicS2xd3PPYsTVlmIb6kZZG6O7jcHkVUsxiylv1Zlnq4uLJ4x09mwN2iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5487.namprd11.prod.outlook.com (2603:10b6:5:39f::22) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Sun, 6 Nov 2022 12:59:25 +0000 Received: from DM4PR11MB5487.namprd11.prod.outlook.com ([fe80::dc50:e9a3:2270:4a70]) by DM4PR11MB5487.namprd11.prod.outlook.com ([fe80::dc50:e9a3:2270:4a70%8]) with mapi id 15.20.5791.025; Sun, 6 Nov 2022 12:59:25 +0000 To: "Liu, Hongtao" <hongtao.liu@intel.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> Subject: [PATCH] i386: Prefer remote atomic insn for atomic_fetch{add, and, or, xor} Thread-Topic: [PATCH] i386: Prefer remote atomic insn for atomic_fetch{add, and, or, xor} Thread-Index: AQHY8d9CUSyjtPzEiEiUxOxxdc6qGK4x2uOw Date: Sun, 6 Nov 2022 12:59:25 +0000 Message-ID: <DM4PR11MB5487D12DCC77C6F69B1B6775EC3D9@DM4PR11MB5487.namprd11.prod.outlook.com> References: <20221106125651.501400-1-lingling.kong@intel.com> In-Reply-To: <20221106125651.501400-1-lingling.kong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5487:EE_|PH0PR11MB5013:EE_ x-ms-office365-filtering-correlation-id: 39707d55-b8a2-4fe4-93e7-08dabff6bb51 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SPyc0JpcmK6+Smsyg1HGLPEIZwu9iw7WC/eLPO7ug5B5SeXb9SS9/+YsOWBcx8UucSGicyzzX6YLBdfaEBYwrYA3Hhryl/8I9J4oJFEizAPekYmsBsghNrAI1PFhsGSfmksS8IXTjCPqldo834hzVpzvoQU5nHjRbPLTPjna6G6vcq2PFuhLMe/fOw7xUJRC944yGd/U3xGjGk5SI7UD6o7yPFyZdTI6GKIEVPAKoNa/2tmE21zrpH28k+Q9Kgl0Nw+/5lxMpBwZdgXzXbjqgF42y2owkD/h7pJ933Vg+oz56MGl7TGjFuLv9vTixtnRXEeHj8Y4nMrS02P5FkEVDYC+xB7TzF79i+Z7gvu+B/yGQclF76gZLdPpqrv7w5Jx5iMq8aMDMiJ6HFdsPljPOhuWodPuk+s5yS8o/8gjIBmOuQgDPIdJ8vf5/9xEpR0cpU7JtVng7nkC3gy65raZO0bu+vD+AnUDo+FtEdXG52v/OjtMwumgagFvO+PQHieAKV8owQLL6NKmWpGC43K9WCXPGhR6Z/lMAdfCsbuoa3HY/SDA5LGzYCC5VEZL96aApCpfobIuqI0GMNAh4EgczDVGrSWXwH/4fIdHkdKlepihdUa0HuSCbdgl8CJqNh8uCZ0wol4OKkqriXId2VdIXkEsfpzUuPTsb/ntY7Cdi7t7NLBBhxgV4JBFmq4OjJZX1VSCbV49eC2ZEcgqXRV/hAoBMK1i1DRRr3eJuSoFxyMTzzKLHtGDmMjUBOkWTdpVcAsRRXqV4A5WD72FDu1Z8hOh5i+bZhJjpC/6dx2EqoI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(83380400001)(186003)(7696005)(316002)(38100700002)(8936002)(41300700001)(478600001)(2906002)(6506007)(84970400001)(33656002)(26005)(9686003)(52536014)(55016003)(71200400001)(86362001)(5660300002)(8676002)(38070700005)(110136005)(122000001)(66476007)(64756008)(66556008)(66446008)(66946007)(76116006)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: WdiJLINESuPOYkY4r7IKCYuaRSlmOXCxtAnIn5CiISfUK8G2Em1r/F+zHh2uVjhkRB/cKSt1QUA4da3zB408isa5UP0XTlGONdOKsJWD/vyLjabWYR/tRo/jUyYMK0iGLFuoMx5k8hD+7mO7VWol9/qg3Il9ADNmJUBMF/MpiTmDewE4YircUufcaYxWq/iHI27QzO2gmZd3OAv6tHd3vhReIJ3MUf0YBygTHKVRbiY1CriJ8R9J0iHL5QJemffmMtxaWPpVJk4gKD3vP82Cbq76l1gHn+xNb9ezoYq/1GIOmC1dRduHSjKeURMf6o+iYz+gAIUiWkldtwK3k6WoRHB1AQX9E2JshRkgpykW9akVAiQkmWdgyLll0sGxXnrQS3fLVn9dwGKMicGJ8NXeNKiEeUm1S8FHdxDId1iW6WPGXHl955Ak4jkOdPbSknT3EveURTVBnny8r29E4jJmVP4KP5vb2LwuwwHiaDn+Nv1ismGO/wC8k1EaZc3KkalN/T65hwAS0tICnwAsNW+ftWTaCHy5mJtoPS5Qv7iCE7hpSdyRuekgSd2v01ajG2SVH1sL5JVDFedCdhiudu4w7KK/0eVQKhxTIkscWrgzrLNuJqDOqTq4r+Zm7HesOWEmNQZ591ACUa8pmkOWZL6ikuuGHJlUj4kdOM0WDAEZ38Zb2MBZmUrNqqk4qx9zriJ9LBny6Cj17bwkU2rqk6r5ZnE97lh3H3S4SC+yl8WikpbuO2axHdKGRZLdRNyPtg8QCaWMBA6kfziL19wlIbDetAKa8kPmGeqvWO88soEm0Tjgq2ugyI10wBzfqKZKraUPicdeucz/YF5K+giUBcnbvgc8zogCJm1hTQzF6PdtC0ypNGOGb0L2dTNhYQt2yzEAQ7vguW8xwh1W6KRt0ihTH2+JH95pDftsqz9tnG0useJDFNEZsgmogqSP7KCuZo6aY4+OHqPGQ23bqFxG4wSVoFDHbvfrLvp1fgJznNB6ZorSqKhnIH0P2QVC81gbHw9HccTIZebDlOUKlYz6hQP7+XLWbACDCZCUA6U8HkNFAFvEXxcS/kllCmVTfk1+lZY2qRXqUB2elJISemIbHH3eCkpc2/WGTnkNd4xfP7Xb2A3KkrTF561O7wxisUPOAwKR+v5FkJi5pkD9rD0IqqC0S2TUQTmQ7Rtzng5fTlsW7KVhM+Sjdk6f/Ks+2ii0JUg8oOqMyYxMMIf6MHiBkPUsuRPSadwjVOpxoqx6Pvdo2pPtheevU/11hvML2bBwWe/W5wLeXjYtQScfqXtpdkIDK5fbM5Zy5RB/0z28qSxbxX2yVKnHRIuy/pmqVjnJ0vumDIIbC3Ed222U2pYN+7GH3eiLivh5gf2J+aSZQdP+dkD+LvjpHW0eRo/z6h7JySxdr4XIGRJxmPlPnMOFLUU5+MA5lrGaEV3FlDrukf1ZGV1Xsvh/cezEiO96lceniBeGGBvqQa5TDxger7sqIXdILxcDecVv9wbwCgr+fQWn2mPXqxUPv5kdI0A47O6Zoauc+HI0n/VJuVaM97Tg1S2HnQvzqVi7HqVCavwf/qa7UIFkdQHLvVpNqJTACwF6a1gJ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39707d55-b8a2-4fe4-93e7-08dabff6bb51 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2022 12:59:25.1423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y1X9+ChC5oMJPLYA34lxqLDGvK/QwbLmLLQkQGMv1R5AqNDY4ksZ0KCQqC02iddgvp0QjIJ8fhPVOik16rHdGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: "Kong, Lingling via Gcc-patches" <gcc-patches@gcc.gnu.org> Reply-To: "Kong, Lingling" <lingling.kong@intel.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
i386: Prefer remote atomic insn for atomic_fetch{add, and, or, xor}
|
|
Commit Message
Li, Pan2 via Gcc-patches
Nov. 6, 2022, 12:59 p.m. UTC
Hi The patch is to add flag -mprefer-remote-atomic to control whether to generate raoint insn for atomic operations. Ok for trunk? BRs, Lingling gcc/ChangeLog: * config/i386/i386.opt:Add -mprefer-remote-atomic. * config/i386/sync.md (atomic_<plus_logic><mode>): New define_expand. (atomic_add<mode>): Rename to below one. (atomic_add<mode>_1): To this. (atomic_<logic><mode>): Ditto. (atomic_<logic><mode>_1): Ditto. gcc/testsuite/ChangeLog: * gcc.target/i386/raoint-atomic-fetch.c: New test. --- gcc/config/i386/i386.opt | 4 +++ gcc/config/i386/sync.md | 29 ++++++++++++++++--- .../gcc.target/i386/raoint-atomic-fetch.c | 29 +++++++++++++++++++ 3 files changed, 58 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c
Comments
On Sun, Nov 6, 2022 at 9:00 PM Kong, Lingling via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Hi > > The patch is to add flag -mprefer-remote-atomic to control whether to generate raoint insn for atomic operations. > Ok for trunk? Ok with below 2 little adjustments. > > BRs, > Lingling > > gcc/ChangeLog: > > * config/i386/i386.opt:Add -mprefer-remote-atomic. Please also update *x86 options* in gcc/doc/invode.texi. > * config/i386/sync.md (atomic_<plus_logic><mode>): > New define_expand. > (atomic_add<mode>): Rename to below one. > (atomic_add<mode>_1): To this. > (atomic_<logic><mode>): Ditto. > (atomic_<logic><mode>_1): Ditto. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/raoint-atomic-fetch.c: New test. > --- > gcc/config/i386/i386.opt | 4 +++ > gcc/config/i386/sync.md | 29 ++++++++++++++++--- > .../gcc.target/i386/raoint-atomic-fetch.c | 29 +++++++++++++++++++ > 3 files changed, 58 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > > diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt index 415c52e1bb4..abb1e5ecbdc 100644 > --- a/gcc/config/i386/i386.opt > +++ b/gcc/config/i386/i386.opt > @@ -1246,3 +1246,7 @@ Support PREFETCHI built-in functions and code generation. > mraoint > Target Mask(ISA2_RAOINT) Var(ix86_isa_flags2) Save Support RAOINT built-in functions and code generation. > + > +mprefer-remote-atomic > +Target Var(flag_prefer_remote_atomic) Init(0) Prefer use remote atomic > +insn for atomic operations. > diff --git a/gcc/config/i386/sync.md b/gcc/config/i386/sync.md index e6543a5efb0..08e944fc9b7 100644 > --- a/gcc/config/i386/sync.md > +++ b/gcc/config/i386/sync.md > @@ -37,7 +37,7 @@ > UNSPECV_CMPXCHG > UNSPECV_XCHG > UNSPECV_LOCK > - > + Please remove this change. > ;; For CMPccXADD support > UNSPECV_CMPCCXADD > > @@ -791,7 +791,28 @@ > (define_code_iterator any_plus_logic [and ior xor plus]) (define_code_attr plus_logic [(and "and") (ior "or") (xor "xor") (plus "add")]) > > -(define_insn "rao_a<plus_logic><mode>" > +(define_expand "atomic_<plus_logic><mode>" > + [(match_operand:SWI 0 "memory_operand") > + (any_plus_logic:SWI (match_dup 0) > + (match_operand:SWI 1 "nonmemory_operand")) > + (match_operand:SI 2 "const_int_operand")] > + "" > +{ > + if (flag_prefer_remote_atomic > + && TARGET_RAOINT && operands[2] == const0_rtx > + && (<MODE>mode == SImode || <MODE>mode == DImode)) > + { > + if (CONST_INT_P (operands[1])) > + operands[1] = force_reg (<MODE>mode, operands[1]); > + emit_insn (maybe_gen_rao_a (<CODE>, <MODE>mode, operands[0], > +operands[1])); > + } > + else > + emit_insn (gen_atomic_<plus_logic><mode>_1 (operands[0], operands[1], > + operands[2])); > + DONE; > +}) > + > +(define_insn "@rao_a<plus_logic><mode>" > [(set (match_operand:SWI48 0 "memory_operand" "+m") > (unspec_volatile:SWI48 > [(any_plus_logic:SWI48 (match_dup 0) @@ -801,7 +822,7 @@ > "TARGET_RAOINT" > "a<plus_logic>\t{%1, %0|%0, %1}") > > -(define_insn "atomic_add<mode>" > +(define_insn "atomic_add<mode>_1" > [(set (match_operand:SWI 0 "memory_operand" "+m") > (unspec_volatile:SWI > [(plus:SWI (match_dup 0) > @@ -855,7 +876,7 @@ > return "lock{%;} %K2sub{<imodesuffix>}\t{%1, %0|%0, %1}"; > }) > > -(define_insn "atomic_<logic><mode>" > +(define_insn "atomic_<logic><mode>_1" > [(set (match_operand:SWI 0 "memory_operand" "+m") > (unspec_volatile:SWI > [(any_logic:SWI (match_dup 0) > diff --git a/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > new file mode 100644 > index 00000000000..ac4099d888e > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > @@ -0,0 +1,29 @@ > +/* { dg-do compile } */ > +/* { dg-options "-mraoint -O2 -mprefer-remote-atomic" } */ > +/* { dg-final { scan-assembler-times "aadd" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "aand" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "aor" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "axor" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "aadd" 1 { target ia32 } } } */ > +/* { dg-final { scan-assembler-times "aand" 1 { target ia32 } } } */ > +/* { dg-final { scan-assembler-times "aor" 1 { target ia32 } } } */ > +/* { dg-final { scan-assembler-times "axor" 1 { target ia32 } } } */ > +volatile int x; volatile long long y; int *a; long long *b; > + > +void extern > +rao_int_test (void) > +{ > + __atomic_add_fetch (a, x, __ATOMIC_RELAXED); > + __atomic_and_fetch (a, x, __ATOMIC_RELAXED); > + __atomic_or_fetch (a, x, __ATOMIC_RELAXED); > + __atomic_xor_fetch (a, x, __ATOMIC_RELAXED); #ifdef __x86_64__ > + __atomic_add_fetch (b, y, __ATOMIC_RELAXED); > + __atomic_and_fetch (b, y, __ATOMIC_RELAXED); > + __atomic_or_fetch (b, y, __ATOMIC_RELAXED); > + __atomic_xor_fetch (b, y, __ATOMIC_RELAXED); #endif } > -- > 2.27.0 >
On Sun, Nov 6, 2022 at 2:00 PM Kong, Lingling via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Hi > > The patch is to add flag -mprefer-remote-atomic to control whether to generate raoint insn for atomic operations. > Ok for trunk? Please note TARGET_AVOID_MFENCE tuning flag, introduced a while ago due to the fact that several targets perform LOCK OR faster than MFENCE. It was determined that MFENCE/SFENCE/LFENCE are much more complex instructions compared to LOCK OR, since they have to handle cases that C memory model never describes (some MMIO, or such). Considering that ordinary LOCKed operations adequately cover C memory model, and are probably faster than new instructions that have to cover all special cases, I wonder if there is really benefit to emit these insns instead of existing LOCKed operations. These should IMO be used only via relevant builtins. Uros. > > BRs, > Lingling > > gcc/ChangeLog: > > * config/i386/i386.opt:Add -mprefer-remote-atomic. > * config/i386/sync.md (atomic_<plus_logic><mode>): > New define_expand. > (atomic_add<mode>): Rename to below one. > (atomic_add<mode>_1): To this. > (atomic_<logic><mode>): Ditto. > (atomic_<logic><mode>_1): Ditto. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/raoint-atomic-fetch.c: New test. > --- > gcc/config/i386/i386.opt | 4 +++ > gcc/config/i386/sync.md | 29 ++++++++++++++++--- > .../gcc.target/i386/raoint-atomic-fetch.c | 29 +++++++++++++++++++ > 3 files changed, 58 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > > diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt index 415c52e1bb4..abb1e5ecbdc 100644 > --- a/gcc/config/i386/i386.opt > +++ b/gcc/config/i386/i386.opt > @@ -1246,3 +1246,7 @@ Support PREFETCHI built-in functions and code generation. > mraoint > Target Mask(ISA2_RAOINT) Var(ix86_isa_flags2) Save Support RAOINT built-in functions and code generation. > + > +mprefer-remote-atomic > +Target Var(flag_prefer_remote_atomic) Init(0) Prefer use remote atomic > +insn for atomic operations. > diff --git a/gcc/config/i386/sync.md b/gcc/config/i386/sync.md index e6543a5efb0..08e944fc9b7 100644 > --- a/gcc/config/i386/sync.md > +++ b/gcc/config/i386/sync.md > @@ -37,7 +37,7 @@ > UNSPECV_CMPXCHG > UNSPECV_XCHG > UNSPECV_LOCK > - > + > ;; For CMPccXADD support > UNSPECV_CMPCCXADD > > @@ -791,7 +791,28 @@ > (define_code_iterator any_plus_logic [and ior xor plus]) (define_code_attr plus_logic [(and "and") (ior "or") (xor "xor") (plus "add")]) > > -(define_insn "rao_a<plus_logic><mode>" > +(define_expand "atomic_<plus_logic><mode>" > + [(match_operand:SWI 0 "memory_operand") > + (any_plus_logic:SWI (match_dup 0) > + (match_operand:SWI 1 "nonmemory_operand")) > + (match_operand:SI 2 "const_int_operand")] > + "" > +{ > + if (flag_prefer_remote_atomic > + && TARGET_RAOINT && operands[2] == const0_rtx > + && (<MODE>mode == SImode || <MODE>mode == DImode)) > + { > + if (CONST_INT_P (operands[1])) > + operands[1] = force_reg (<MODE>mode, operands[1]); > + emit_insn (maybe_gen_rao_a (<CODE>, <MODE>mode, operands[0], > +operands[1])); > + } > + else > + emit_insn (gen_atomic_<plus_logic><mode>_1 (operands[0], operands[1], > + operands[2])); > + DONE; > +}) > + > +(define_insn "@rao_a<plus_logic><mode>" > [(set (match_operand:SWI48 0 "memory_operand" "+m") > (unspec_volatile:SWI48 > [(any_plus_logic:SWI48 (match_dup 0) @@ -801,7 +822,7 @@ > "TARGET_RAOINT" > "a<plus_logic>\t{%1, %0|%0, %1}") > > -(define_insn "atomic_add<mode>" > +(define_insn "atomic_add<mode>_1" > [(set (match_operand:SWI 0 "memory_operand" "+m") > (unspec_volatile:SWI > [(plus:SWI (match_dup 0) > @@ -855,7 +876,7 @@ > return "lock{%;} %K2sub{<imodesuffix>}\t{%1, %0|%0, %1}"; > }) > > -(define_insn "atomic_<logic><mode>" > +(define_insn "atomic_<logic><mode>_1" > [(set (match_operand:SWI 0 "memory_operand" "+m") > (unspec_volatile:SWI > [(any_logic:SWI (match_dup 0) > diff --git a/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > new file mode 100644 > index 00000000000..ac4099d888e > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > @@ -0,0 +1,29 @@ > +/* { dg-do compile } */ > +/* { dg-options "-mraoint -O2 -mprefer-remote-atomic" } */ > +/* { dg-final { scan-assembler-times "aadd" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "aand" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "aor" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "axor" 2 { target {! ia32 } } } } > +*/ > +/* { dg-final { scan-assembler-times "aadd" 1 { target ia32 } } } */ > +/* { dg-final { scan-assembler-times "aand" 1 { target ia32 } } } */ > +/* { dg-final { scan-assembler-times "aor" 1 { target ia32 } } } */ > +/* { dg-final { scan-assembler-times "axor" 1 { target ia32 } } } */ > +volatile int x; volatile long long y; int *a; long long *b; > + > +void extern > +rao_int_test (void) > +{ > + __atomic_add_fetch (a, x, __ATOMIC_RELAXED); > + __atomic_and_fetch (a, x, __ATOMIC_RELAXED); > + __atomic_or_fetch (a, x, __ATOMIC_RELAXED); > + __atomic_xor_fetch (a, x, __ATOMIC_RELAXED); #ifdef __x86_64__ > + __atomic_add_fetch (b, y, __ATOMIC_RELAXED); > + __atomic_and_fetch (b, y, __ATOMIC_RELAXED); > + __atomic_or_fetch (b, y, __ATOMIC_RELAXED); > + __atomic_xor_fetch (b, y, __ATOMIC_RELAXED); #endif } > -- > 2.27.0 >
> On Sun, Nov 6, 2022 at 2:00 PM Kong, Lingling via Gcc-patches <gcc- > patches@gcc.gnu.org> wrote: > > > > Hi > > > > The patch is to add flag -mprefer-remote-atomic to control whether to > generate raoint insn for atomic operations. > > Ok for trunk? > > Please note TARGET_AVOID_MFENCE tuning flag, introduced a while ago due to > the fact that several targets perform LOCK OR faster than MFENCE. > > It was determined that MFENCE/SFENCE/LFENCE are much more complex > instructions compared to LOCK OR, since they have to handle cases that C > memory model never describes (some MMIO, or such). Considering that > ordinary LOCKed operations adequately cover C memory model, and are > probably faster than new instructions that have to cover all special cases, I > wonder if there is really benefit to emit these insns instead of existing LOCKed > operations. These should IMO be used only via relevant builtins. > > Uros. > Ok, I will revert this patch in trunk. And wait until the optimization results of the actual hardware come out, and then consider to push the optimization patch. > > > > BRs, > > Lingling > > > > gcc/ChangeLog: > > > > * config/i386/i386.opt:Add -mprefer-remote-atomic. > > * config/i386/sync.md (atomic_<plus_logic><mode>): > > New define_expand. > > (atomic_add<mode>): Rename to below one. > > (atomic_add<mode>_1): To this. > > (atomic_<logic><mode>): Ditto. > > (atomic_<logic><mode>_1): Ditto. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/i386/raoint-atomic-fetch.c: New test. > > --- > > gcc/config/i386/i386.opt | 4 +++ > > gcc/config/i386/sync.md | 29 ++++++++++++++++--- > > .../gcc.target/i386/raoint-atomic-fetch.c | 29 +++++++++++++++++++ > > 3 files changed, 58 insertions(+), 4 deletions(-) create mode 100644 > > gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > > > > diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt index > > 415c52e1bb4..abb1e5ecbdc 100644 > > --- a/gcc/config/i386/i386.opt > > +++ b/gcc/config/i386/i386.opt > > @@ -1246,3 +1246,7 @@ Support PREFETCHI built-in functions and code > generation. > > mraoint > > Target Mask(ISA2_RAOINT) Var(ix86_isa_flags2) Save Support RAOINT built-in > functions and code generation. > > + > > +mprefer-remote-atomic > > +Target Var(flag_prefer_remote_atomic) Init(0) Prefer use remote > > +atomic insn for atomic operations. > > diff --git a/gcc/config/i386/sync.md b/gcc/config/i386/sync.md index > > e6543a5efb0..08e944fc9b7 100644 > > --- a/gcc/config/i386/sync.md > > +++ b/gcc/config/i386/sync.md > > @@ -37,7 +37,7 @@ > > UNSPECV_CMPXCHG > > UNSPECV_XCHG > > UNSPECV_LOCK > > - > > + > > ;; For CMPccXADD support > > UNSPECV_CMPCCXADD > > > > @@ -791,7 +791,28 @@ > > (define_code_iterator any_plus_logic [and ior xor plus]) > > (define_code_attr plus_logic [(and "and") (ior "or") (xor "xor") (plus > > "add")]) > > > > -(define_insn "rao_a<plus_logic><mode>" > > +(define_expand "atomic_<plus_logic><mode>" > > + [(match_operand:SWI 0 "memory_operand") > > + (any_plus_logic:SWI (match_dup 0) > > + (match_operand:SWI 1 "nonmemory_operand")) > > + (match_operand:SI 2 "const_int_operand")] > > + "" > > +{ > > + if (flag_prefer_remote_atomic > > + && TARGET_RAOINT && operands[2] == const0_rtx > > + && (<MODE>mode == SImode || <MODE>mode == DImode)) > > + { > > + if (CONST_INT_P (operands[1])) > > + operands[1] = force_reg (<MODE>mode, operands[1]); > > + emit_insn (maybe_gen_rao_a (<CODE>, <MODE>mode, operands[0], > > +operands[1])); > > + } > > + else > > + emit_insn (gen_atomic_<plus_logic><mode>_1 (operands[0], operands[1], > > + operands[2])); > > + DONE; > > +}) > > + > > +(define_insn "@rao_a<plus_logic><mode>" > > [(set (match_operand:SWI48 0 "memory_operand" "+m") > > (unspec_volatile:SWI48 > > [(any_plus_logic:SWI48 (match_dup 0) @@ -801,7 +822,7 @@ > > "TARGET_RAOINT" > > "a<plus_logic>\t{%1, %0|%0, %1}") > > > > -(define_insn "atomic_add<mode>" > > +(define_insn "atomic_add<mode>_1" > > [(set (match_operand:SWI 0 "memory_operand" "+m") > > (unspec_volatile:SWI > > [(plus:SWI (match_dup 0) > > @@ -855,7 +876,7 @@ > > return "lock{%;} %K2sub{<imodesuffix>}\t{%1, %0|%0, %1}"; > > }) > > > > -(define_insn "atomic_<logic><mode>" > > +(define_insn "atomic_<logic><mode>_1" > > [(set (match_operand:SWI 0 "memory_operand" "+m") > > (unspec_volatile:SWI > > [(any_logic:SWI (match_dup 0) diff --git > > a/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > > b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > > new file mode 100644 > > index 00000000000..ac4099d888e > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c > > @@ -0,0 +1,29 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-mraoint -O2 -mprefer-remote-atomic" } */ > > +/* { dg-final { scan-assembler-times "aadd" 2 { target {! ia32 } } } > > +} */ > > +/* { dg-final { scan-assembler-times "aand" 2 { target {! ia32 } } } > > +} */ > > +/* { dg-final { scan-assembler-times "aor" 2 { target {! ia32 } } } } > > +*/ > > +/* { dg-final { scan-assembler-times "axor" 2 { target {! ia32 } } } > > +} */ > > +/* { dg-final { scan-assembler-times "aadd" 1 { target ia32 } } } */ > > +/* { dg-final { scan-assembler-times "aand" 1 { target ia32 } } } */ > > +/* { dg-final { scan-assembler-times "aor" 1 { target ia32 } } } */ > > +/* { dg-final { scan-assembler-times "axor" 1 { target ia32 } } } */ > > +volatile int x; volatile long long y; int *a; long long *b; > > + > > +void extern > > +rao_int_test (void) > > +{ > > + __atomic_add_fetch (a, x, __ATOMIC_RELAXED); > > + __atomic_and_fetch (a, x, __ATOMIC_RELAXED); > > + __atomic_or_fetch (a, x, __ATOMIC_RELAXED); > > + __atomic_xor_fetch (a, x, __ATOMIC_RELAXED); #ifdef __x86_64__ > > + __atomic_add_fetch (b, y, __ATOMIC_RELAXED); > > + __atomic_and_fetch (b, y, __ATOMIC_RELAXED); > > + __atomic_or_fetch (b, y, __ATOMIC_RELAXED); > > + __atomic_xor_fetch (b, y, __ATOMIC_RELAXED); #endif } > > -- > > 2.27.0 > >
diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt index 415c52e1bb4..abb1e5ecbdc 100644 --- a/gcc/config/i386/i386.opt +++ b/gcc/config/i386/i386.opt @@ -1246,3 +1246,7 @@ Support PREFETCHI built-in functions and code generation. mraoint Target Mask(ISA2_RAOINT) Var(ix86_isa_flags2) Save Support RAOINT built-in functions and code generation. + +mprefer-remote-atomic +Target Var(flag_prefer_remote_atomic) Init(0) Prefer use remote atomic +insn for atomic operations. diff --git a/gcc/config/i386/sync.md b/gcc/config/i386/sync.md index e6543a5efb0..08e944fc9b7 100644 --- a/gcc/config/i386/sync.md +++ b/gcc/config/i386/sync.md @@ -37,7 +37,7 @@ UNSPECV_CMPXCHG UNSPECV_XCHG UNSPECV_LOCK - + ;; For CMPccXADD support UNSPECV_CMPCCXADD @@ -791,7 +791,28 @@ (define_code_iterator any_plus_logic [and ior xor plus]) (define_code_attr plus_logic [(and "and") (ior "or") (xor "xor") (plus "add")]) -(define_insn "rao_a<plus_logic><mode>" +(define_expand "atomic_<plus_logic><mode>" + [(match_operand:SWI 0 "memory_operand") + (any_plus_logic:SWI (match_dup 0) + (match_operand:SWI 1 "nonmemory_operand")) + (match_operand:SI 2 "const_int_operand")] + "" +{ + if (flag_prefer_remote_atomic + && TARGET_RAOINT && operands[2] == const0_rtx + && (<MODE>mode == SImode || <MODE>mode == DImode)) + { + if (CONST_INT_P (operands[1])) + operands[1] = force_reg (<MODE>mode, operands[1]); + emit_insn (maybe_gen_rao_a (<CODE>, <MODE>mode, operands[0], +operands[1])); + } + else + emit_insn (gen_atomic_<plus_logic><mode>_1 (operands[0], operands[1], + operands[2])); + DONE; +}) + +(define_insn "@rao_a<plus_logic><mode>" [(set (match_operand:SWI48 0 "memory_operand" "+m") (unspec_volatile:SWI48 [(any_plus_logic:SWI48 (match_dup 0) @@ -801,7 +822,7 @@ "TARGET_RAOINT" "a<plus_logic>\t{%1, %0|%0, %1}") -(define_insn "atomic_add<mode>" +(define_insn "atomic_add<mode>_1" [(set (match_operand:SWI 0 "memory_operand" "+m") (unspec_volatile:SWI [(plus:SWI (match_dup 0) @@ -855,7 +876,7 @@ return "lock{%;} %K2sub{<imodesuffix>}\t{%1, %0|%0, %1}"; }) -(define_insn "atomic_<logic><mode>" +(define_insn "atomic_<logic><mode>_1" [(set (match_operand:SWI 0 "memory_operand" "+m") (unspec_volatile:SWI [(any_logic:SWI (match_dup 0) diff --git a/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c new file mode 100644 index 00000000000..ac4099d888e --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/raoint-atomic-fetch.c @@ -0,0 +1,29 @@ +/* { dg-do compile } */ +/* { dg-options "-mraoint -O2 -mprefer-remote-atomic" } */ +/* { dg-final { scan-assembler-times "aadd" 2 { target {! ia32 } } } } +*/ +/* { dg-final { scan-assembler-times "aand" 2 { target {! ia32 } } } } +*/ +/* { dg-final { scan-assembler-times "aor" 2 { target {! ia32 } } } } +*/ +/* { dg-final { scan-assembler-times "axor" 2 { target {! ia32 } } } } +*/ +/* { dg-final { scan-assembler-times "aadd" 1 { target ia32 } } } */ +/* { dg-final { scan-assembler-times "aand" 1 { target ia32 } } } */ +/* { dg-final { scan-assembler-times "aor" 1 { target ia32 } } } */ +/* { dg-final { scan-assembler-times "axor" 1 { target ia32 } } } */ +volatile int x; volatile long long y; int *a; long long *b; + +void extern +rao_int_test (void) +{ + __atomic_add_fetch (a, x, __ATOMIC_RELAXED); + __atomic_and_fetch (a, x, __ATOMIC_RELAXED); + __atomic_or_fetch (a, x, __ATOMIC_RELAXED); + __atomic_xor_fetch (a, x, __ATOMIC_RELAXED); #ifdef __x86_64__ + __atomic_add_fetch (b, y, __ATOMIC_RELAXED); + __atomic_and_fetch (b, y, __ATOMIC_RELAXED); + __atomic_or_fetch (b, y, __ATOMIC_RELAXED); + __atomic_xor_fetch (b, y, __ATOMIC_RELAXED); #endif } -- 2.27.0