From patchwork Wed Sep 28 00:39:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugene Rozenfeld X-Patchwork-Id: 58097 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56CF53857C41 for ; Wed, 28 Sep 2022 00:39:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56CF53857C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1664325591; bh=eKwoRLSAOB+Fiu8Po3eg0DqK5WEpC0LVDi33WVdfyTw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=nR+69OoUUszB7GdPFo4wPBy3evSHA/6medOXObgwOl92OtUgUiVdCZ5oUp63LcQou qjsTZe45qI/pUVR0Jf9gqQKWmZ/1HD8T+b19bz5NYNrFVfxzaNOkKopgxOtN8Ak9L3 roN/NHUNswwWa7jmWyyG6OuG8xSZEpaCdnLY7W5o= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from na01-obe.outbound.protection.outlook.com (mail-eastus2azon11021018.outbound.protection.outlook.com [52.101.57.18]) by sourceware.org (Postfix) with ESMTPS id 069DD3858404 for ; Wed, 28 Sep 2022 00:39:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 069DD3858404 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oLr2DhQvu1aXWY9obIKW4rKlR3wIHIeG/bpVm2YQkni3Hhb9cero93Hu94xJ0zLN52KqauEjrCTbKypFvjuYNEf2Fthno1F1hnPwKQck9SiAmqYMhpw7dWOBgTHujO6UYcN9/w/Wz9kseMtuVIJQStspaoHsh5ULfpJM9RpVb+qg/avlZs29cyygT+YIgXgAgVq+9knTikJiR6XqsC8T87tpmjSUmd///bad93fCklYAecBPzV/jw/sH9Q00dSoAq6llBNIq0IUNk5fax/bRvfHbsMU7hqxeNHSjhlc6GEIJYmHmRf5thqmNrMpmWZS/YmMzmGDLZKOJLKJcyCsV9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eKwoRLSAOB+Fiu8Po3eg0DqK5WEpC0LVDi33WVdfyTw=; b=Ge+PVzxNGgqGLi9v/Jt0ggp1wtR0XXg62kf5dHlUTWCvP8swZ1XEEaUPwPKq69IntnJQ23ur2PNgbjaCGy/wwUCnIdPjk9jdoleh/pyTkexpdmilGVSCjardA5+e8DxdDz3TMrf7fIoSJI+2ay7zlySE84AbPHZhT/TxZdWGc1C/CfKWfkRtewL4Nqne0sLEFrQgei8ACwJjxiQZ3ZNgZao53LFmgSSVVLKZXcNh+4SN4ym56Mp/rZQwvH/KnHPH45Y6NqjRsVZcud9DHfE+vUzff3uipuQFj+Gc8DAKpKoOUztVjZn58Qp9V2MNReHrbd+2iM7LkfsB7fYsYMJRwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from CY5PR21MB3542.namprd21.prod.outlook.com (2603:10b6:930:d::7) by BL1PR21MB3378.namprd21.prod.outlook.com (2603:10b6:208:39e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.0; Wed, 28 Sep 2022 00:39:18 +0000 Received: from CY5PR21MB3542.namprd21.prod.outlook.com ([fe80::38ea:b9c1:41a7:b0ec]) by CY5PR21MB3542.namprd21.prod.outlook.com ([fe80::38ea:b9c1:41a7:b0ec%3]) with mapi id 15.20.5709.000; Wed, 28 Sep 2022 00:39:18 +0000 To: "gcc-patches@gcc.gnu.org" Subject: [PATCH][PUSHED] Fix AutoFDO tests to not look for hot/cold splitting. Thread-Topic: [PATCH][PUSHED] Fix AutoFDO tests to not look for hot/cold splitting. Thread-Index: AdjS0pPg5WzI+/NfREae49sCKWoKIA== Date: Wed, 28 Sep 2022 00:39:18 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=1a26f9e0-0540-4e3a-9cfb-2d18b779d283; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-09-28T00:36:44Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR21MB3542:EE_|BL1PR21MB3378:EE_ x-ms-office365-filtering-correlation-id: b7223f52-997b-41ed-dda8-08daa0e9e0ed x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WGSgOF96nq0gZCa2+XDJxkwX82P4TQ7GQ8rRyDIj/9CibOw26o4os/X10Rtuf5kgFbBQYo2b3lsiXMTLimSH9pmmTOBQDg88p86hXi00ohCRa8BfLGGa54qh3DG6tSTRY+H78lHw7P+er10LzymH1HromYssxf0DUOvMe/N1OQM36S1cyARkh9ry/DPIFNryQMdiVGs/jSmQ0AVjmxiJhH6AcC7ayGpPLHl7IAU05RwDmATxQeZ7BEcGG3dStAJDlhMukpl1dyd4yjaOG85G/xNA8nCuOrreb21X+GkR/ShbHsvAvVEJxd+KXT4K/joRMC9pZWeV1QivgDF/4neP63n39EI4wODCvQxhoLRBQV3IWiAVd38B8YLW4wKGznQC87E5Z1VuuENYY2u5flPccDxpvGtMWpOw2G5X4kCJYvNG7jg0cVH5Bdl9QsKZfHzM4Zab8u3gm38Kuw1jdyUfh1tEvpYVn/b53nWzEHYO371iMDvYQejzmQOVFzrWJtfqDM84yPvzHGyjTQOKgPksv6APKQV6GP36SJ79URhaecMcfNDZMGYbzGfp+64UOC6MGpDyxgNGsefDGyGT0eg6MUYzk3taNaET4qrhtAKLeOXcC6mkKf/jM6yQ4cRMlHRj5OUrVIPeL7n1ltnJiLTSAb1x2YPnZRVKo4Yb0yZ7YeyBY7G2oIuiWkMiVai1nBFVu+6Tv1QZNwbNUi5yfmqxg0Pf62rTKofgrdYXEuwDkN8te6Ec0xyMDNqt0LxCoXGPGFL2O1On8/I8asPqCsaz7tQ42MSwFDYy5D4w/FUXa+k3lHvClNt9bENWFh71JKHaN6MKC8zVRJUtnzn667RRws9WqlRlzH7vKQUB+WsAll8Vu5BwRvwBXpJENmEl59gG x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR21MB3542.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(83380400001)(9686003)(82950400001)(82960400001)(38100700002)(2906002)(38070700005)(186003)(122000001)(41300700001)(8990500004)(5660300002)(478600001)(52536014)(55016003)(66556008)(10290500003)(66946007)(8936002)(71200400001)(6506007)(7696005)(76116006)(8676002)(64756008)(66446008)(66476007)(6916009)(316002)(33656002)(84970400001)(86362001)(461764006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: NH50F7WqFByKZx2PWKwWZLWZG85LgBlUT3MyguRm9hKHNoyq89PRSsR7SrgVviZfkaREMjOOnSoynXgZE66jvk/UutqqQCs28qqrpmzVmObmQ/gHf2zzV9DnqACCT3Jqn1M00npb9W0DH7ROm2MJNHHIlVMnlcju3FosMUmajAk9MkpqAd8o2cb+R6QfjPjH4HYeb1gnBfoiWrta7sVgl508eMqAdkhXsWc7sBqj3kF30X9Q8QugRaEw/EUC9JgamkT9Nu7QL3sbUMaE3Jb612KqkYpjNJmiX+QxH4ffjf/f8wfFclUmUrosiPMHuY5PfMIcLFKwhxQQMxzxC0cvv7XPZZqrn1U3aEzUkxLWcgzeKr0gVsxiwIJMTtMY62qE+Qx9Oo2hE7pfeohGEHKgJ2DKlOhiyh0cVoaSNowx3iSfxUjudJEJ6sUhNbs5um3lKYy5L9PCP7JjvvXQ6kAX/HhjaYvXBDTTKwgeNwqIKTvqZn0vm/MXOcLpeR2OcgtZg9/3ZZz05V2hWcsYXcfGCmMG6sLJWlrzA13VYyQzJ+vUqeZoahXDkA564OF4MCszFESFutNx2V79KzqfEgsE0q8OcDDFmcFBTtoL4BgZti8x66g+eexbV1NAkjo0t1KDHYoRh5+Ry4/32QYSqm8ctvZ7JvN1s28ycC6ez2S/qzgHMRYNvjibbuDVT/B/4YQJx3ry6BAfEnV/xpWusASVsgc5roaon7sH4K6OJ/KXuRoORoVHNIG6Zz3cm43a00OUSTeEo8gceG0l+HsC6PxGi2BDnmVIAxIwTK24Y4QZ0qxJkN9Zfpp9+TpY72fiyED19vELFOpLYiR4fjn8T1jrA2AVoHDrvXz15zL9Oa1/UQKujQpX1NbXXezgqkLLIZtoHdyzfLS+ZAClqisRzkCrc+Y6SwemRGkZYV6dGyCR5GFjKFrDuiaywteh+v76H9+464lGMXz2mtrQAt36+i4NFkNMbZop9kABWW8u2R1KFqbyf99lOxXg4zF4sMIBiZBVKkDmu3EP38FMTre7pw5YpYiX2dRAgoxhSsAL2bUQZ8Ye6EPnC86ZhnNI/FZuyZxAEcYP/M7IlH8FgooPfROSlqriZpk2fI6aZOr7jG3KuyxW5bugL/dQdVHgp5S1oZ26l3iwhj1ZA7fcisytL9dn1vhfKG9W6NM3DeC6xf182S6vS/VS7rL88iV/N+ETBS8RuPInT7h5BUwz2I1biGJwIls+hvP+g917J13WO240OwpKXmurQ7CSY5+TnAeV2Au97KCpzL8hm0OT2FAyny7azBOSU3zwejkzHknpGimrEce+6ZMExhwlNgbtTxWYXgl6B0jHWlrBq9bHvGCNpOiWLQZK4CFiScAzgP5NEYMgDCFPZT2zAaMlJZDY+I/xDCZyQajsXZyvFSCag9sbZsY9Nt5MbDeXqVxZ4uSqjIFLSQBC25APaDTnKm/9TwC/9l+0funpVVLY4/eF496hmYV7ve4cH1EIVEdvoRTo//dOV8DXZPod+tbfyhn8Pt5wIFIXuY9z/ciNNxNLhkm09RuI2OLW2MJW6JRposjE9jwEjoBGePeZykK6c+tfj+v26i6OwTBqTl3OICEd9H/Nx2MUzhDQAeODloCrQGa9PDlNYzTM7sVaUVasYxtKAQJQs/9R MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR21MB3542.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7223f52-997b-41ed-dda8-08daa0e9e0ed X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 00:39:18.7699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8LvGKoHPZTXTJaF7FNu+qvxJtwjzFBVDQwbP5N+ZBsu0R0azo92Nc32iTe88aRB7uuGDTxApyqUOKUyzu2aP7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR21MB3378 X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eugene Rozenfeld via Gcc-patches From: Eugene Rozenfeld Reply-To: Eugene Rozenfeld Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" AutoFDO counts are not reliable and we are currently not performing hot/cold splitting based on them. This change adjusts several tree-prof tests not to check for hot/cold splitting when run with AutoFDO. gcc/testsuite/ChangeLog: * gcc.dg/tree-prof/cold_partition_label.c: Don't check for hot/cold splitting with AutoFDO. * gcc.dg/tree-prof/section-attr-1.c: Don't check for hot/cold splitting with AutoFDO. * gcc.dg/tree-prof/section-attr-2.c: Don't check for hot/cold splitting with AutoFDO. * gcc.dg/tree-prof/section-attr-3.c: Don't check for hot/cold splitting with AutoFDO. --- gcc/testsuite/gcc.dg/tree-prof/cold_partition_label.c | 4 ++-- gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c | 4 ++-- gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c | 4 ++-- gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-prof/cold_partition_label.c b/gcc/testsuite/gcc.dg/tree-prof/cold_partition_label.c index 511b61067c0..b85e6c1f93d 100644 --- a/gcc/testsuite/gcc.dg/tree-prof/cold_partition_label.c +++ b/gcc/testsuite/gcc.dg/tree-prof/cold_partition_label.c @@ -43,6 +43,6 @@ main (int argc, char *argv[]) return 0; } -/* { dg-final-use { scan-assembler "foo\[._\]+cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler "size\[ \ta-zA-Z0-0\]+foo\[._\]+cold" { target *-*-linux* *-*-gnu* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler "foo\[._\]+cold" { target *-*-linux* *-*-gnu* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler "size\[ \ta-zA-Z0-0\]+foo\[._\]+cold" { target *-*-linux* *-*-gnu* } } } */ /* { dg-final-use { scan-tree-dump-not "Invalid sum" "optimized"} } */ diff --git a/gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c b/gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c index 2087d0d2059..5376de14a2f 100644 --- a/gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c +++ b/gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c @@ -52,5 +52,5 @@ foo (int path) } } -/* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c b/gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c index b02526beaea..90de2c08ca4 100644 --- a/gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c +++ b/gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c @@ -51,5 +51,5 @@ foo (int path) } } -/* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ diff --git a/gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c b/gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c index da064070653..29a48f05feb 100644 --- a/gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c +++ b/gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c @@ -52,5 +52,5 @@ foo (int path) } } -/* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ +/* { dg-final-use-not-autofdo { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */