Don't set full_profile in auto-profile [PR113765]

Message ID CO1PR21MB1331A639DA11EBFE8BEAB45D913B2@CO1PR21MB1331.namprd21.prod.outlook.com
State Committed
Commit fe385c219994f6d5c1ffe00bcaf5a62c3d18caaf
Headers
Series Don't set full_profile in auto-profile [PR113765] |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gcc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 success Testing passed

Commit Message

Eugene Rozenfeld March 28, 2024, 3:02 a.m. UTC
  auto-profile currently doesn't guarantee that it will set probabilities
on all edges because of zero basic block counts. Normally those edges
just have probabilities set by the preceding profile_estimate pass but
under -O0 profile_estimate pass doesn't run. The patch removes setting
of full_profile to true in auto-profile.

Tested on x86_64-pc-linux-gnu.

gcc/ChangeLog:
	* auto-profile.cc (afdo_annotate_cfg): Don't set full_profile to true
---
 gcc/auto-profile.cc | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Richard Biener April 3, 2024, 11:56 a.m. UTC | #1
On Thu, Mar 28, 2024 at 4:03 AM Eugene Rozenfeld
<Eugene.Rozenfeld@microsoft.com> wrote:
>
> auto-profile currently doesn't guarantee that it will set probabilities
> on all edges because of zero basic block counts. Normally those edges
> just have probabilities set by the preceding profile_estimate pass but
> under -O0 profile_estimate pass doesn't run. The patch removes setting
> of full_profile to true in auto-profile.

OK.

Thanks,
Richard.

> Tested on x86_64-pc-linux-gnu.
>
> gcc/ChangeLog:
>         * auto-profile.cc (afdo_annotate_cfg): Don't set full_profile to true
> ---
>  gcc/auto-profile.cc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc
> index e5407d32fbb..de59b94bcb3 100644
> --- a/gcc/auto-profile.cc
> +++ b/gcc/auto-profile.cc
> @@ -1580,7 +1580,6 @@ afdo_annotate_cfg (const stmt_set &promoted_stmts)
>      }
>    update_max_bb_count ();
>    profile_status_for_fn (cfun) = PROFILE_READ;
> -  cfun->cfg->full_profile = true;
>    if (flag_value_profile_transformations)
>      {
>        gimple_value_profile_transformations ();
> --
> 2.25.1
>
  

Patch

diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc
index e5407d32fbb..de59b94bcb3 100644
--- a/gcc/auto-profile.cc
+++ b/gcc/auto-profile.cc
@@ -1580,7 +1580,6 @@  afdo_annotate_cfg (const stmt_set &promoted_stmts)
     }
   update_max_bb_count ();
   profile_status_for_fn (cfun) = PROFILE_READ;
-  cfun->cfg->full_profile = true;
   if (flag_value_profile_transformations)
     {
       gimple_value_profile_transformations ();