diff mbox series

arm: unified syntax for libgcc clear_cache

Message ID CAOfV4Gf4C=R=S1fnUYqdjE9tU8FO3h8Vvk8fc891sStaMuzmaA@mail.gmail.com
State Committed
Delegated to: Richard Earnshaw
Headers
Series arm: unified syntax for libgcc clear_cache |

Commit Message

Seija Kijin Aug. 11, 2022, 1:35 p.m. UTC 
  The patch to convert all thumb1 code in libgcc to unified syntax
omitted changing all swi instructions to the current name: svc.

This patch fixes this case.

---
 libgcc/config/arm/lib1funcs.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kyrylo Tkachov Sept. 6, 2022, 2:48 p.m. UTC | #1 
Hi Seija,

> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
> Gcc-patches
> Sent: Thursday, August 11, 2022 2:36 PM
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] arm: unified syntax for libgcc clear_cache
> 
> The patch to convert all thumb1 code in libgcc to unified syntax
> omitted changing all swi instructions to the current name: svc.
> 
> This patch fixes this case.

This is ok, thanks.
Do you need someone to commit this for you?

Kyrill

> 
> ---
>  libgcc/config/arm/lib1funcs.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
> index 8c39c9f20a2b..19fa1462ccf3 100644
> --- a/libgcc/config/arm/lib1funcs.S
> +++ b/libgcc/config/arm/lib1funcs.S
> @@ -1522,7 +1522,7 @@ LSYM(Lover12):
>   add r7, r7, #2
>  #endif
>   mov r2, #0
> - swi 0
> + svc 0
>   do_pop {r7}
>   RET
>   FUNC_END clear_cache
Seija Kijin Sept. 30, 2022, 3:30 p.m. UTC | #2 
Yes, please!

On Tue, Sep 6, 2022 at 10:48 AM Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>
> Hi Seija,
>
> > -----Original Message-----
> > From: Gcc-patches <gcc-patches-
> > bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
> > Gcc-patches
> > Sent: Thursday, August 11, 2022 2:36 PM
> > To: gcc-patches@gcc.gnu.org
> > Subject: [PATCH] arm: unified syntax for libgcc clear_cache
> >
> > The patch to convert all thumb1 code in libgcc to unified syntax
> > omitted changing all swi instructions to the current name: svc.
> >
> > This patch fixes this case.
>
> This is ok, thanks.
> Do you need someone to commit this for you?
>
> Kyrill
>
> >
> > ---
> >  libgcc/config/arm/lib1funcs.S | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
> > index 8c39c9f20a2b..19fa1462ccf3 100644
> > --- a/libgcc/config/arm/lib1funcs.S
> > +++ b/libgcc/config/arm/lib1funcs.S
> > @@ -1522,7 +1522,7 @@ LSYM(Lover12):
> >   add r7, r7, #2
> >  #endif
> >   mov r2, #0
> > - swi 0
> > + svc 0
> >   do_pop {r7}
> >   RET
> >   FUNC_END clear_cache
Richard Earnshaw Jan. 13, 2023, 1:05 p.m. UTC | #3 
I've just noticed that this was never committed.  Presumably that's 
because the patch did not apply cleanly.  I've cleaned it up and pushed 
it now.

R.

On 30/09/2022 16:30, Seija Kijin via Gcc-patches wrote:
> Yes, please!
> 
> On Tue, Sep 6, 2022 at 10:48 AM Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>>
>> Hi Seija,
>>
>>> -----Original Message-----
>>> From: Gcc-patches <gcc-patches-
>>> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
>>> Gcc-patches
>>> Sent: Thursday, August 11, 2022 2:36 PM
>>> To: gcc-patches@gcc.gnu.org
>>> Subject: [PATCH] arm: unified syntax for libgcc clear_cache
>>>
>>> The patch to convert all thumb1 code in libgcc to unified syntax
>>> omitted changing all swi instructions to the current name: svc.
>>>
>>> This patch fixes this case.
>>
>> This is ok, thanks.
>> Do you need someone to commit this for you?
>>
>> Kyrill
>>
>>>
>>> ---
>>>   libgcc/config/arm/lib1funcs.S | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
>>> index 8c39c9f20a2b..19fa1462ccf3 100644
>>> --- a/libgcc/config/arm/lib1funcs.S
>>> +++ b/libgcc/config/arm/lib1funcs.S
>>> @@ -1522,7 +1522,7 @@ LSYM(Lover12):
>>>    add r7, r7, #2
>>>   #endif
>>>    mov r2, #0
>>> - swi 0
>>> + svc 0
>>>    do_pop {r7}
>>>    RET
>>>    FUNC_END clear_cache
diff mbox series

Patch

diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
index 8c39c9f20a2b..19fa1462ccf3 100644
--- a/libgcc/config/arm/lib1funcs.S
+++ b/libgcc/config/arm/lib1funcs.S
@@ -1522,7 +1522,7 @@  LSYM(Lover12):
  add r7, r7, #2
 #endif
  mov r2, #0
- swi 0
+ svc 0
  do_pop {r7}
  RET
  FUNC_END clear_cache