Message ID | 8da19177eb5044f4f79571524c95ff4bac4e1aaa.1636621345.git.linkw@linux.ibm.com |
---|---|
State | Committed |
Commit | 2b5b8610e985e23a0c2e0272339ab074a750e240 |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4E3C3857C47 for <patchwork@sourceware.org>; Thu, 11 Nov 2021 11:31:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4E3C3857C47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1636630290; bh=0OM2ef3BdG4omm5FonNGDGtXay9F7xfDTsCaAJnjzbw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tw7zhueSNz+mG2cdjtXkHb66fb2WPr7pyVPR44ffD5i7J68D1I6PizZndqa/m/ezH F4z9GFxQFhpijhyeUlmqs2I6tKtoVGO68zdnZJmiDePBVsuqIS8Yl7Rcdkl9SPNbNj gpnKrBgbQ6LNiGrSOsTJKTLiR+9S9zEiNn5T7P60= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 12B6F385801F for <gcc-patches@gcc.gnu.org>; Thu, 11 Nov 2021 11:25:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12B6F385801F Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1ABAVOp5021965 for <gcc-patches@gcc.gnu.org>; Thu, 11 Nov 2021 11:25:20 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3c8wbp7v5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gcc-patches@gcc.gnu.org>; Thu, 11 Nov 2021 11:25:20 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1ABAcNQK027761 for <gcc-patches@gcc.gnu.org>; Thu, 11 Nov 2021 11:25:19 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 3c8wbp7v4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Nov 2021 11:25:19 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1ABBHc1P023911; Thu, 11 Nov 2021 11:25:17 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma05fra.de.ibm.com with ESMTP id 3c5hba2m3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Nov 2021 11:25:16 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1ABBPEC959179488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Nov 2021 11:25:14 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ACE384C044; Thu, 11 Nov 2021 11:25:14 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E28564C04A; Thu, 11 Nov 2021 11:25:13 +0000 (GMT) Received: from trout.aus.stglabs.ibm.com (unknown [9.40.194.100]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 11 Nov 2021 11:25:13 +0000 (GMT) To: gcc-patches@gcc.gnu.org Subject: [PATCH 07/15] xtensa: Fix non-robust split condition in define_insn_and_split Date: Thu, 11 Nov 2021 05:24:51 -0600 Message-Id: <8da19177eb5044f4f79571524c95ff4bac4e1aaa.1636621345.git.linkw@linux.ibm.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <cover.1636621345.git.linkw@linux.ibm.com> References: <cover.1636621345.git.linkw@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: uIyjhB978xrtjAyjeI1R2lCfKq-gdMoU X-Proofpoint-GUID: ZaVUsndK2Vqr2YqwFXDu7dk_McXxim40 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-11_03,2021-11-08_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 mlxlogscore=949 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111110066 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Kewen Lin via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Kewen Lin <linkw@linux.ibm.com> Cc: augustine.sterling@gmail.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
Fix non-robust split condition in define_insn_and_split
|
|
Commit Message
Kewen.Lin
Nov. 11, 2021, 11:24 a.m. UTC
This patch is to fix some non-robust split conditions in some define_insn_and_splits, to make each of them applied on top of the corresponding condition for define_insn part, otherwise the splitting could perform unexpectedly. gcc/ChangeLog: * config/xtensa/xtensa.md (movdi_internal, movdf_internal): Fix split condition. --- gcc/config/xtensa/xtensa.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, Nov 11, 2021 at 3:25 AM Kewen Lin <linkw@linux.ibm.com> wrote: > gcc/ChangeLog: > > * config/xtensa/xtensa.md (movdi_internal, movdf_internal): Fix split > condition. I had been hoping Max would reply (as I'm just doing legacy work around this these days), but seeing that he hasn't. This is approved.
on 2021/11/20 上午6:26, augustine.sterling@gmail.com wrote: > On Thu, Nov 11, 2021 at 3:25 AM Kewen Lin <linkw@linux.ibm.com> wrote: >> gcc/ChangeLog: >> >> * config/xtensa/xtensa.md (movdi_internal, movdf_internal): Fix split >> condition. > > I had been hoping Max would reply (as I'm just doing legacy work > around this these days), but seeing that he hasn't. This is approved. > Thanks Augustine! Committed as r12-5444. BR, Kewen
diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index cdf22f14b94..e0bf720d6e0 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -779,7 +779,7 @@ (define_insn_and_split "movdi_internal" "register_operand (operands[0], DImode) || register_operand (operands[1], DImode)" "#" - "reload_completed" + "&& reload_completed" [(set (match_dup 0) (match_dup 2)) (set (match_dup 1) (match_dup 3))] { @@ -1053,7 +1053,7 @@ (define_insn_and_split "movdf_internal" "register_operand (operands[0], DFmode) || register_operand (operands[1], DFmode)" "#" - "reload_completed" + "&& reload_completed" [(set (match_dup 0) (match_dup 2)) (set (match_dup 1) (match_dup 3))] {