From patchwork Fri Jan 20 14:16:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 63456 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89DD6385783F for ; Fri, 20 Jan 2023 14:16:56 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 9CCDB3858D1E for ; Fri, 20 Jan 2023 14:16:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CCDB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208,223";a="97791227" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 20 Jan 2023 06:16:37 -0800 IronPort-SDR: gmKZa7XHYDDmpadUIwNktwtH98cyjDLTc1VMQ6LyI/iSgCLEElgnllAXhWEMuJq2JcCpxwdGrk YROHW3q2v2BxRwihQ8JXDLIJin1l5nTXq1oEUi98Y3LT2id+ToQENCO+x/KiZlt/d16cwYFRH/ S/d47syu/yPJCt7kF/7/mhoxqarackPBjvGAduqT3VXRFkCe7j6ucutMiSwslx8oZOHnl5nvmy FfYnMGMfE2ziSe3x1mC5eZODnXd0TlUnA5E50UXDTw2s/ZkdCwdlhYRiME4+5i6jRFjHfaBwr8 wrI= From: Thomas Schwinge To: Kwok Cheung Yeung , CC: Andrew Stubbs Subject: [og12] Fix 'libgomp.c/simd-math-1.c' configuration (was: [OG12] [committed] amdgcn: Enable SIMD vectorization of math library functions) In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Fri, 20 Jan 2023 15:16:26 +0100 Message-ID: <87wn5h5m11.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! On 2022-11-02T00:50:40+0000, Kwok Cheung Yeung wrote: > I have committed the following patches onto the devel/omp/gcc-12 > development branch: > > 863579c4e30 amdgcn: Enable SIMD vectorization of math functions I've pushed to devel/omp/gcc-12 commit e7d4bcb974915bfe95be6c385641fc66a4201581 "Fix 'libgomp.c/simd-math-1.c' configuration", see attached. Grüße Thomas > bd9a6106b95 amdgcn: Add SIMD versions of math routines to libgcc > d3a2a1cc424 amdgcn: Add builtins for vector floor/floorf > a3c04a367a9 amdgcn: Fix expansion of builtin for vector fabs operation > > These patches implement a vectorized version of most of the C math > library for AMD GCN. These routines will be used when math functions are > used in auto-vectorized code. > > Note that -fno-math-errno must be specified on the command line in most > cases before the compiler will consider using these functions. > > Vectors smaller than the native 64 element ones are also supported (by > masking off the unused lanes), which can be useful for SLP vectorized code. > > Kwok Yeung ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From e7d4bcb974915bfe95be6c385641fc66a4201581 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Sat, 14 Jan 2023 10:28:09 +0100 Subject: [PATCH] Fix 'libgomp.c/simd-math-1.c' configuration If nvptx offloading is configured in addition to GCN, we see: FAIL: libgomp.c/simd-math-1.c (test for excess errors) UNRESOLVED: libgomp.c/simd-math-1.c compilation failed to produce executable x86_64-pc-linux-gnu-accel-nvptx-none-gcc: error: unrecognized command-line option '-mstack-size=3000000' Thus, restrict that ooption to GCN offloading compilation, and on the other hand, there's no reason to skip this test for non-GCN offloading execution: even if not SIMD-vectorized there, we still benefit from correctness testing. libgomp/ * testsuite/libgomp.c/simd-math-1.c: Fix configuration. --- libgomp/ChangeLog.omp | 4 ++++ libgomp/testsuite/libgomp.c/simd-math-1.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp index 629efbc5832..23e93495b62 100644 --- a/libgomp/ChangeLog.omp +++ b/libgomp/ChangeLog.omp @@ -1,3 +1,7 @@ +2023-01-20 Thomas Schwinge + + * testsuite/libgomp.c/simd-math-1.c: Fix configuration. + 2023-01-19 Tobias Burnus Backported from master: diff --git a/libgomp/testsuite/libgomp.c/simd-math-1.c b/libgomp/testsuite/libgomp.c/simd-math-1.c index caf032a77ae..1ebdccccfeb 100644 --- a/libgomp/testsuite/libgomp.c/simd-math-1.c +++ b/libgomp/testsuite/libgomp.c/simd-math-1.c @@ -2,9 +2,9 @@ sufficiently close) results as their scalar equivalents. */ /* { dg-do run } */ -/* { dg-skip-if "AMD GCN only" { ! amdgcn_offloading_enabled } } */ /* { dg-options "-O2 -ftree-vectorize -fno-math-errno" } */ -/* { dg-additional-options "-foffload=-mstack-size=3000000 -foffload=-lm" } */ +/* { dg-additional-options -foffload-options=amdgcn-amdhsa=-mstack-size=3000000 } */ +/* { dg-additional-options -foffload-options=-lm } */ #undef PRINT_RESULT #define VERBOSE 0 -- 2.25.1