Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774]

Message ID 87r17am4xn.fsf@euler.schwinge.homeip.net
State New
Headers
Series Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774] |

Commit Message

Thomas Schwinge March 10, 2022, 11:18 a.m. UTC
  Hi!

On 2022-03-10T12:13:29+0100, I wrote:
> On 2022-02-14T16:56:35+0100, I wrote:
>> [...] give rise to <https://gcc.gnu.org/PR102330> "[12 Regression] ICE in
>> expand_gimple_stmt_1, at cfgexpand.c:3932 since r12-980-g29a2f51806c".
>
> Pushed to master branch commit 687091257820f4a6a005186437917270ecd27416
> "Add 'gfortran.dg/goacc-gomp/pr102330-{1,2,3}.f90' [PR102330]", see
> attached: currently XFAILed with 'dg-ice'.

Well, and as I should figure out, the very same problem/fix is what
causes/cures recently-filed <https://gcc.gnu.org/PR104774> "OpenACC
'kernels' decomposition: internal compiler error: 'verify_gimple' failed,
with 'loop' with explicit 'seq' or 'independent'"!

Pushed to master branch commit 448741533a75862ebf51d8e73eb1dd1f6a47eec5
"Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774]", see
attached: currently XFAILed with 'dg-ice'.


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
  

Patch

From 448741533a75862ebf51d8e73eb1dd1f6a47eec5 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Thu, 3 Mar 2022 18:00:52 +0100
Subject: [PATCH] Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c'
 [PR104774]

..., currently XFAILed with 'dg-ice'.

	PR middle-end/104774
	gcc/testsuite/
	* c-c++-common/goacc/kernels-decompose-pr104774-1.c: New file.
---
 .../goacc/kernels-decompose-pr104774-1.c      | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c

diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c b/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c
new file mode 100644
index 00000000000..776f4d6befa
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104774-1.c
@@ -0,0 +1,41 @@ 
+/* { dg-additional-options "--param openacc-kernels=decompose" } */
+
+/* { dg-additional-options "-fchecking" }
+   { dg-ice TODO } */
+
+/* { dg-additional-options "-fopt-info-all-omp" } */
+
+/* { dg-additional-options "--param=openacc-privatization=noisy" }
+   Prune a few: uninteresting, and potentially varying depending on GCC configuration (data types):
+   { dg-prune-output {note: variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} } */
+
+int arr_0;
+
+void
+foo (void)
+{
+#pragma acc kernels /* { dg-line l_compute1 } */
+  /* { dg-note {OpenACC 'kernels' decomposition: variable 'k' declared in block requested to be made addressable} {} { target *-*-* } l_compute1 } */
+  /* { dg-note {variable 'k' made addressable} {} { target *-*-* } l_compute1 } */
+  /* { dg-note {variable 'k' declared in block is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_compute1 } */
+  /* { dg-note {variable 'arr_0\.0' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} {} { target *-*-* } l_compute1 } */
+  {
+    int k;
+
+    /* { dg-note {parallelized loop nest in OpenACC 'kernels' region} {} { target *-*-* } .+1 } */
+#pragma acc loop seq /* { dg-line l_loop_k1 } */
+    /* { dg-note {variable 'k' in 'private' clause is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_loop_k1 } */
+    for (k = 0; k < 2; k++)
+      arr_0 = k;
+
+    /* { dg-note {parallelized loop nest in OpenACC 'kernels' region} {} { target *-*-* } .+1 } */
+#pragma acc loop independent reduction(+: arr_0) /* { dg-line l_loop_k2 } */
+    /* { dg-note {variable 'k' in 'private' clause is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_loop_k2 } */
+    for (k = 0; k < 2; k++)
+      arr_0 += k;
+  }
+}
+/* { dg-bogus {error: non-register as LHS of binary operation} {} { xfail *-*-* } .-1 }
+   { dg-bogus {error: invalid RHS for gimple memory store: 'var_decl'} {} { xfail *-*-* } .-2 }
+   { dg-allow-blank-lines-in-output 1 }
+   { dg-excess-errors ICE } */
-- 
2.34.1