From patchwork Fri Mar 10 14:42:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 66214 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 776F53858C27 for ; Fri, 10 Mar 2023 14:43:16 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 51CDA3858D38 for ; Fri, 10 Mar 2023 14:42:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51CDA3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208,223";a="99735041" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 10 Mar 2023 06:42:59 -0800 IronPort-SDR: Is0iDDUIju9qEzFguK7Rj/JYEXK8qwdnJyyVHMOqTyInV72onist0LUwn/Kj3l/Ea8Gn8PfsF+ v5XZVmDqMdlfPv7da3rNFy7/XbH0KT3ShzadK/tQ1zstOe/tFwKCOhEdD5AqLHgIRLRtXvhMSO eHIJqVhPcCC2OqKSkGq1zxiD3L7kXJCMilvKEfyU9SzD0eSbkjIKjDwBLBy2hQwngLONwDElZ0 t6RrO6lWT24Gz1rMVZ2eAyhqaHmDS15prTbmiGb/rZHI9+eBppO0wFMS+1PrLOuHl36Sv+4LGz 1kg= From: Thomas Schwinge To: CC: Chung-Lin Tang Subject: OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Fri, 10 Mar 2023 15:42:51 +0100 Message-ID: <87a60kbrbo.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! Pushed to master branch commit b5037d4a073f2e4625afab5ec1f35624d9f9eba1 "OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'", see attached. Chung-Lin, in case you did "worry" ;-) -- no need to, this code dates back way before your "async re-work". Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From b5037d4a073f2e4625afab5ec1f35624d9f9eba1 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 24 Feb 2023 16:17:57 +0100 Subject: [PATCH] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' We're not taking such a shortcut anywhere else, and (with future changes) it has potential to confuse things if synchronization in a libgomp plugin happens to have side effects even if an async queue currently is empty. libgomp/ * oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip shortcut. --- libgomp/oacc-async.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libgomp/oacc-async.c b/libgomp/oacc-async.c index 2562afbd753..82d00b64b50 100644 --- a/libgomp/oacc-async.c +++ b/libgomp/oacc-async.c @@ -410,9 +410,6 @@ goacc_wait (int async, int num_waits, va_list *ap) break; } - if (acc_async_test (qid)) - continue; - if (async == acc_async_sync) acc_wait (qid); else if (qid == async) -- 2.25.1