diff mbox series

OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'

Message ID 87a60kbrbo.fsf@euler.schwinge.homeip.net
State Committed
Headers
Series OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' |

Commit Message

Thomas Schwinge March 10, 2023, 2:42 p.m. UTC 
  Hi!

Pushed to master branch commit b5037d4a073f2e4625afab5ec1f35624d9f9eba1
"OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'",
see attached.

Chung-Lin, in case you did "worry" ;-) -- no need to, this code dates
back way before your "async re-work".


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
diff mbox series

Patch

From b5037d4a073f2e4625afab5ec1f35624d9f9eba1 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Fri, 24 Feb 2023 16:17:57 +0100
Subject: [PATCH] OpenACC: Remove 'acc_async_test' -> skip shortcut in
 'libgomp/oacc-async.c:goacc_wait'

We're not taking such a shortcut anywhere else, and (with future changes) it
has potential to confuse things if synchronization in a libgomp plugin happens
to have side effects even if an async queue currently is empty.

	libgomp/
	* oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip
	shortcut.
---
 libgomp/oacc-async.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libgomp/oacc-async.c b/libgomp/oacc-async.c
index 2562afbd753..82d00b64b50 100644
--- a/libgomp/oacc-async.c
+++ b/libgomp/oacc-async.c
@@ -410,9 +410,6 @@  goacc_wait (int async, int num_waits, va_list *ap)
 	  break;
 	}
 
-      if (acc_async_test (qid))
-	continue;
-
       if (async == acc_async_sync)
 	acc_wait (qid);
       else if (qid == async)
-- 
2.25.1