From patchwork Mon Oct 17 12:08:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 58935 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE3B73853571 for ; Mon, 17 Oct 2022 12:09:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 77004385735A for ; Mon, 17 Oct 2022 12:08:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77004385735A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,191,1661846400"; d="scan'208,223";a="87684132" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 17 Oct 2022 04:08:55 -0800 IronPort-SDR: 5ADv9LJwu5NT2pSr3qv3jplWqNlG2B/RQTLNzFybFSunKqeGyzuCbdZZ7jkU7Xhblhs6Qt6EH2 IeX2L4205+1ZWl7ePVcWbBFj7d2rG/1IQcD1m+itufRno0nY2bgS8+ljqRZsoAcVqLp9Uc/+E1 9TcSz8gPdizJaA2RQsDXQEWUd2SRgsOIVW6ZwqfDEkaW72A6aszGqHKI2YR84IXAJDhq6IQPIn a5KpSfa2QQAfpKTUKxEmEMIBTqE+MTM1WZDh+jyEIElcSgHo4cpBwKTCSUzJXGm29j74459CT1 VSs= From: Thomas Schwinge To: Alexandre Oliva , Subject: Tag 'gcc/gimple-expr.cc:mark_addressable_2' as 'static' (was: [PR67891] drop is_gimple_reg test from set_parm_rtl) In-Reply-To: References: <20150810082355.GA31149@arm.com> <55C8BFC3.3030603@redhat.com> <55E72D4C.40705@arm.com> <55FC3171.7040509@arm.com> <56382653.4060605@redhat.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Oct 2022 14:08:47 +0200 Message-ID: <871qr6ire8.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi! On 2015-11-03T02:29:41-0200, Alexandre Oliva wrote: > Thanks, here's the patch as just installed. > --- a/gcc/gimple-expr.c > +++ b/gcc/gimple-expr.c > +static void > +mark_addressable_1 (tree x) > +{ > + [...] > +} > + > +/* Adaptor for mark_addressable_1 for use in hash_set traversal. */ > + > +bool > +mark_addressable_2 (tree const &x, void * ATTRIBUTE_UNUSED = NULL) > +{ > + mark_addressable_1 (x); > + return false; > +} Found already a while ago, now pushed to master branch in commit aeb1e2bff95ae17717026905ef404699d91f5c61 "Tag 'gcc/gimple-expr.cc:mark_addressable_2' as 'static'", see attached. Grüße Thomas > +void > +flush_mark_addressable_queue () > +{ > + gcc_assert (!currently_expanding_to_rtl); > + if (mark_addressable_queue) > + { > + mark_addressable_queue->traverse (NULL); > + delete mark_addressable_queue; > + mark_addressable_queue = NULL; > + } > +} > --- a/gcc/gimple-expr.h > +++ b/gcc/gimple-expr.h > +extern void flush_mark_addressable_queue (void); ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From aeb1e2bff95ae17717026905ef404699d91f5c61 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 15 Dec 2021 22:00:53 +0100 Subject: [PATCH] Tag 'gcc/gimple-expr.cc:mark_addressable_2' as 'static' Added in 2015 r229696 (commit 1b223a9f3489296c625bdb7cc764196d04fd9231) "defer mark_addressable calls during expand till the end of expand", it has never been used 'extern'ally. gcc/ * gimple-expr.cc (mark_addressable_2): Tag as 'static'. --- gcc/gimple-expr.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gimple-expr.cc b/gcc/gimple-expr.cc index c9c7285efbc..4fbce9369c7 100644 --- a/gcc/gimple-expr.cc +++ b/gcc/gimple-expr.cc @@ -912,7 +912,7 @@ mark_addressable_1 (tree x) /* Adaptor for mark_addressable_1 for use in hash_set traversal. */ -bool +static bool mark_addressable_2 (tree const &x, void * ATTRIBUTE_UNUSED = NULL) { mark_addressable_1 (x); -- 2.35.1